- Linux-kselftest-mirror - lists.linaro.org

by Pavan Bobba

corrected a minor grammer mistake Signed-off-by: Pavan Bobba <opensource206(a)gmail.com> --- tools/testing/selftests/acct/acct_syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c index 87c044fb9293..ee2894e4f7bc 100644 --- a/tools/testing/selftests/acct/acct_syscall.c +++ b/tools/testing/selftests/acct/acct_syscall.c @@ -22,7 +22,7 @@ int main(void) ksft_print_header(); ksft_set_plan(1); - // Check if test is run a root + // Check if test is run as root if (geteuid()) { ksft_exit_skip("This test needs root to run!\n"); return 1; -- 2.43.0

3 weeks, 3 days

1
0
0 0

[PATCH v2 0/5] platform/chrome: Fix a possible UAF via revocable

by Tzung-Bi Shih

This is a follow-up series of [1]. It tries to fix a possible UAF in the fops of cros_ec_chardev after the underlying protocol device has gone by using revocable. The 1st patch introduces the revocable which is an implementation of ideas from the talk [2]. The 2nd and 3rd patches add test cases for revocable in Kunit and selftest. The 4th patch converts existing protocol devices to resource providers of cros_ec_device. The 5th patch converts cros_ec_chardev to a resource consumer of cros_ec_device to fix the UAF. [1] https://lore.kernel.org/chrome-platform/20250721044456.2736300-6-tzungbi@ke… [2] https://lpc.events/event/17/contributions/1627/ Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Bartosz Golaszewski <bartosz.golaszewski(a)linaro.org> Cc: Wolfram Sang <wsa+renesas(a)sang-engineering.com> v2: - Rename "ref_proxy" -> "revocable". - Add test cases in Kunit and selftest. v1: https://lore.kernel.org/chrome-platform/20250814091020.1302888-1-tzungbi@ke… Tzung-Bi Shih (5): revocable: Revocable resource management revocable: Add Kunit test cases selftests: revocable: Add kselftest cases platform/chrome: Protect cros_ec_device lifecycle with revocable platform/chrome: cros_ec_chardev: Consume cros_ec_device via revocable .../driver-api/driver-model/index.rst | 1 + .../driver-api/driver-model/revocable.rst | 151 ++++++++++++ MAINTAINERS | 9 + drivers/base/Kconfig | 8 + drivers/base/Makefile | 5 +- drivers/base/revocable.c | 229 ++++++++++++++++++ drivers/base/revocable_test.c | 110 +++++++++ drivers/platform/chrome/cros_ec_chardev.c | 124 +++++++--- drivers/platform/chrome/cros_ec_i2c.c | 5 + drivers/platform/chrome/cros_ec_ishtp.c | 5 + drivers/platform/chrome/cros_ec_lpc.c | 5 + drivers/platform/chrome/cros_ec_rpmsg.c | 5 + drivers/platform/chrome/cros_ec_spi.c | 4 + drivers/platform/chrome/cros_ec_uart.c | 5 + include/linux/platform_data/cros_ec_proto.h | 4 + include/linux/revocable.h | 37 +++ tools/testing/selftests/Makefile | 1 + .../selftests/drivers/base/revocable/Makefile | 7 + .../drivers/base/revocable/revocable_test.c | 116 +++++++++ .../drivers/base/revocable/test-revocable.sh | 39 +++ .../base/revocable/test_modules/Makefile | 10 + .../revocable/test_modules/revocable_test.c | 188 ++++++++++++++ 22 files changed, 1027 insertions(+), 41 deletions(-) create mode 100644 Documentation/driver-api/driver-model/revocable.rst create mode 100644 drivers/base/revocable.c create mode 100644 drivers/base/revocable_test.c create mode 100644 include/linux/revocable.h create mode 100644 tools/testing/selftests/drivers/base/revocable/Makefile create mode 100644 tools/testing/selftests/drivers/base/revocable/revocable_test.c create mode 100755 tools/testing/selftests/drivers/base/revocable/test-revocable.sh create mode 100644 tools/testing/selftests/drivers/base/revocable/test_modules/Makefile create mode 100644 tools/testing/selftests/drivers/base/revocable/test_modules/revocable_test.c -- 2.51.0.rc1.167.g924127e9c0-goog

3 weeks, 3 days

1
5
0 0

[PATCH] selftests/ftrace: Split worlds in return string

by Bartlomiej Kubik

Split concatenated words in return string. Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej(a)gmail.com> --- tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc index 9933ed24f901..47fd615a4542 100644 --- a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc +++ b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc @@ -110,7 +110,7 @@ fi cnt=`count_pid $child` if [ $cnt -ne 0 ]; then - fail "Child of filtered out taskhas events" + fail "Child of filtered out task has events" fi cnt=`count_no_pid $mypid` -- 2.39.5

3 weeks, 3 days

1
0
0 0

[PATCH] selftests/timers: Improve POSIX timer test messages

by I Viswanath

- Break up the ksft_print_msg statements to follow the 80 char rule. - Capitalize "POSIX" and rephrase messages for better readability. - Clarify that false negatives may occur in tests relying on timers if other threads run on the CPU. Signed-off-by: I Viswanath <viswanathiyyappan(a)gmail.com> --- tools/testing/selftests/timers/posix_timers.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c index f0eceb0faf34..017a9e19ad0f 100644 --- a/tools/testing/selftests/timers/posix_timers.c +++ b/tools/testing/selftests/timers/posix_timers.c @@ -673,8 +673,9 @@ int main(int argc, char **argv) ksft_print_header(); ksft_set_plan(19); - ksft_print_msg("Testing posix timers. False negative may happen on CPU execution \n"); - ksft_print_msg("based timers if other threads run on the CPU...\n"); + ksft_print_msg("Testing POSIX timers.\n"); + ksft_print_msg("False negatives may occur in tests\n"); + ksft_print_msg("relying on timers if other threads run on the CPU\n"); check_timer_create_exact(); -- 2.50.1

3 weeks, 3 days

1
0
0 0

Re: [PATCH v2 13/20] x86/mm: enable page table sharing

by Yongting Lin

Thank you! Anthony. Yep, I checked the comments in arch/mm/x86/fault.c file which says as your advices in previous email. I changed my code in kernel 5.5 as below: if (unlikely(is_shared_vma) && ((fault & VM_FAULT_RETRY) && (flags & FAULT_FLAG_ALLOW_RETRY) || fault_signal_pending(fault, regs))) mmap_read_unlock(mm); BTW: I wrote some selftests in my github repostory, which perform the basic function of mshare, and I will write some complicated cases to support the new functions or defect found in mshare. For example, once you support mshare as a VMA in KVM (just as the defeat viewed by Jann Horn), I will add extra test cases to verify its correctiness for this scenario. From Jann Horn's review: https://lore.kernel.org/all/CAG48ez3cUZf+xOtP6UkkS2-CmOeo+3K5pvny0AFL_XBkHh… Currently, I put my selftest in my github repostory, and you could retrieve it as below: git remote add yongting-mshare-selftests https://github.com/ivanalgo/linux-kernel-develop/ git fetch yongting-mshare-selftests dev-mshare-v2-selftest-v1 git cherry-pick a64f2ff6497d13c09badc0fc68c44d9995bc2fef At this stage, I am not sure what is the best way to proceed: - Should I send them as part of your next version (v3)? - Or should I post them separately as [RFC PATCH] for early review? Please let me know your preference and any sugestion is welcome. I am happy to rebase and resend in the format that works best for the community. Thanks Yongting > Anthony > >> >> As a result, needs to release vma->vm_mm.mmap_lock as well. >> >> So it is supposed to be like below: >> >> - fault = handle_mm_fault(vma, address, flags, regs); >> + fault = handle_mm_fault(vma, addr, flags, regs); >> + >> + if (unlikely(is_shared_vma) && ((fault & VM_FAULT_COMPLETED) || >> + (fault & VM_FAULT_RETRY) || fault_signal_pending(fault, regs))) { >> + mmap_read_unlock(vma->vm_mm); >> + mmap_read_unlock(mm); >> + } >> >>> if (fault_signal_pending(fault, regs)) { >>> /* >>> @@ -1413,6 +1446,8 @@ void do_user_addr_fault(struct pt_regs *regs, >>> goto retry; >>> } >>> + if (unlikely(is_shared_vma)) >>> + mmap_read_unlock(vma->vm_mm); >>> mmap_read_unlock(mm); >>> done: >>> if (likely(!(fault & VM_FAULT_ERROR))) >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index e6c90db83d01..8a5a159457f2 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -1344,7 +1344,7 @@ config PT_RECLAIM >>> config MSHARE >>> bool "Mshare" >>> - depends on MMU >>> + depends on MMU && ARCH_SUPPORTS_MSHARE >>> help >>> Enable msharefs: A ram-based filesystem that allows multiple >>> processes to share page table entries for shared pages. A file >> >> Yongting Lin. > >

3 weeks, 3 days

2
1
0 0

[PATCH net-next] selftests: drv-net: tso: increase the retransmit threshold

by Jakub Kicinski

We see quite a few flakes during the TSO test against virtualized devices in NIPA. There's often 10-30 retransmissions during the test. Sometimes as many as 100. Set the retransmission threshold at 1/4th of the wire frame target. Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> --- CC: shuah(a)kernel.org CC: willemb(a)google.com CC: daniel.zahka(a)gmail.com CC: linux-kselftest(a)vger.kernel.org --- tools/testing/selftests/drivers/net/hw/tso.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/tso.py b/tools/testing/selftests/drivers/net/hw/tso.py index c13dd5efa27a..0998e68ebaf0 100755 --- a/tools/testing/selftests/drivers/net/hw/tso.py +++ b/tools/testing/selftests/drivers/net/hw/tso.py @@ -60,16 +60,17 @@ from lib.py import bkg, cmd, defer, ethtool, ip, rand_port, wait_port_listen sock_wait_drain(sock) qstat_new = cfg.netnl.qstats_get({"ifindex": cfg.ifindex}, dump=True)[0] - # No math behind the 10 here, but try to catch cases where - # TCP falls back to non-LSO. - ksft_lt(tcp_sock_get_retrans(sock), 10) - sock.close() - # Check that at least 90% of the data was sent as LSO packets. # System noise may cause false negatives. Also header overheads # will add up to 5% of extra packes... The check is best effort. total_lso_wire = len(buf) * 0.90 // cfg.dev["mtu"] total_lso_super = len(buf) * 0.90 // cfg.dev["tso_max_size"] + + # Make sure we have order of magnitude more LSO packets than + # retransmits, in case TCP retransmitted all the LSO packets. + ksft_lt(tcp_sock_get_retrans(sock), total_lso_wire / 4) + sock.close() + if should_lso: if cfg.have_stat_super_count: ksft_ge(qstat_new['tx-hw-gso-packets'] - -- 2.50.1

3 weeks, 3 days

3
3
0 0

[PATCH net-next] selftests: drv-net: ncdevmem: make configure_channels() support combined channels

by Jakub Kicinski

ncdevmem tests that the kernel correctly rejects attempts to deactivate queues with MPs bound. Make the configure_channels() test support combined channels. Currently it tries to set the queue counts to rx N tx N-1, which only makes sense for devices which have IRQs per ring type. Most modern devices used combined IRQs/channels with both Rx and Tx queues. Since the math is total Rx == combined+Rx setting Rx when combined is non-zero will be increasing the total queue count, not decreasing as the test intends. Note that the test would previously also try to set the Tx ring count to Rx - 1, for some reason. Which would be 0 if the device has only 2 queues configured. With this change (device with 2 queues): setting channel count rx:1 tx:1 YNL set channels: Kernel error: 'requested channel counts are too low for existing memory provider setting (2)' Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> --- CC: shuah(a)kernel.org CC: almasrymina(a)google.com CC: sdf(a)fomichev.me CC: joe(a)dama.to CC: linux-kselftest(a)vger.kernel.org --- .../selftests/drivers/net/hw/ncdevmem.c | 78 ++++++++++++++++++- 1 file changed, 76 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c index be937542b4c0..71961a7688e6 100644 --- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c +++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c @@ -356,7 +356,81 @@ static int configure_rss(void) static int configure_channels(unsigned int rx, unsigned int tx) { - return run_command("ethtool -L %s rx %u tx %u", ifname, rx, tx); + struct ethtool_channels_get_req *gchan; + struct ethtool_channels_set_req *schan; + struct ethtool_channels_get_rsp *chan; + struct ynl_error yerr; + struct ynl_sock *ys; + int ret; + + fprintf(stderr, "setting channel count rx:%u tx:%u\n", rx, tx); + + ys = ynl_sock_create(&ynl_ethtool_family, &yerr); + if (!ys) { + fprintf(stderr, "YNL: %s\n", yerr.msg); + return -1; + } + + gchan = ethtool_channels_get_req_alloc(); + if (!gchan) { + ret = -1; + goto exit_close_sock; + } + + ethtool_channels_get_req_set_header_dev_index(gchan, ifindex); + chan = ethtool_channels_get(ys, gchan); + ethtool_channels_get_req_free(gchan); + if (!chan) { + fprintf(stderr, "YNL get channels: %s\n", ys->err.msg); + ret = -1; + goto exit_close_sock; + } + + schan = ethtool_channels_set_req_alloc(); + if (!schan) { + ret = -1; + goto exit_free_chan; + } + + ethtool_channels_set_req_set_header_dev_index(schan, ifindex); + + if (chan->_present.combined_count) { + if (chan->_present.rx_count || chan->_present.tx_count) { + ethtool_channels_set_req_set_rx_count(schan, 0); + ethtool_channels_set_req_set_tx_count(schan, 0); + } + + if (rx == tx) { + ethtool_channels_set_req_set_combined_count(schan, rx); + } else if (rx > tx) { + ethtool_channels_set_req_set_combined_count(schan, tx); + ethtool_channels_set_req_set_rx_count(schan, rx - tx); + } else { + ethtool_channels_set_req_set_combined_count(schan, rx); + ethtool_channels_set_req_set_tx_count(schan, tx - rx); + } + + ret = ethtool_channels_set(ys, schan); + if (ret) + fprintf(stderr, "YNL set channels: %s\n", ys->err.msg); + } else if (chan->_present.rx_count) { + ethtool_channels_set_req_set_rx_count(schan, rx); + ethtool_channels_set_req_set_tx_count(schan, tx); + + ret = ethtool_channels_set(ys, schan); + if (ret) + fprintf(stderr, "YNL set channels: %s\n", ys->err.msg); + } else { + fprintf(stderr, "Error: device has neither combined nor rx channels\n"); + ret = -1; + } + ethtool_channels_set_req_free(schan); +exit_free_chan: + ethtool_channels_get_rsp_free(chan); +exit_close_sock: + ynl_sock_destroy(ys); + + return ret; } static int configure_flow_steering(struct sockaddr_in6 *server_sin) @@ -752,7 +826,7 @@ void run_devmem_tests(void) error(1, 0, "Failed to bind\n"); /* Deactivating a bound queue should not be legal */ - if (!configure_channels(num_queues, num_queues - 1)) + if (!configure_channels(num_queues, num_queues)) error(1, 0, "Deactivating a bound queue should be illegal.\n"); /* Closing the netlink socket does an implicit unbind */ -- 2.50.1

3 weeks, 3 days

3
2
0 0

[RFC PATCH v3 0/2] cgroup: Track time in cgroup v2 freezer

by Tiffany Yang

Hello, The cgroup v2 freezer controller is useful for freezing background applications so they don't contend with foreground tasks. However, this may disrupt any internal monitoring that the application is performing, as it may not be aware that it was frozen. To illustrate, an application might implement a watchdog thread to monitor a high-priority task by periodically checking its state to ensure progress. The challenge is that the task only advances when the application is running, but watchdog timers are set relative to system time, not app time. If the app is frozen and misses the expected deadline, the watchdog, unaware of this pause, may kill a healthy process. This series tracks the time that each cgroup spends "freezing" and exposes it via cgroup.freeze.stat.local. If others prefer, I can instead create cgroup.stat.local and allow the freeze time accounting to be accessed there instead. This version includes several basic selftests. I would find feedback especially useful here! Along with testing basic functionality, I wanted to demonstrate the following relationships: 1. Freeze time will increase while a cgroup is freezing, regardless of whether it is frozen or not. 2. Each cgroup's freeze time is independent from the other cgroups in its hierarchy. I was hoping to show (1.) with a test that freezes a cgroup and then checks its freeze time while cgroup.events still shows "frozen 0", but I am having trouble writing a case that can reliably cause this (even when letting a forkbomb grow for a while before attempting to freeze!). Ideally, I could populate a test cgroup with an unfreezable task. Is there an elegant way to create a process from a selftest that will become TASK_INTERRUPTIBLE? The main challenge in establishing (2.) is that in order to make a meaningful comparison between two cgroups' freeze times, they need to be obtained at around the same time. The test process may check one cgroup's freeze time, but then it may be preempted and delayed from checking another cgroup's for a relatively "long" time. I have tried to use sleeps to increase what a "long" time would be, but this possibility makes tests like test_cgfreezer_time_parent non-deterministic, so I am a bit squeamish about adding it here. Any suggestions for better tests or anything else would be welcome. Thank you! Tiffany Signed-off-by: Tiffany Yang <ynaffit(a)google.com> --- v3: * Use seqcount along with css_set_lock to guard freeze time accesses as suggested by Michal Koutný * Add selftests v2: https://lore.kernel.org/lkml/20250714050008.2167786-2-ynaffit@google.com/ * Track per-cgroup freezing time instead of per-task frozen time as suggested by Tejun Heo v1: https://lore.kernel.org/lkml/20250603224304.3198729-3-ynaffit@google.com/ Cc: John Stultz <jstultz(a)google.com> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Stephen Boyd <sboyd(a)kernel.org> Cc: Anna-Maria Behnsen <anna-maria(a)linutronix.de> Cc: Frederic Weisbecker <frederic(a)kernel.org> Cc: Tejun Heo <tj(a)kernel.org> Cc: Johannes Weiner <hannes(a)cmpxchg.org> Cc: Michal Koutný <mkoutny(a)suse.com> Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Cc: Pavel Machek <pavel(a)kernel.org> Cc: Roman Gushchin <roman.gushchin(a)linux.dev> Cc: Chen Ridong <chenridong(a)huawei.com> Tiffany Yang (2): cgroup: cgroup.freeze.stat.local time accounting cgroup: selftests: Add tests for freezer time Documentation/admin-guide/cgroup-v2.rst | 20 + include/linux/cgroup-defs.h | 17 + kernel/cgroup/cgroup.c | 28 + kernel/cgroup/freezer.c | 10 +- tools/testing/selftests/cgroup/test_freezer.c | 686 ++++++++++++++++++ 5 files changed, 759 insertions(+), 2 deletions(-) -- 2.50.1.565.gc32cd1483b-goog

3 weeks, 3 days

3
7
0 0

[PATCH] selftests/x86: fix coding style errors in test_syscall_vdso.c

by Raphael Pinsonneault-Thibeault

fix 68 checkpatch errors in tools/testing/selftests/x86/test_syscall_vdso.c: add void to function definitions without parameters fix whitespace in charp array definitions fix whitespace in printf statements Signed-off-by: Raphael Pinsonneault-Thibeault <rpthibeault(a)gmail.com> --- for the whitespace errors, attempted to maintain the ��prettiness�� of the charp definition and the printf statements .../testing/selftests/x86/test_syscall_vdso.c | 59 ++++++++++--------- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c b/tools/testing/selftests/x86/test_syscall_vdso.c index 8965c311bd65..ee98c3cf4f56 100644 --- a/tools/testing/selftests/x86/test_syscall_vdso.c +++ b/tools/testing/selftests/x86/test_syscall_vdso.c @@ -116,10 +116,10 @@ void print_regs64(void) { if (!kernel_is_64bit) return; - printf("ax:%016llx bx:%016llx cx:%016llx dx:%016llx\n", regs64.rax, regs64.rbx, regs64.rcx, regs64.rdx); - printf("si:%016llx di:%016llx bp:%016llx sp:%016llx\n", regs64.rsi, regs64.rdi, regs64.rbp, regs64.rsp); - printf(" 8:%016llx 9:%016llx 10:%016llx 11:%016llx\n", regs64.r8 , regs64.r9 , regs64.r10, regs64.r11); - printf("12:%016llx 13:%016llx 14:%016llx 15:%016llx\n", regs64.r12, regs64.r13, regs64.r14, regs64.r15); + printf("ax:%016llx bx:%016llx cx:%016llx dx:%016llx\n", regs64.rax, regs64.rbx, regs64.rcx, regs64.rdx); + printf("si:%016llx di:%016llx bp:%016llx sp:%016llx\n", regs64.rsi, regs64.rdi, regs64.rbp, regs64.rsp); + printf(" 8:%016llx 9:%016llx 10:%016llx 11:%016llx\n", regs64.r8, regs64.r9, regs64.r10, regs64.r11); + printf("12:%016llx 13:%016llx 14:%016llx 15:%016llx\n", regs64.r12, regs64.r13, regs64.r14, regs64.r15); } int check_regs64(void) @@ -179,7 +179,7 @@ struct { int sz; } sigmask_desc; -void prep_args() +void prep_args(void) { nfds = 42; FD_ZERO(&rfds); @@ -201,28 +201,28 @@ void prep_args() static void print_flags(const char *name, unsigned long r) { static const char *bitarray[] = { - "\n" ,"c\n" ,/* Carry Flag */ - "0 " ,"1 " ,/* Bit 1 - always on */ - "" ,"p " ,/* Parity Flag */ - "0 " ,"3? " , - "" ,"a " ,/* Auxiliary carry Flag */ - "0 " ,"5? " , - "" ,"z " ,/* Zero Flag */ - "" ,"s " ,/* Sign Flag */ - "" ,"t " ,/* Trap Flag */ - "" ,"i " ,/* Interrupt Flag */ - "" ,"d " ,/* Direction Flag */ - "" ,"o " ,/* Overflow Flag */ - "0 " ,"1 " ,/* I/O Privilege Level (2 bits) */ - "0" ,"1" ,/* I/O Privilege Level (2 bits) */ - "" ,"n " ,/* Nested Task */ - "0 " ,"15? ", - "" ,"r " ,/* Resume Flag */ - "" ,"v " ,/* Virtual Mode */ - "" ,"ac " ,/* Alignment Check/Access Control */ - "" ,"vif ",/* Virtual Interrupt Flag */ - "" ,"vip ",/* Virtual Interrupt Pending */ - "" ,"id " ,/* CPUID detection */ + "\n", "c\n", /* Carry Flag */ + "0 ", "1 ", /* Bit 1 - always on */ + "", "p ", /* Parity Flag */ + "0 ", "3? ", + "", "a ", /* Auxiliary carry Flag */ + "0 ", "5? ", + "", "z ", /* Zero Flag */ + "", "s ", /* Sign Flag */ + "", "t ", /* Trap Flag */ + "", "i ", /* Interrupt Flag */ + "", "d ", /* Direction Flag */ + "", "o ", /* Overflow Flag */ + "0 ", "1 ", /* I/O Privilege Level (2 bits) */ + "0", "1", /* I/O Privilege Level (2 bits) */ + "", "n ", /* Nested Task */ + "0 ", "15? ", + "", "r ", /* Resume Flag */ + "", "v ", /* Virtual Mode */ + "", "ac ", /* Alignment Check/Access Control */ + "", "vif ", /* Virtual Interrupt Flag */ + "", "vip ", /* Virtual Interrupt Pending */ + "", "id ", /* CPUID detection */ NULL }; const char **bitstr; @@ -320,7 +320,7 @@ int run_syscall(void) return check_regs64(); } -int run_syscall_twice() +int run_syscall_twice(void) { int exitcode = 0; long sv; @@ -337,7 +337,7 @@ int run_syscall_twice() return exitcode; } -void ptrace_me() +void ptrace_me(void) { pid_t pid; @@ -356,6 +356,7 @@ void ptrace_me() printf("[RUN]\tRunning tests under ptrace\n"); while (1) { int status; + pid = waitpid(-1, &status, __WALL); if (WIFEXITED(status)) exit(WEXITSTATUS(status)); -- 2.43.0

3 weeks, 3 days

1
0
0 0

[PATCH] selftests/futex: Fix some futex_numa_mpol subtests

by Waiman Long

The "Memory out of range" subtest of futex_numa_mpol assumes that memory access outside of the mmap'ed area is invalid. That may not be the case depending on the actual memory layout of the test application. When that subtest was run on an x86-64 system with latest upstream kernel, the test passed as an error was returned from futex_wake(). On another powerpc system, the same subtest failed because futex_wake() returned 0. Bail out! futex2_wake(64, 0x86) should fail, but didn't Looking further into the passed subtest on x86-64, it was found that an -EINVAL was returned instead of -EFAULT. The -EINVAL error was returned because the node value test with FLAGS_NUMA set failed with a node value of 0x7f7f. IOW, the futex memory was accessible and futex_wake() failed because the supposed node number wasn't valid. If that memory location happens to have a very small value (e.g. 0), the test will pass and no error will be returned. Since this subtest is non-deterministic, it is dropped unless we explicitly set a guard page beyond the mmap region. The other problematic test is the "Memory too small" test. The futex_wake() function returns the -EINVAL error code because the given futex address isn't 8-byte aligned, not because only 4 of the 8 bytes are valid and the other 4 bytes are not. So proper name of this subtest is changed to "Mis-aligned futex" to reflect the reality. Fixes: 3163369407ba ("selftests/futex: Add futex_numa_mpol") Signed-off-by: Waiman Long <longman(a)redhat.com> --- tools/testing/selftests/futex/functional/futex_numa_mpol.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools/testing/selftests/futex/functional/futex_numa_mpol.c index a9ecfb2d3932..802c15c82190 100644 --- a/tools/testing/selftests/futex/functional/futex_numa_mpol.c +++ b/tools/testing/selftests/futex/functional/futex_numa_mpol.c @@ -182,12 +182,10 @@ int main(int argc, char *argv[]) if (futex_numa->numa == FUTEX_NO_NODE) ksft_exit_fail_msg("NUMA node is left uninitialized\n"); - ksft_print_msg("Memory too small\n"); + /* FUTEX2_NUMA futex must be 8-byte aligned */ + ksft_print_msg("Mis-aligned futex\n"); test_futex(futex_ptr + mem_size - 4, 1); - ksft_print_msg("Memory out of range\n"); - test_futex(futex_ptr + mem_size, 1); - futex_numa->numa = FUTEX_NO_NODE; mprotect(futex_ptr, mem_size, PROT_READ); ksft_print_msg("Memory, RO\n"); -- 2.50.1

3 weeks, 3 days

4
4
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror