- Linux-kselftest-mirror - lists.linaro.org

kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0

by Naresh Kamboju

Kernel warning while running kernel selftest bpf test_sockmap test case on x86_64 and arm64. The kernel warning log pops up continuously. Linux version 5.1.10-rc2 Steps to reproduce: Boot stable rc 5.1.10-rc2 kernel on x86_64 or arm64 cd selftests/bpf ./test_sockmap [ 37.600406] WARNING: CPU: 3 PID: 57 at /usr/src/kernel/kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0 [ 37.610034] Modules linked in: x86_pkg_temp_thermal fuse [ 37.615371] CPU: 3 PID: 57 Comm: kworker/3:1 Not tainted 5.1.10-rc2 #1 [ 37.615454] WARNING: CPU: 0 PID: 5 at /usr/src/kernel/kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0 [ 37.621892] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 37.621895] Workqueue: events sk_psock_destroy_deferred [ 37.631183] Modules linked in: x86_pkg_temp_thermal fuse [ 37.638654] RIP: 0010:__flush_work+0x2c2/0x2d0 [ 37.638655] Code: c6 00 31 c0 e9 71 ff ff ff 41 8b 0c 24 49 8b 54 24 08 83 e1 08 49 0f ba 2c 24 03 80 c9 f0 e9 d2 fe ff ff 0f 0b e9 50 ff ff ff <0f> 0b 31 c0 e9 47 ff ff ff e8 90 9d fd ff 0f 1f 44 00 00 55 31 f6 [ 37.643879] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.1.10-rc2 #1 [ 37.643880] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 37.649183] RSP: 0018:ffffb038c1a23ca0 EFLAGS: 00010246 [ 37.653630] Workqueue: events sk_psock_destroy_deferred [ 37.672375] RAX: 0000000000000000 RBX: ffff9e73d9492068 RCX: 0000000000000006 [ 37.672376] RDX: 0000000000000006 RSI: 0000000000000001 RDI: ffff9e73d9492068 [ 37.678805] RIP: 0010:__flush_work+0x2c2/0x2d0 [ 37.678807] Code: c6 00 31 c0 e9 71 ff ff ff 41 8b 0c 24 49 8b 54 24 08 83 e1 08 49 0f ba 2c 24 03 80 c9 f0 e9 d2 fe ff ff 0f 0b e9 50 ff ff ff <0f> 0b 31 c0 e9 47 ff ff ff e8 90 9d fd ff 0f 1f 44 00 00 55 31 f6 [ 37.686274] RBP: ffffb038c1a23d68 R08: 0000000000000000 R09: 0000000000000000 [ 37.686275] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e73d9492068 [ 37.691494] RSP: 0018:ffffb038c18fbca0 EFLAGS: 00010246 [ 37.696720] R13: 0000000000000001 R14: ffffb038c1a23d98 R15: ffffffff9a490d40 [ 37.696721] FS: 0000000000000000(0000) GS:ffff9e73dfb80000(0000) knlGS:0000000000000000 [ 37.703851] RAX: 0000000000000000 RBX: ffff9e73d9490868 RCX: 0000000000000006 [ 37.703852] RDX: 0000000000000006 RSI: 0000000000000001 RDI: ffff9e73d9490868 [ 37.710976] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 37.710977] CR2: 00007f38680ca8a0 CR3: 00000002ee614006 CR4: 00000000003606e0 [ 37.715419] RBP: ffffb038c18fbd68 R08: 0000000000000000 R09: 0000000000000000 [ 37.715420] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e73d9490868 [ 37.734156] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 37.734157] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 37.741282] R13: 0000000000000001 R14: ffffb038c18fbd98 R15: ffffffff9a490d40 [ 37.741283] FS: 0000000000000000(0000) GS:ffff9e73dfa00000(0000) knlGS:0000000000000000 [ 37.748405] Call Trace: [ 37.748410] ? work_busy+0xc0/0xc0 [ 37.753621] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 37.753622] CR2: 00007f38680c9788 CR3: 000000045454a004 CR4: 00000000003606f0 [ 37.760746] ? mark_held_locks+0x4d/0x80 [ 37.768823] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 37.768824] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 37.775946] ? __cancel_work_timer+0x11a/0x1d0 [ 37.783071] Call Trace: [ 37.783075] ? work_busy+0xc0/0xc0 [ 37.788808] ? cancel_delayed_work_sync+0x13/0x20 [ 37.788810] ? lockdep_hardirqs_on+0xf6/0x190 [ 37.795934] ? mark_held_locks+0x4d/0x80 [ 37.803055] ? __cancel_work_timer+0x11a/0x1d0 [ 37.803057] ? work_busy+0xc0/0xc0 [ 37.810179] ? __cancel_work_timer+0x11a/0x1d0 [ 37.817303] __cancel_work_timer+0x134/0x1d0 [ 37.824453] ? cancel_delayed_work_sync+0x13/0x20 [ 37.824455] ? lockdep_hardirqs_on+0xf6/0x190 [ 37.831579] cancel_delayed_work_sync+0x13/0x20 [ 37.839654] ? __cancel_work_timer+0x11a/0x1d0 [ 37.839657] ? work_busy+0xc0/0xc0 [ 37.842100] strp_done+0x1c/0x50 [ 37.845497] __cancel_work_timer+0x134/0x1d0 [ 37.851242] sk_psock_destroy_deferred+0x34/0x1c0 [ 37.858372] cancel_delayed_work_sync+0x13/0x20 [ 37.862292] process_one_work+0x281/0x610 [ 37.869415] strp_done+0x1c/0x50 [ 37.876540] worker_thread+0x3c/0x3f0 [ 37.880975] sk_psock_destroy_deferred+0x34/0x1c0 [ 37.883419] ? __kthread_parkme+0x61/0x90 [ 37.886819] process_one_work+0x281/0x610 [ 37.891514] kthread+0x12c/0x150 [ 37.895868] worker_thread+0x3c/0x3f0 [ 37.899783] ? process_one_work+0x610/0x610 [ 37.904221] kthread+0x12c/0x150 [ 37.907615] ? kthread_park+0x90/0x90 [ 37.907618] ret_from_fork+0x3a/0x50 [ 37.912052] ? process_one_work+0x610/0x610 [ 37.916355] irq event stamp: 57860 [ 37.921058] ? kthread_park+0x90/0x90 [ 37.921060] ret_from_fork+0x3a/0x50 [ 37.925407] hardirqs last enabled at (57859): [<ffffffff9a4949ba>] __cancel_work_timer+0x11a/0x1d0 [ 37.925409] hardirqs last disabled at (57860): [<ffffffff9a401bab>] trace_hardirqs_off_thunk+0x1a/0x1c [ 37.929944] irq event stamp: 47474 [ 37.934378] softirqs last enabled at (57812): [<ffffffff9add14d5>] release_sock+0x85/0xb0 [ 37.934379] softirqs last disabled at (57810): [<ffffffff9add140a>] __release_sock+0xda/0x120 [ 37.937773] hardirqs last enabled at (47473): [<ffffffff9a4949ba>] __cancel_work_timer+0x11a/0x1d0 [ 37.937775] hardirqs last disabled at (47474): [<ffffffff9a401bab>] trace_hardirqs_off_thunk+0x1a/0x1c [ 37.940998] ---[ end trace ae349dc9a55c8bc8 ]--- [ 37.941056] WARNING: CPU: 3 PID: 57 at /usr/src/kernel/kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0 [ 37.945263] softirqs last enabled at (47440): [<ffffffff9add14d5>] release_sock+0x85/0xb0 [ 37.945264] softirqs last disabled at (47438): [<ffffffff9add140a>] __release_sock+0xda/0x120 [ 37.949968] Modules linked in: x86_pkg_temp_thermal fuse [ 37.954493] ---[ end trace ae349dc9a55c8bc9 ]--- [ 37.954522] WARNING: CPU: 0 PID: 5 at /usr/src/kernel/kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0 [...] metadata: git branch: linux-5.1.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git commit: b7eabc3862b8717f2bcc47f3f3830ec575423c8c git describe: v5.1.9-157-gb7eabc3862b8 make_kernelversion: 5.1.10-rc2 kernel-config: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkf… kernel-defconfig: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkf… build-url: https://ci.linaro.org/job/openembedded-lkft-linux-stable-rc-5.1/DISTRO=lkft… build-location: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkf… toolchain: x86_64-linaro-linux 7.% series: lkft email-notification: '' kselftest__url: https://www.kernel.org/pub/linux/kernel/v5.x/linux-5.1.tar.xz kselftest__version: '5.1' kselftest__revision: '5.1' Full test log, https://lkft.validation.linaro.org/scheduler/job/775857#L1114 Best regards Naresh Kamboju

6 years, 4 months

1
1
0 0

Fixing Python 3 syntax errors in tpm2_tests.py

by Christian Clauss

Hello, As my very first contribution to the Linux Kernel, I would like to fix six Python 3 syntax errors in the file ./tools/testing/selftests/tpm2/tpm2_tests.py All six of these errors are of the same form: except ProtocolError, e: To fix the syntax errors, I propose to change the comma (,) to “as” like: except ProtocolError as e: These changes are important because the current form is compatible with Python 2 but is a syntax error in Python 3. The proposed form is compatible with both Python 2 and Python3. This conversion is required because Python 2 will reach its end of life in less than 200 days. The kernel contains at least five other files where I am able to detect Python 3 syntax errors but after studying in detail the process of making kernel modification, I believe that it is best to start with tpm2_tests.py because the changes are straightforward and uncontroversial — all issues are of the same form, and I can detect no other issues (such as undefined names) to fix in that file. If I succeed in getting the modifications to tpm2_tests.py through the review process then I can try the remaining files in turn. I would be interested to know if this is a worthwhile effort. Is there already another initiative to resolve these issue before yearend? Thanks for any advise that you can provide, Chris Clauss

6 years, 4 months

2
1
0 0

[PATCH net-next v3 0/3] UDP GSO audit tests

by Fred Klassen

Updates to UDP GSO selftests ot optionally stress test CMSG subsytem, and report the reliability and performance of both TX Timestamping and ZEROCOPY messages. Fred Klassen (3): net/udpgso_bench_tx: options to exercise TX CMSG net/udpgso_bench.sh add UDP GSO audit tests net/udpgso_bench.sh test fails on error tools/testing/selftests/net/udpgso_bench.sh | 52 ++++- tools/testing/selftests/net/udpgso_bench_tx.c | 291 ++++++++++++++++++++++++-- 2 files changed, 327 insertions(+), 16 deletions(-) -- 2.11.0

6 years, 4 months

3
5
0 0

stable-rc: ptrace: peeksiginfo failed on 4.19, 4.14, 4.9 and 4.4

by Naresh Kamboju

selftests: ptrace: peeksiginfo failed on x86_64, i386, arm64 and arm. FAILED on stable rc branches 4.19, 4.14, 4.9 and 4.4. PASS on mainline, next and 5.1 stable rc branch. Test output: ------------------ cd /opt/kselftests/mainline/ptrace ./peeksiginfo Error (peeksiginfo.c:143): Only 0 signals were read The git bisect show that below commit caused this test to fail. git bisect bad 5b6b0eac235ef1f915f24eda6d501a754022cbf0 is the first bad commit commit 5b6b0eac235ef1f915f24eda6d501a754022cbf0 Author: Eric W. Biederman <ebiederm(a)xmission.com> Date: Tue May 28 18:46:37 2019 -0500 signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO commit f6e2aa91a46d2bc79fce9b93a988dbe7655c90c0 upstream. Recently syzbot in conjunction with KMSAN reported that ptrace_peek_siginfo can copy an uninitialized siginfo to userspace. Inspecting ptrace_peek_siginfo confirms this. The problem is that off when initialized from args.off can be initialized to a negaive value. At which point the "if (off >= 0)" test to see if off became negative fails because off started off negative. Prevent the core problem by adding a variable found that is only true if a siginfo is found and copied to a temporary in preparation for being copied to userspace. Prevent args.off from being truncated when being assigned to off by testing that off is <= the maximum possible value of off. Convert off to an unsigned long so that we should not have to truncate args.off, we have well defined overflow behavior so if we add another check we won't risk fighting undefined compiler behavior, and so that we have a type whose maximum value is easy to test for. Cc: Andrei Vagin <avagin(a)gmail.com> Cc: stable(a)vger.kernel.org Reported-by: syzbot+0d602a1b0d8c95bdf299(a)syzkaller.appspotmail.com Fixes: 84c751bd4aeb ("ptrace: add ability to retrieve signals without removing from a queue (v4)") Signed-off-by: "Eric W. Biederman" <ebiederm(a)xmission.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> :040000 040000 ff9f3109f210274d0b87851d226c35e7305ce44a b36de2c855fe2a0b332f145f0966dc1a0304d4bd M kernel Test case link, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/too… Test output log link, https://lkft.validation.linaro.org/scheduler/job/777223#L1084 Test results comparison on different branches, https://qa-reports.linaro.org/_/comparetest/?project=22&project=6&project=5… Best regards Naresh Kamboju

6 years, 4 months

4
3
0 0

BUG: kernel NULL pointer dereference, address: 00000000

by Naresh Kamboju

While running selftest bpf: test_sockmap the kernel BUG found on i386 and arm kernel running on Linux version 5.2.0-rc5-next-20190617 steps to reproduce, cd /opt/kselftests/default-in-kernel/bpf ./test_sockmap [ 33.666964] BUG: kernel NULL pointer dereference, address: 00000000 [ 33.673246] #PF: supervisor read access in kernel mode [ 33.678392] #PF: error_code(0x0000) - not-present page [ 33.683539] *pde = 00000000 [ 33.686435] Oops: 0000 [#1] SMP [ 33.689593] CPU: 1 PID: 619 Comm: test_sockmap Not tainted 5.2.0-rc5-next-20190617 #1 [ 33.697431] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 33.704914] EIP: memcpy+0x1d/0x30 [ 33.708240] Code: 59 58 eb 85 90 90 90 90 90 90 90 90 90 3e 8d 74 26 00 55 89 e5 57 56 89 c7 53 89 d6 89 cb c1 e9 02 f3 a5 89 d9 83 e1 03 74 02 <f3> a4 5b 5e 5f 5d c3 8d b6 00 00 00 00 8d bf 00 00 00 00 3e 8d 74 [ 33.726985] EAX: f1faf000 EBX: 00000001 ECX: 00000001 EDX: 00000000 [ 33.733249] ESI: 00000000 EDI: f1faf000 EBP: f2e6d99c ESP: f2e6d990 [ 33.739505] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00010202 [ 33.746283] CR0: 80050033 CR2: 00000000 CR3: 31fae000 CR4: 003406d0 [ 33.752542] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 [ 33.758807] DR6: fffe0ff0 DR7: 00000400 [ 33.762638] Call Trace: [ 33.765084] bpf_msg_push_data+0x635/0x660 [ 33.769183] ? _raw_spin_unlock_irqrestore+0x2f/0x50 [ 33.774150] ? lockdep_hardirqs_on+0xec/0x1a0 [ 33.778512] ___bpf_prog_run+0xa0d/0x15a0 [ 33.782523] ? __lock_acquire+0x1fe/0x1ec0 [ 33.786621] __bpf_prog_run32+0x4b/0x70 [ 33.790462] ? sk_psock_msg_verdict+0x5/0x290 [ 33.794819] sk_psock_msg_verdict+0xad/0x290 [ 33.799091] ? sk_psock_msg_verdict+0xad/0x290 [ 33.803537] ? lockdep_hardirqs_on+0xec/0x1a0 [ 33.807887] ? __local_bh_enable_ip+0x78/0xf0 [ 33.812238] tcp_bpf_send_verdict+0x29c/0x3b0 [ 33.816590] tcp_bpf_sendpage+0x233/0x3d0 [ 33.820603] ? __lock_acquire+0x1fe/0x1ec0 [ 33.824703] ? __lock_acquire+0x1fe/0x1ec0 [ 33.828801] ? find_held_lock+0x27/0xa0 [ 33.832640] ? lock_release+0x92/0x290 [ 33.836392] ? find_get_entry+0x136/0x300 [ 33.840397] ? touch_atime+0x34/0xd0 [ 33.843978] ? copy_page_to_iter+0x245/0x400 [ 33.848248] ? lockdep_hardirqs_on+0xec/0x1a0 [ 33.852600] ? tcp_bpf_send_verdict+0x3b0/0x3b0 [ 33.857132] inet_sendpage+0x53/0x1f0 [ 33.860789] ? inet_recvmsg+0x1e0/0x1e0 [ 33.864620] ? kernel_sendpage+0x40/0x40 [ 33.868536] kernel_sendpage+0x1e/0x40 [ 33.872282] sock_sendpage+0x24/0x30 [ 33.875861] pipe_to_sendpage+0x59/0xa0 [ 33.879692] ? direct_splice_actor+0x40/0x40 [ 33.883962] __splice_from_pipe+0xde/0x1c0 [ 33.888055] ? direct_splice_actor+0x40/0x40 [ 33.892342] ? direct_splice_actor+0x40/0x40 [ 33.896635] splice_from_pipe+0x59/0x80 [ 33.900466] ? splice_from_pipe+0x80/0x80 [ 33.904469] ? generic_splice_sendpage+0x20/0x20 [ 33.909080] generic_splice_sendpage+0x18/0x20 [ 33.913516] ? direct_splice_actor+0x40/0x40 [ 33.917782] direct_splice_actor+0x2d/0x40 [ 33.921880] splice_direct_to_actor+0x127/0x240 [ 33.926403] ? generic_pipe_buf_nosteal+0x10/0x10 [ 33.931105] do_splice_direct+0x7e/0xc0 [ 33.934944] do_sendfile+0x20d/0x3e0 [ 33.938522] sys_sendfile+0xac/0xd0 [ 33.942015] do_fast_syscall_32+0x8e/0x320 [ 33.946114] entry_SYSENTER_32+0x70/0xc8 [ 33.950039] EIP: 0xb7fa67a1 [ 33.952830] Code: 8b 98 60 cd ff ff 85 d2 89 c8 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 1c 24 c3 8b 3c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 33.971567] EAX: ffffffda EBX: 00000018 ECX: 0000001c EDX: 00000000 [ 33.977823] ESI: 00000001 EDI: 00000018 EBP: 00000001 ESP: bfcaa6d4 [ 33.984083] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000206 [ 33.990869] Modules linked in: x86_pkg_temp_thermal fuse [ 33.996181] CR2: 0000000000000000 [ 33.999500] ---[ end trace 0ef7a1496c65bde8 ]--- - Naresh

6 years, 4 months

1
0
0 0

[PATCH v4 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

by Brendan Higgins

## TLDR A quick follow up to yesterday's revision. I got some feedback that I wanted to incorporate before anyone else read the update. For this reason, I will leave a TLDR of the biggest changes since v2. Biggest things to look out for (since v2): - KUnit core now outputs results in TAP14. - Heavily reworked tools/testing/kunit/kunit.py - Changed how parsing works. - Added testing. - Greg, Logan, you might want to re-review this. - Added documentation on how to use KUnit on non-UML kernels. You can see the docs rendered here[1]. There is still some discussion going on on the [PATCH v2 00/17] thread, but I wanted to get some of these updates out before they got too stale (and too difficult for me to keep track of). I hope no one minds. ## Background This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM (however, KUnit still allows you to run tests on test machines or in VMs if you want) and does not require tests to be written in userspace running on a host kernel. Additionally, KUnit is fast: From invocation to completion KUnit can run several dozen tests in under a second. Currently, the entire KUnit test suite for KUnit runs in under a second from the initial invocation (build time excluded). KUnit is heavily inspired by JUnit, Python's unittest.mock, and Googletest/Googlemock for C++. KUnit provides facilities for defining unit test cases, grouping related test cases into test suites, providing common infrastructure for running tests, mocking, spying, and much more. ## What's so special about unit testing? A unit test is supposed to test a single unit of code in isolation, hence the name. There should be no dependencies outside the control of the test; this means no external dependencies, which makes tests orders of magnitudes faster. Likewise, since there are no external dependencies, there are no hoops to jump through to run the tests. Additionally, this makes unit tests deterministic: a failing unit test always indicates a problem. Finally, because unit tests necessarily have finer granularity, they are able to test all code paths easily solving the classic problem of difficulty in exercising error handling code. ## Is KUnit trying to replace other testing frameworks for the kernel? No. Most existing tests for the Linux kernel are end-to-end tests, which have their place. A well tested system has lots of unit tests, a reasonable number of integration tests, and some end-to-end tests. KUnit is just trying to address the unit test space which is currently not being addressed. ## More information on KUnit There is a bunch of documentation near the end of this patch set that describes how to use KUnit and best practices for writing unit tests. For convenience I am hosting the compiled docs here[2]. Additionally for convenience, I have applied these patches to a branch[3]. The repo may be cloned with: git clone https://kunit.googlesource.com/linux This patchset is on the kunit/rfc/v5.1/v4 branch. ## Changes Since Last Version As I mentioned above, there are a significant number of updates since v2: - Converted KUnit core to print test results in TAP14 format as suggested by Greg and Frank. - Heavily reworked tools/testing/kunit/kunit.py - Changed how parsing works. - Added testing. - Added documentation on how to use KUnit on non-UML kernels. You can see the docs rendered here[1]. - Added a new set of EXPECTs and ASSERTs for pointer comparison. - Removed more function indirection as suggested by Logan. - Added a new patch that adds `kunit_try_catch_throw` to objtool's noreturn list. - Fixed a number of minorish issues pointed out by Shuah, Masahiro, and kbuild bot. Nevertheless, there are only a couple of minor updates since v3: - Added more context to the changelog on the objtool patch, as per Peter's request. - Moved all KUnit documentation under the Documentation/dev-tools/ directory as per Jonathan's suggestion. [1] https://google.github.io/kunit-docs/third_party/kernel/docs/usage.html#kuni… [2] https://google.github.io/kunit-docs/third_party/kernel/docs/ [3] https://kunit.googlesource.com/linux/+/kunit/rfc/v5.1/v4 -- 2.21.0.1020.gf2820cf01a-goog

6 years, 4 months

3
35
0 0

[PATCH] selftests/bpf: signedness bug in enable_all_controllers()

by Dan Carpenter

The "len" variable needs to be signed for the error handling to work properly. Fixes: 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- tools/testing/selftests/bpf/cgroup_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c index 0d89f0396be4..e95c33e333a4 100644 --- a/tools/testing/selftests/bpf/cgroup_helpers.c +++ b/tools/testing/selftests/bpf/cgroup_helpers.c @@ -47,7 +47,7 @@ int enable_all_controllers(char *cgroup_path) char buf[PATH_MAX]; char *c, *c2; int fd, cfd; - size_t len; + ssize_t len; snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path); fd = open(path, O_RDONLY); -- 2.20.1

6 years, 4 months

3
2
0 0

[PATCH AUTOSEL 4.19 20/39] selftests: vm: install test_vmalloc.sh for run_vmtests

by Sasha Levin

From: Naresh Kamboju <naresh.kamboju(a)linaro.org> [ Upstream commit bc2cce3f2ebcae02aa4bb29e3436bf75ee674c32 ] Add test_vmalloc.sh to TEST_FILES to make sure it gets installed for run_vmtests. Fixed below error: ./run_vmtests: line 217: ./test_vmalloc.sh: No such file or directory Tested with: make TARGETS=vm install INSTALL_PATH=$PWD/x Signed-off-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/vm/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index dc68340a6a96..2cf3dc49bd03 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -24,6 +24,8 @@ TEST_GEN_FILES += virtual_address_range TEST_PROGS := run_vmtests +TEST_FILES := test_vmalloc.sh + KSFT_KHDR_INSTALL := 1 include ../lib.mk -- 2.20.1

6 years, 4 months

1
0
0 0

[PATCH AUTOSEL 4.19 19/39] kselftest/cgroup: fix incorrect test_core skip

by Sasha Levin

From: Alex Shi <alex.shi(a)linux.alibaba.com> [ Upstream commit f97f3f8839eb9de5843066d80819884f7722c8c5 ] The test_core will skip the test_cgcore_no_internal_process_constraint_on_threads test case if the 'cpu' controller missing in root's subtree_control. In fact we need to set the 'cpu' in subtree_control, to make the testing meaningful. ./test_core ... ok 4 # skip test_cgcore_no_internal_process_constraint_on_threads ... Signed-off-by: Alex Shi <alex.shi(a)linux.alibaba.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Tejun Heo <tj(a)kernel.org> Cc: Roman Gushchin <guro(a)fb.com> Cc: Claudio Zumbo <claudioz(a)fb.com> Cc: Claudio <claudiozumbo(a)gmail.com> Cc: linux-kselftest(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Reviewed-by: Roman Gushchin <guro(a)fb.com> Acked-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/cgroup/test_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/test_core.c b/tools/testing/selftests/cgroup/test_core.c index d78f1c5366d3..79053a4f4783 100644 --- a/tools/testing/selftests/cgroup/test_core.c +++ b/tools/testing/selftests/cgroup/test_core.c @@ -198,7 +198,7 @@ static int test_cgcore_no_internal_process_constraint_on_threads(const char *roo char *parent = NULL, *child = NULL; if (cg_read_strstr(root, "cgroup.controllers", "cpu") || - cg_read_strstr(root, "cgroup.subtree_control", "cpu")) { + cg_write(root, "cgroup.subtree_control", "+cpu")) { ret = KSFT_SKIP; goto cleanup; } -- 2.20.1

6 years, 4 months

1
0
0 0

[PATCH AUTOSEL 4.19 18/39] kselftest/cgroup: fix unexpected testing failure on test_core

by Sasha Levin

From: Alex Shi <alex.shi(a)linux.alibaba.com> [ Upstream commit 00e38a5d753d7788852f81703db804a60a84c26e ] The cgroup testing relys on the root cgroup's subtree_control setting, If the 'memory' controller isn't set, some test cases will be failed as following: $sudo ./test_core not ok 1 test_cgcore_internal_process_constraint ok 2 test_cgcore_top_down_constraint_enable not ok 3 test_cgcore_top_down_constraint_disable ... To correct this unexpected failure, this patch write the 'memory' to subtree_control of root to get a right result. Signed-off-by: Alex Shi <alex.shi(a)linux.alibaba.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Tejun Heo <tj(a)kernel.org> Cc: Roman Gushchin <guro(a)fb.com> Cc: Claudio Zumbo <claudioz(a)fb.com> Cc: Claudio <claudiozumbo(a)gmail.com> Cc: linux-kselftest(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Reviewed-by: Roman Gushchin <guro(a)fb.com> Acked-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/cgroup/test_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/cgroup/test_core.c b/tools/testing/selftests/cgroup/test_core.c index be59f9c34ea2..d78f1c5366d3 100644 --- a/tools/testing/selftests/cgroup/test_core.c +++ b/tools/testing/selftests/cgroup/test_core.c @@ -376,6 +376,11 @@ int main(int argc, char *argv[]) if (cg_find_unified_root(root, sizeof(root))) ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (cg_read_strstr(root, "cgroup.subtree_control", "memory")) + if (cg_write(root, "cgroup.subtree_control", "+memory")) + ksft_exit_skip("Failed to set memory controller\n"); + for (i = 0; i < ARRAY_SIZE(tests); i++) { switch (tests[i].fn(root)) { case KSFT_PASS: -- 2.20.1

6 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror