- Linux-kselftest-mirror - lists.linaro.org

[PATCH AUTOSEL 4.19 26/36] selftests: fib_rule_tests: fix local IPv4 address typo

by Sasha Levin

From: Hangbin Liu <liuhangbin(a)gmail.com> [ Upstream commit fc82d93e57e3d41f79eff19031588b262fc3d0b6 ] The IPv4 testing address are all in 192.51.100.0 subnet. It doesn't make sense to set a 198.51.100.1 local address. Should be a typo. Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests") Signed-off-by: Hangbin Liu <liuhangbin(a)gmail.com> Reviewed-by: David Ahern <dsahern(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/net/fib_rule_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index d84193bdc307..dbd90ca73e44 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -55,7 +55,7 @@ setup() $IP link add dummy0 type dummy $IP link set dev dummy0 up - $IP address add 198.51.100.1/24 dev dummy0 + $IP address add 192.51.100.1/24 dev dummy0 $IP -6 address add 2001:db8:1::1/64 dev dummy0 set +e -- 2.20.1

5 years, 10 months

1
0
0 0

[PATCH AUTOSEL 5.1 40/60] selftests: fib_rule_tests: fix local IPv4 address typo

by Sasha Levin

From: Hangbin Liu <liuhangbin(a)gmail.com> [ Upstream commit fc82d93e57e3d41f79eff19031588b262fc3d0b6 ] The IPv4 testing address are all in 192.51.100.0 subnet. It doesn't make sense to set a 198.51.100.1 local address. Should be a typo. Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests") Signed-off-by: Hangbin Liu <liuhangbin(a)gmail.com> Reviewed-by: David Ahern <dsahern(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/net/fib_rule_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 4b7e107865bf..1ba069967fa2 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -55,7 +55,7 @@ setup() $IP link add dummy0 type dummy $IP link set dev dummy0 up - $IP address add 198.51.100.1/24 dev dummy0 + $IP address add 192.51.100.1/24 dev dummy0 $IP -6 address add 2001:db8:1::1/64 dev dummy0 set +e -- 2.20.1

5 years, 10 months

1
0
0 0

[PATCH AUTOSEL 5.1 27/60] selftests/bpf: fix bpf_get_current_task

by Sasha Levin

From: Alexei Starovoitov <ast(a)kernel.org> [ Upstream commit 7ed4b4e60bb1dd3df7a45dfbde3a96efce9df7eb ] Fix bpf_get_current_task() declaration. Signed-off-by: Alexei Starovoitov <ast(a)kernel.org> Acked-by: Andrii Nakryiko <andriin(a)fb.com> Signed-off-by: Daniel Borkmann <daniel(a)iogearbox.net> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/bpf/bpf_helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h index c81fc350f7ad..a43a52cdd3f0 100644 --- a/tools/testing/selftests/bpf/bpf_helpers.h +++ b/tools/testing/selftests/bpf/bpf_helpers.h @@ -246,7 +246,7 @@ static int (*bpf_skb_change_type)(void *ctx, __u32 type) = (void *) BPF_FUNC_skb_change_type; static unsigned int (*bpf_get_hash_recalc)(void *ctx) = (void *) BPF_FUNC_get_hash_recalc; -static unsigned long long (*bpf_get_current_task)(void *ctx) = +static unsigned long long (*bpf_get_current_task)(void) = (void *) BPF_FUNC_get_current_task; static int (*bpf_skb_change_tail)(void *ctx, __u32 len, __u64 flags) = (void *) BPF_FUNC_skb_change_tail; -- 2.20.1

5 years, 10 months

1
0
0 0

[PATCH v1 0/9] KVM selftests for s390x

by Thomas Huth

This patch series enables the KVM selftests for s390x. As a first test, the sync_regs from x86 has been adapted to s390x, and after a fix for KVM_CAP_MAX_VCPU_ID on s390x, the kvm_create_max_vcpus is now enabled here, too. Please note that the ucall() interface is not used yet - since s390x neither has PIO nor MMIO, this needs some more work first before it becomes usable (we likely should use a DIAG hypercall here, which is what the sync_reg test is currently using, too... I started working on that topic, but did not finish that work yet, so I decided to not include it yet). RFC -> v1: - Rebase, needed to add the first patch for vcpu_nested_state_get/set - Added patch to introduce VM_MODE_DEFAULT macro - Improved/cleaned up the code in processor.c - Added patch to fix KVM_CAP_MAX_VCPU_ID on s390x - Added patch to enable the kvm_create_max_vcpus on s390x and aarch64 Andrew Jones (1): kvm: selftests: aarch64: fix default vm mode Thomas Huth (8): KVM: selftests: Wrap vcpu_nested_state_get/set functions with x86 guard KVM: selftests: Guard struct kvm_vcpu_events with __KVM_HAVE_VCPU_EVENTS KVM: selftests: Introduce a VM_MODE_DEFAULT macro for the default bits KVM: selftests: Align memory region addresses to 1M on s390x KVM: selftests: Add processor code for s390x KVM: selftests: Add the sync_regs test for s390x KVM: s390: Do not report unusabled IDs via KVM_CAP_MAX_VCPU_ID KVM: selftests: Move kvm_create_max_vcpus test to generic code MAINTAINERS | 2 + arch/mips/kvm/mips.c | 3 + arch/powerpc/kvm/powerpc.c | 3 + arch/s390/kvm/kvm-s390.c | 1 + arch/x86/kvm/x86.c | 3 + tools/testing/selftests/kvm/Makefile | 7 +- .../testing/selftests/kvm/include/kvm_util.h | 10 + .../selftests/kvm/include/s390x/processor.h | 22 ++ .../kvm/{x86_64 => }/kvm_create_max_vcpus.c | 3 +- .../selftests/kvm/lib/aarch64/processor.c | 2 +- tools/testing/selftests/kvm/lib/kvm_util.c | 25 +- .../selftests/kvm/lib/s390x/processor.c | 286 ++++++++++++++++++ .../selftests/kvm/lib/x86_64/processor.c | 2 +- .../selftests/kvm/s390x/sync_regs_test.c | 151 +++++++++ virt/kvm/arm/arm.c | 3 + virt/kvm/kvm_main.c | 2 - 16 files changed, 514 insertions(+), 11 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/s390x/processor.h rename tools/testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c (93%) create mode 100644 tools/testing/selftests/kvm/lib/s390x/processor.c create mode 100644 tools/testing/selftests/kvm/s390x/sync_regs_test.c -- 2.21.0

5 years, 10 months

6
35
0 0

[PATCH] kbuild: teach kselftest-merge to find nested config files

by Dan Rue

Current implementation of kselftest-merge only finds config files that are one level deep using `$(srctree)/tools/testing/selftests/*/config`. Often, config files are added in nested directories, and do not get picked up by kselftest-merge. Use `find` to catch all config files under `$(srctree)/tools/testing/selftests` instead. Signed-off-by: Dan Rue <dan.rue(a)linaro.org> --- Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index a45f84a7e811..e99e7f9484af 100644 --- a/Makefile +++ b/Makefile @@ -1228,9 +1228,8 @@ kselftest-clean: PHONY += kselftest-merge kselftest-merge: $(if $(wildcard $(objtree)/.config),, $(error No .config exists, config your kernel first!)) - $(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \ - -m $(objtree)/.config \ - $(srctree)/tools/testing/selftests/*/config + $(Q)find $(srctree)/tools/testing/selftests -name config | \ + xargs $(srctree)/scripts/kconfig/merge_config.sh -m $(objtree)/.config +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig # --------------------------------------------------------------------------- -- 2.21.0

5 years, 10 months

3
4
0 0

bpf: test_xdp_vlan.sh: Kernel panic: Unable to handle kernel paging request at virtual address 000080096d61a000

by Naresh Kamboju

Kernel panic while running bpf: test_xdp_vlan.sh test case on arm64 Juno hardware Linux version 5.2.0-rc3-next-20190604 bpf: test_xdp_vlan.sh # --- 100.64.41.2 ping statistics --- 100.64.41.2: ping_statistics # # 3 packets transmitted, 3 received, 0% packet loss, time 2049ms packets: transmitted,_3 # # rtt min/avg/max/mdev = 0.172/0.193/0.205/0.022 ms min/avg/max/mdev: =_0.172/0.193/0.205/0.022 # # PING 100.64.41.1 (100.64.41.1) 56(84) bytes of data. 100.64.41.1: (100.64.41.1)_56(84) # # 64 bytes from 100.64.41.1 icmp_seq=1 ttl=64 time=0.146 ms bytes: from_100.64.41.1 # # 64 bytes from 100.64.41.1 icmp_seq=2 ttl=64 time=0.182 ms bytes: from_100.64.41.1 # [ 492.263541] ip6_tunnel: gre6_dev xmit: Local address not yet configured! [ 788.768658] ip6_tunnel: gre6_dev xmit: Local address not yet configured! [ 940.373938] Unable to handle kernel paging request at virtual address 000080096d61a000 [ 940.381873] Mem abort info: [ 940.384717] ESR = 0x96000004 [ 940.387797] Exception class = DABT (current EL), IL = 32 bits [ 940.393715] SET = 0, FnV = 0 [ 940.396788] EA = 0, S1PTW = 0 [ 940.399949] Data abort info: [ 940.402805] ISV = 0, ISS = 0x00000004 [ 940.406647] CM = 0, WnR = 0 [ 940.409639] user pgtable: 4k pages, 48-bit VAs, pgdp=000000093bee0000 [ 940.416065] [000080096d61a000] pgd=0000000000000000 [ 940.421079] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 940.426598] Modules linked in: sit act_gact cls_flower cls_bpf sch_ingress xt_tcpudp iptable_filter ip_tables x_tables tun algif_hash af_alg tda998x drm_kms_helper drm crct10dif_ce drm_panel_orientation_quirks fuse [last unloaded: test_bpf] [ 940.447715] CPU: 2 PID: 8748 Comm: ping Not tainted 5.2.0-rc3-next-20190604 #1 [ 940.454865] Hardware name: ARM Juno development board (r2) (DT) [ 940.460727] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 940.465480] pc : ip6_pol_route+0x1f4/0x738 [ 940.469537] lr : ip6_pol_route+0x1d8/0x738 [ 940.473590] sp : ffff000013fb3010 [ 940.476870] x29: ffff000013fb3010 x28: ffff000011be3000 [ 940.482132] x27: ffff80096f228a00 x26: ffff80096f364000 [ 940.487393] x25: ffff000010da3500 x24: 000000000000004e [ 940.492654] x23: ffff00001198e000 x22: ffff000013fb3240 [ 940.497915] x21: ffff00001195f000 x20: ffff80096bf95a00 [ 940.503175] x19: ffff000013fb3268 x18: 0000000000000000 [ 940.508435] x17: 0000000000000001 x16: 0000000000000000 [ 940.513696] x15: 0000000000000000 x14: 1312111000000000 [ 940.518956] x13: 0002ccaf00000000 x12: 5cf61adb01002c22 [ 940.524216] x11: 0000000000000002 x10: 0000000000000003 [ 940.529477] x9 : 0000000000000000 x8 : ffff00001195f848 [ 940.534738] x7 : ffff000013fb2ffb x6 : 0000000000000000 [ 940.539998] x5 : ffff80096f364000 x4 : 0000000000000001 [ 940.545258] x3 : 0000000000000004 x2 : 000080096d61a000 [ 940.550519] x1 : ffff80092e761700 x0 : 0000000000000000 [ 940.555780] Call trace: [ 940.558202] ip6_pol_route+0x1f4/0x738 [ 940.561914] ip6_pol_route_input+0x4c/0x60 [ 940.565971] fib6_rule_lookup+0xc8/0x170 [ 940.569855] ip6_route_input_lookup+0x70/0x88 [ 940.574169] ip6_route_input+0xe4/0x238 [ 940.577969] ip6_rcv_finish_core.isra.0+0x48/0x168 [ 940.582713] ip6_rcv_finish+0x68/0xc0 [ 940.586339] ipv6_rcv+0x70/0x228 [ 940.589536] __netif_receive_skb_one_core+0x68/0x90 [ 940.594366] __netif_receive_skb+0x28/0x80 [ 940.598422] process_backlog+0xe4/0x240 [ 940.602220] net_rx_action+0x120/0x4a8 [ 940.605933] __do_softirq+0x11c/0x580 [ 940.609559] do_softirq.part.3+0x94/0x98 [ 940.613442] __local_bh_enable_ip+0x12c/0x138 [ 940.617756] ip6_finish_output2+0x220/0xb98 [ 940.621898] __ip6_finish_output+0x1e8/0x2a8 [ 940.626126] ip6_finish_output+0x38/0xd0 [ 940.630010] ip6_output+0x80/0x350 [ 940.633378] bpf_lwt_xmit_reroute+0x2a8/0x4b0 [ 940.637692] bpf_xmit+0x120/0x178 [ 940.640972] lwtunnel_xmit+0xd0/0x210 [ 940.644600] ip_finish_output2+0x488/0xa80 [ 940.648654] __ip_finish_output+0x204/0x318 [ 940.652795] ip_finish_output+0x38/0xd0 [ 940.656592] ip_output+0x108/0x2f8 [ 940.659959] ip_local_out+0x5c/0x98 [ 940.663411] ip_send_skb+0x2c/0xb8 [ 940.666778] ip_push_pending_frames+0x44/0x50 [ 940.671093] raw_sendmsg+0xa7c/0xe20 [ 940.674633] inet_sendmsg+0x4c/0x238 [ 940.678173] sock_sendmsg+0x34/0x50 [ 940.681627] __sys_sendto+0x120/0x150 [ 940.685252] __arm64_sys_sendto+0x30/0x40 [ 940.689223] el0_svc_common.constprop.0+0x7c/0x180 [ 940.693967] el0_svc_handler+0x34/0x90 [ 940.697678] el0_svc+0x8/0xc [ 940.700531] Code: b9001020 f9403fa0 d538d082 f9402400 (f8626813) [ 940.706579] ---[ end trace 8a07ef53f23b6533 ]--- [ 940.711150] Kernel panic - not syncing: Fatal exception in interrupt [ 940.717449] SMP: stopping secondary CPUs [ 940.721536] Kernel Offset: disabled [ 940.724989] CPU features: 0x0002,24006004 [ 940.728957] Memory Limit: none [ 940.731998] ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]--- [1] https://lkft.validation.linaro.org/scheduler/job/760547#L23242 Best regards Naresh Kamboju

5 years, 10 months

1
0
0 0

BUG: kernel NULL pointer dereference, address: 00000000: memcpy+0x1d/0x30

by Naresh Kamboju

While running selftest bpf: test_maps the kernel BUG found on i386 kernel running on x86_64 machine Linux version 5.2.0-rc3-next-20190604 Full test log can be found in the below link [1] # helper_fill_hashmap(261)FAILfailed to create hashmap err Cannot allocate memory, flags 0x0 to: create_hashmap # # Fork 1024 tasks to 'test_update_delete' 1024: tasks_to # # Fork 1024 tasks to 'test_update_delete' 1024: tasks_to # # Fork 100 tasks to 'test_hashmap' 100: tasks_to # # Fork 100 tasks to 'test_hashmap_percpu' 100: tasks_to # # Fork 100 tasks to 'test_hashmap_sizes' [ 93.249753] BUG: kernel NULL pointer dereference, address: 00000000 [ 93.256586] #PF: supervisor read access in kernel mode [ 93.261714] #PF: error_code(0x0000) - not-present page [ 93.266846] *pde = 00000000 [ 93.269722] Oops: 0000 [#1] SMP [ 93.272859] CPU: 0 PID: 4354 Comm: test_sockmap Not tainted 5.2.0-rc3-next-20190604 #1 [ 93.280763] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 93.288235] EIP: memcpy+0x1d/0x30 [ 93.291547] Code: 59 58 eb 85 90 90 90 90 90 90 90 90 90 3e 8d 74 26 00 55 89 e5 57 56 89 c7 53 89 d6 89 cb c1 e9 02 f3 a5 89 d9 83 e1 03 74 02 <f3> a4 5b 5e 5f 5d c3 8d b6 00 00 00 00 8d bf 00 00 00 00 3e 8d 74 [ 93.310291] EAX: e2ca9000 EBX: 00000001 ECX: 00000001 EDX: 00000000 [ 93.316548] ESI: 00000000 EDI: e2ca9000 EBP: e3d8799c ESP: e3d87990 [ 93.322806] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00010202 [ 93.329582] CR0: 80050033 CR2: 00000000 CR3: 20d21000 CR4: 003406d0 [ 93.335841] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 [ 93.342097] DR6: fffe0ff0 DR7: 00000400 [ 93.345929] Call Trace: [ 93.348391] bpf_msg_push_data+0x635/0x660 [ 93.352492] ___bpf_prog_run+0xa0d/0x15a0 [ 93.356529] ? __lock_acquire+0x1fe/0x1360 [ 93.360626] __bpf_prog_run32+0x4b/0x70 [ 93.364461] ? sk_psock_msg_verdict+0x5/0x290 [ 93.368842] sk_psock_msg_verdict+0xad/0x290 [ 93.373105] ? sk_psock_msg_verdict+0xad/0x290 [ 93.377543] ? lockdep_hardirqs_on+0xec/0x1a0 [ 93.381896] ? __local_bh_enable_ip+0x78/0xf0 [ 93.386255] tcp_bpf_send_verdict+0x29c/0x3b0 [ 93.390615] tcp_bpf_sendpage+0x233/0x3d0 [ 93.394629] ? __lock_acquire+0x1fe/0x1360 [ 93.398754] ? __lock_acquire+0x1fe/0x1360 [ 93.402850] ? lock_release+0x8b/0x280 [ 93.406593] ? find_get_entry+0x136/0x300 [ 93.410599] ? touch_atime+0x34/0xd0 [ 93.414177] ? copy_page_to_iter+0x245/0x400 [ 93.418441] ? lockdep_hardirqs_on+0xec/0x1a0 [ 93.422793] ? tcp_bpf_send_verdict+0x3b0/0x3b0 [ 93.427325] inet_sendpage+0x53/0x1f0 [ 93.430981] ? inet_recvmsg+0x1e0/0x1e0 [ 93.434812] ? kernel_sendpage+0x40/0x40 [ 93.438728] kernel_sendpage+0x1e/0x40 [ 93.442474] sock_sendpage+0x24/0x30 [ 93.446054] pipe_to_sendpage+0x59/0xa0 [ 93.449894] ? direct_splice_actor+0x40/0x40 [ 93.454166] __splice_from_pipe+0xde/0x1c0 [ 93.458264] ? direct_splice_actor+0x40/0x40 [ 93.462535] ? direct_splice_actor+0x40/0x40 [ 93.466801] splice_from_pipe+0x59/0x80 [ 93.470641] ? splice_from_pipe+0x80/0x80 [ 93.474652] ? generic_splice_sendpage+0x20/0x20 [ 93.479262] generic_splice_sendpage+0x18/0x20 [ 93.483701] ? direct_splice_actor+0x40/0x40 [ 93.487971] direct_splice_actor+0x2d/0x40 [ 93.492065] splice_direct_to_actor+0x127/0x240 [ 93.496597] ? generic_pipe_buf_nosteal+0x10/0x10 [ 93.501302] do_splice_direct+0x7e/0xc0 [ 93.505134] do_sendfile+0x20d/0x3e0 [ 93.508739] sys_sendfile+0xac/0xd0 [ 93.512232] ? lock_release+0x8b/0x280 [ 93.515984] do_fast_syscall_32+0x8e/0x320 [ 93.520084] entry_SYSENTER_32+0x70/0xc8 [ 93.524009] EIP: 0xb7f9d7a1 [ 93.526807] Code: 8b 98 60 cd ff ff 85 d2 89 c8 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 1c 24 c3 8b 3c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 93.545542] EAX: ffffffda EBX: 0000001a ECX: 0000001e EDX: 00000000 [ 93.551799] ESI: 00000001 EDI: 0000001a EBP: 00000001 ESP: bfa67a64 [ 93.558057] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000206 [ 93.564836] Modules linked in: tun algif_hash af_alg x86_pkg_temp_thermal fuse [ 93.572082] CR2: 0000000000000000 [ 93.575411] ---[ end trace c106584042e12a8d ]--- [ 93.580046] EIP: memcpy+0x1d/0x30 [ 93.583355] Code: 59 58 eb 85 90 90 90 90 90 90 90 90 90 3e 8d 74 26 00 55 89 e5 57 56 89 c7 53 89 d6 89 cb c1 e9 02 f3 a5 89 d9 83 e1 03 74 02 <f3> a4 5b 5e 5f 5d c3 8d b6 00 00 00 00 8d bf 00 00 00 00 3e 8d 74 [ 93.602092] EAX: e2ca9000 EBX: 00000001 ECX: 00000001 EDX: 00000000 [ 93.608349] ESI: 00000000 EDI: e2ca9000 EBP: e3d8799c ESP: d967e49c [ 93.614607] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00010202 [ 93.621408] CR0: 80050033 CR2: 00000000 CR3: 20d21000 CR4: 003406d0 [ 93.627694] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 [ 93.633951] DR6: fffe0ff0 DR7: 00000400 [ 93.637783] BUG: sleeping function called from invalid context at /usr/src/kernel/include/linux/percpu-rwsem.h:34 [ 93.648035] in_atomic(): 1, irqs_disabled(): 1, pid: 4354, name: test_sockmap [ 93.655156] INFO: lockdep is turned off. [ 93.659074] irq event stamp: 1538 [ 93.662408] hardirqs last enabled at (1537): [<d902cadf>] _raw_spin_unlock_irqrestore+0x2f/0x50 [ 93.671200] hardirqs last disabled at (1538): [<d840182c>] trace_hardirqs_off_thunk+0xc/0x10 [ 93.679624] softirqs last enabled at (1532): [<d8d1b849>] lock_sock_nested+0x39/0x90 [ 93.687465] softirqs last disabled at (1530): [<d8d1b83f>] lock_sock_nested+0x2f/0x90 [ 93.695284] CPU: 0 PID: 4354 Comm: test_sockmap Tainted: G D 5.2.0-rc3-next-20190604 #1 [ 93.704573] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 93.712043] Call Trace: [ 93.714490] dump_stack+0x66/0x96 [ 93.717800] ___might_sleep+0x13e/0x230 [ 93.721629] __might_sleep+0x33/0x80 [ 93.725200] exit_signals+0x2a/0x200 [ 93.728771] do_exit+0x8e/0xbb0 [ 93.731910] ? do_fast_syscall_32+0x8e/0x320 [ 93.736182] rewind_stack_do_exit+0x11/0x13 [ 93.740356] EIP: 0xb7f9d7a1 [ 93.743150] Code: 8b 98 60 cd ff ff 85 d2 89 c8 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 1c 24 c3 8b 3c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 93.761887] EAX: ffffffda EBX: 0000001a ECX: 0000001e EDX: 00000000 [ 93.768142] ESI: 00000001 EDI: 0000001a EBP: 00000001 ESP: bfa67a64 [ 93.774406] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000206 100: tasks_to [ 93.781266] note: test_sockmap[4354] exited with preempt_count 2 # # Fork 100 tasks to 'test_hashmap_walk' 100: tasks_to # # helper_fill_hashmap(261)FAILfailed to create hashmap err Cannot allocate memory, flags 0x0 [1] https://lkft.validation.linaro.org/scheduler/job/760391#L13640 Best regards Naresh Kamboju

5 years, 10 months

1
0
0 0

bpf: test_btf : kernel Oops: 207 : PC is at memcpy+0xc0/0x330

by Naresh Kamboju

while running kernel selftest bpf: test_btf the following kernel oops detected on beaglebone x15 board. Linux version 5.2.0-rc3-next-20190604 Full test log link can be found below [1] bpf: test_btf_ # # BTF GET_INFO test[3] (Large bpf_btf_info) OK GET_INFO: test[3]_(Large # # BTF GET_INFO test[4] (BTF ID) OK GET_INFO: test[4]_(BTF # [ 341.144885] 8<--- cut here --- [ 341.148164] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 341.156443] pgd = b0902156 [ 341.159294] [00000000] *pgd=9655e003, *pmd=ff918003 [ 341.164229] Internal error: Oops: 207 [#1] SMP ARM [ 341.169052] Modules linked in: tun sha1_generic sha1_arm_neon sha1_arm algif_hash af_alg snd_soc_simple_card snd_soc_simple_card_utils snd_soc_core ac97_bus snd_pcm_dmaengine snd_pcm snd_timer snd soundcore fuse [ 341.187962] CPU: 0 PID: 6773 Comm: test_sockmap Not tainted 5.2.0-rc3-next-20190604 #1 [ 341.195923] Hardware name: Generic DRA74X (Flattened Device Tree) [ 341.202058] PC is at memcpy+0xc0/0x330 [ 341.205836] LR is at bpf_msg_push_data+0x70c/0x728 [ 341.210654] pc : [<c12da820>] lr : [<c10ea4a4>] psr: 800b0013 [ 341.216957] sp : e99ad6cc ip : 00000002 fp : e99ad83c [ 341.222212] r10: d1bdc000 r9 : 00000001 r8 : 00000000 [ 341.227467] r7 : cd1de000 r6 : 00000000 r5 : d1bdc000 r4 : 00000000 [ 341.234032] r3 : 00000000 r2 : 80000000 r1 : 00000000 r0 : cd1de000 [ 341.240597] Flags: Nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 341.247771] Control: 30c5387d Table: 91b19880 DAC: fffffffd [ 341.253553] Process test_sockmap (pid: 6773, stack limit = 0x3ad4028c) [ 341.260118] Stack: (0xe99ad6cc to 0xe99ae000) [ 341.264502] d6c0: cd1de000 00000000 c10ea4a4 00000000 00000000 [ 341.272725] d6e0: 00000000 00000000 00000000 00000000 00000000 00000000 ea2759a0 00000001 [ 341.280948] d700: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.289171] d720: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.297394] d740: 00000000 00000000 00000000 00000000 00000000 00000000 e99ad78c d03f0580 [ 341.305615] d760: 00000004 d03f0000 00000007 000003a9 00000000 00000000 00000000 00000000 [ 341.313836] d780: 00000000 00000000 00000000 00000000 d03f0000 c0581f6c 00000060 c1e09fd0 [ 341.322060] d7a0: e99ad85c e99ad7b0 c04c1d1c 00000000 c06c3638 c1dc19b8 e99ad7ec d03f0540 [ 341.330283] d7c0: 00000002 d03f0000 00000007 000003a9 00000001 d03f0560 d03f0000 e3444ce4 [ 341.338506] d7e0: 00000060 c1e09fd0 e99ad8a4 e99ad7f8 cbc66e00 e99ad8a8 c1419868 c059b69c [ 341.346730] d800: 00000000 00000000 e99ad824 e99ad818 c04e3b7c f006b240 e99ad8b8 c1419868 [ 341.354954] d820: c10e9d98 00000000 00000000 c0581ddc e99ad894 e99ad840 c0581f6c c10e9da4 [ 341.363175] d840: 00000000 00000000 00000000 00000000 00000000 00000000 f5388145 290412b8 [ 341.371399] d860: c2432908 00000000 f08d7937 c1e08488 f006b028 00000011 c11cd828 f006b000 [ 341.379620] d880: e99ad9e4 c1fc9e37 e99ad934 e99ad898 c0584910 c0581e48 00000000 00000000 [ 341.387841] d8a0: 00000005 00000004 00000003 00000002 00000001 00000000 cbc66ee8 00000000 [ 341.396063] d8c0: d1bdc000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.404286] d8e0: 00000000 00000000 d1bdc000 00000000 cbc66ee0 00000000 00000007 00000006 [ 341.412509] d900: 00000010 c1fc9e37 e99ad8b8 00000000 cf380840 c10fdef4 c11cd828 9fdbe7c7 [ 341.420732] d920: d1bdc000 d1bdc000 e99ad984 e99ad938 c10fdf18 c05848d0 00000000 00000000 [ 341.428954] d940: c10fde14 c0459978 e99ad97c e99ad958 c056165c e7bdd400 000001ff d1bdc000 [ 341.437178] d960: e7bdd400 00000011 cf380840 00000000 e99ad9e4 c1fc9e37 e99ad9cc e99ad988 [ 341.445407] d980: c11cd828 c10fde20 c11cda3c 00000000 00000000 e99ad9a0 00000000 00000000 [ 341.453631] d9a0: 00000001 e7bdd400 cf380840 eb6d1030 c1e08488 00000000 00000003 c1fc9e37 [ 341.461855] d9c0: e99adcac e99ad9d0 c11cdb60 c11cd518 00000000 00000000 c11cd90c e8577024 [ 341.470078] d9e0: 00000020 00000001 00000000 00000000 00000001 00000001 00000000 00000001 [ 341.478300] da00: 00000000 00000000 00000000 00000000 eb6d1030 00000000 00000001 00000000 [ 341.486522] da20: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.494742] da40: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.502965] da60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.511184] da80: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 341.519406] daa0: 00000000 00000000 00000000 00000000 00000000 00000087 00000001 d03f0500 [ 341.527628] dac0: d03f0000 c1e47f04 00000000 c1e09fd0 e99adb8c e99adae0 c04c1d1c c04c10d0 [ 341.535850] dae0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000078 [ 341.544074] db00: d03f04f0 00000087 00000000 00000000 c2432908 c2638640 00000087 d03f0500 [ 341.552296] db20: c1e08488 c2418b30 406293ec 295bca2f 00000000 00000000 00000000 00000000 [ 341.560517] db40: 00000000 00000000 d03f04f0 00000078 e99adb84 e99adb60 c040e488 00000087 [ 341.568741] db60: 00000001 d03f0500 d03f0000 c1e47f04 00000000 c1e09fd0 e99adc34 e99adb88 [ 341.576961] db80: c04c1d1c c04c10d0 ffffe000 c1fcaf30 c069cddc c1e47f04 e99adbbc e99adba8 [ 341.585182] dba0: c04c19e0 c04c1864 d03f04f0 00000087 00000000 00000000 c2432908 c2638640 [ 341.593405] dbc0: 00000087 d03f0500 c1e08488 c2418b30 406293ec 295bca2f e99adc24 e99adbe8 [ 341.601628] dbe0: c04fe13c c05615d4 00000001 00000000 c069cddc e99adc54 e99adc2c e99adc08 [ 341.609851] dc00: c040e488 c040ce94 c1e08488 00000000 ffffe000 c1fcaf30 c069cddc c1e47f04 [ 341.618073] dc20: e99adc64 e99adc30 d03f0000 c04fe13c ffffe000 c1fcaf30 c069cddc c1e47f04 [ 341.626294] dc40: e99adc64 e99adc50 c04c19e0 c04c1864 c1dc1000 c04fe13c e99adc8c e99adc68 [ 341.634517] dc60: c056165c c04c18d8 c1e47e40 400b0013 00000001 e99adce0 c069cddc 9fdbe7c7 [ 341.642738] dc80: e99adccc cf380840 c11cd90c e776d400 eb6d1030 00000010 00000001 c1938660 [ 341.650959] dca0: e99adcf4 e99adcb0 c119c98c c11cd918 00000000 e3444a98 e99add14 e99adcd0 [ 341.659180] dcc0: c069ce08 c069cd10 5cf61726 c119c908 c10933a0 00000000 00000000 c06b7624 [ 341.667403] dce0: 00000001 c1938660 e99add14 e99adcf8 c1093390 c119c914 00000000 e3444a98 [ 341.675624] dd00: e7cd5110 c1e08488 e99add2c e99add18 c10933d8 c1093368 00000000 0000026d [ 341.683846] dd20: e99add64 e99add30 c06b7694 c10933ac e99add38 00000000 00000000 00000000 [ 341.692067] dd40: c1e08488 9fdbe7c7 e7bdc800 e99adda0 d3b2fcc0 00000018 e99add9c e99add68 [ 341.700289] dd60: c06b8a04 c06b7630 e99ade60 00000000 00000000 c1e08488 d3b2fcc0 c06b7624 [ 341.708510] dd80: e68598c0 00000000 00000001 e99adf20 e99addfc e99adda0 c06b9214 c06b897c [ 341.716731] dda0: 00000001 00000001 00000000 e68598c0 00000000 00000000 00000000 00000000 [ 341.724953] ddc0: 00000000 00000000 00000000 9fdbe7c7 00000000 c06b9240 e99adea0 00000001 [ 341.733176] dde0: 00000000 00000010 00000000 00000001 e99ade14 e99ade00 c06b9270 c06b91a4 [ 341.741398] de00: 00000000 c06b7624 e99ade34 e99ade18 c06b761c c06b924c 00000000 e99adea0 [ 341.749621] de20: 00000001 d3b2fcc0 e99ade9c e99ade38 c06b7ff0 c06b75dc 00000000 c067a2dc [ 341.757842] de40: 00000001 c1e08488 00000000 c06b75d0 00000000 e9949a00 00000010 00000000 [ 341.766065] de60: 00000011 00000000 e99adf1c 9fdbe7c7 00020000 c1e08488 e99adf18 00000010 [ 341.774285] de80: 00000000 e9949a00 e99adf20 e68598c0 e99adef4 e99adea0 c06b8238 c06b7edc [ 341.782507] dea0: 00000001 00000001 00000000 e68598c0 00000010 00000000 e99adf20 00000000 [ 341.790729] dec0: 00000000 00000000 d03f0000 9fdbe7c7 c1e08488 c1e08488 e9949a00 fffff000 [ 341.798952] dee0: 00000fff 00000001 e99adf5c e99adef8 c067ac74 c06b8198 00000001 00000000 [ 341.807174] df00: e776d420 00000000 00000000 00000000 e68598c0 e9949a00 00000010 00000000 [ 341.815397] df20: 00000000 00000000 c1e08488 9fdbe7c7 00000001 c1e08488 00000001 00000000 [ 341.823618] df40: 00000000 c04011c4 0000001e 00000001 e99adfa4 e99adf60 c067c2a4 c067aaa4 [ 341.831841] df60: fffff000 00000fff e99adfac e99adf78 c1dc1000 9fdbe7c7 e99adfac bef7ca44 [ 341.840063] df80: 00000001 00000200 000000bb c04011c4 e99ac000 000000bb 00000000 e99adfa8 [ 341.848285] dfa0: c0401000 c067c1b8 bef7ca44 00000001 0000001a 0000001e 00000000 00000001 [ 341.856508] dfc0: bef7ca44 00000001 00000200 000000bb 00000001 0000001e 0000001a 00000010 [ 341.864729] dfe0: 00045034 bef7c884 000137c0 b6e76d7c 200b0010 0000001a 00000000 00000000 [ 341.872948] Backtrace: [ 341.875425] [<c10e9d98>] (bpf_msg_push_data) from [<c0581f6c>] (___bpf_prog_run+0x130/0x1bbc) [ 341.883999] r10:c0581ddc r9:00000000 r8:00000000 r7:c10e9d98 r6:c1419868 r5:e99ad8b8 [ 341.891869] r4:f006b240 [ 341.894426] [<c0581e3c>] (___bpf_prog_run) from [<c0584910>] (__bpf_prog_run32+0x4c/0x68) [ 341.902649] r10:c1fc9e37 r9:e99ad9e4 r8:f006b000 r7:c11cd828 r6:00000011 r5:f006b028 [ 341.910520] r4:c1e08488 [ 341.913079] [<c05848c4>] (__bpf_prog_run32) from [<c10fdf18>] (sk_psock_msg_verdict+0x104/0x354) [ 341.921909] r4:d1bdc000 [ 341.924470] [<c10fde14>] (sk_psock_msg_verdict) from [<c11cd828>] (tcp_bpf_send_verdict+0x31c/0x400) [ 341.933654] r10:c1fc9e37 r9:e99ad9e4 r8:00000000 r7:cf380840 r6:00000011 r5:e7bdd400 [ 341.941524] r4:d1bdc000 [ 341.944083] [<c11cd50c>] (tcp_bpf_send_verdict) from [<c11cdb60>] (tcp_bpf_sendpage+0x254/0x3c4) [ 341.952914] r10:c1fc9e37 r9:00000003 r8:00000000 r7:c1e08488 r6:eb6d1030 r5:cf380840 [ 341.960784] r4:e7bdd400 [ 341.963343] [<c11cd90c>] (tcp_bpf_sendpage) from [<c119c98c>] (inet_sendpage+0x84/0x294) [ 341.971480] r10:c1938660 r9:00000001 r8:00000010 r7:eb6d1030 r6:e776d400 r5:c11cd90c [ 341.979350] r4:cf380840 [ 341.981906] [<c119c908>] (inet_sendpage) from [<c1093390>] (kernel_sendpage+0x34/0x44) [ 341.989868] r10:c1938660 r9:00000001 r8:c06b7624 r7:00000000 r6:00000000 r5:c10933a0 [ 341.997738] r4:c119c908 [ 342.000290] [<c109335c>] (kernel_sendpage) from [<c10933d8>] (sock_sendpage+0x38/0x40) [ 342.008248] r4:c1e08488 [ 342.010805] [<c10933a0>] (sock_sendpage) from [<c06b7694>] (pipe_to_sendpage+0x70/0xa4) [ 342.018856] [<c06b7624>] (pipe_to_sendpage) from [<c06b8a04>] (__splice_from_pipe+0x94/0x1cc) [ 342.027424] r7:00000018 r6:d3b2fcc0 r5:e99adda0 r4:e7bdc800 [ 342.033122] [<c06b8970>] (__splice_from_pipe) from [<c06b9214>] (splice_from_pipe+0x7c/0xa8) [ 342.041605] r10:e99adf20 r9:00000001 r8:00000000 r7:e68598c0 r6:c06b7624 r5:d3b2fcc0 [ 342.049475] r4:c1e08488 [ 342.052032] [<c06b9198>] (splice_from_pipe) from [<c06b9270>] (generic_splice_sendpage+0x30/0x38) [ 342.060953] r10:00000001 r9:00000000 r8:00000010 r7:00000000 r6:00000001 r5:e99adea0 [ 342.068822] r4:c06b9240 [ 342.071377] [<c06b9240>] (generic_splice_sendpage) from [<c06b761c>] (direct_splice_actor+0x4c/0x54) [ 342.080562] [<c06b75d0>] (direct_splice_actor) from [<c06b7ff0>] (splice_direct_to_actor+0x120/0x2bc) [ 342.089827] r4:d3b2fcc0 [ 342.092383] [<c06b7ed0>] (splice_direct_to_actor) from [<c06b8238>] (do_splice_direct+0xac/0xe4) [ 342.101218] r10:e68598c0 r9:e99adf20 r8:e9949a00 r7:00000000 r6:00000010 r5:e99adf18 [ 342.109088] r4:c1e08488 [ 342.111645] [<c06b818c>] (do_splice_direct) from [<c067ac74>] (do_sendfile+0x1dc/0x420) [ 342.119693] r8:00000001 r7:00000fff r6:fffff000 r5:e9949a00 r4:c1e08488 [ 342.126436] [<c067aa98>] (do_sendfile) from [<c067c2a4>] (sys_sendfile+0xf8/0x11c) [ 342.134048] r10:00000001 r9:0000001e r8:c04011c4 r7:00000000 r6:00000000 r5:00000001 [ 342.141917] r4:c1e08488 [ 342.144475] [<c067c1ac>] (sys_sendfile) from [<c0401000>] (ret_fast_syscall+0x0/0x28) [ 342.152346] Exception stack(0xe99adfa8 to 0xe99adff0) [ 342.157428] dfa0: bef7ca44 00000001 0000001a 0000001e 00000000 00000001 [ 342.165650] dfc0: bef7ca44 00000001 00000200 000000bb 00000001 0000001e 0000001a 00000010 [ 342.173870] dfe0: 00045034 bef7c884 000137c0 b6e76d7c [ 342.178951] r10:000000bb r9:e99ac000 r8:c04011c4 r7:000000bb r6:00000200 r5:00000001 [ 342.186822] r4:bef7ca44 [ 342.189377] Code: e4808004 e480e004 e8bd01e0 e1b02f82 (14d13001) [ 342.195755] ---[ end trace d2353d98cf59813b ]--- [1] https://qa-reports.linaro.org/lkft/linux-next-oe/build/next-20190604/testru…

5 years, 10 months

1
0
0 0

[PATCH v2 18/22] docs: move protection-keys.rst to the core-api book

by Mauro Carvalho Chehab

This document is used by multiple architectures: $ echo $(git grep -l pkey_mprotect arch|cut -d'/' -f 2|sort|uniq) alpha arm arm64 ia64 m68k microblaze mips parisc powerpc s390 sh sparc x86 xtensa So, let's move it to the core book and adjust the links to it accordingly. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> --- Documentation/core-api/index.rst | 1 + Documentation/{x86 => core-api}/protection-keys.rst | 0 Documentation/x86/index.rst | 1 - arch/powerpc/Kconfig | 2 +- arch/x86/Kconfig | 2 +- tools/testing/selftests/x86/protection_keys.c | 2 +- 6 files changed, 4 insertions(+), 4 deletions(-) rename Documentation/{x86 => core-api}/protection-keys.rst (100%) diff --git a/Documentation/core-api/index.rst b/Documentation/core-api/index.rst index ee1bb8983a88..2466a4c51031 100644 --- a/Documentation/core-api/index.rst +++ b/Documentation/core-api/index.rst @@ -34,6 +34,7 @@ Core utilities timekeeping boot-time-mm memory-hotplug + protection-keys Interfaces for kernel debugging diff --git a/Documentation/x86/protection-keys.rst b/Documentation/core-api/protection-keys.rst similarity index 100% rename from Documentation/x86/protection-keys.rst rename to Documentation/core-api/protection-keys.rst diff --git a/Documentation/x86/index.rst b/Documentation/x86/index.rst index ae36fc5fc649..f2de1b2d3ac7 100644 --- a/Documentation/x86/index.rst +++ b/Documentation/x86/index.rst @@ -19,7 +19,6 @@ x86-specific Documentation tlb mtrr pat - protection-keys intel_mpx amd-memory-encryption pti diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 1120ff8ac715..e437aa3e78b4 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -898,7 +898,7 @@ config PPC_MEM_KEYS page-based protections, but without requiring modification of the page tables when an application changes protection domains. - For details, see Documentation/vm/protection-keys.rst + For details, see Documentation/core-api/protection-keys.rst If unsure, say y. diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 23de3b9da480..61244bdb886f 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1911,7 +1911,7 @@ config X86_INTEL_MEMORY_PROTECTION_KEYS page-based protections, but without requiring modification of the page tables when an application changes protection domains. - For details, see Documentation/x86/protection-keys.txt + For details, see Documentation/core-api/protection-keys.rst If unsure, say y. diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c index 5d546dcdbc80..480995bceefa 100644 --- a/tools/testing/selftests/x86/protection_keys.c +++ b/tools/testing/selftests/x86/protection_keys.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Tests x86 Memory Protection Keys (see Documentation/x86/protection-keys.txt) + * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst) * * There are examples in here of: * * how to set protection keys on memory -- 2.21.0

5 years, 10 months

1
0
0 0

[PATCH v15 00/17] arm64: untag user pointers passed to the kernel

by Andrey Konovalov

=== Overview arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces. Right now the kernel is already able to handle user faults with tagged pointers, due to these patches: 1. 81cddd65 ("arm64: traps: fix userspace cache maintenance emulation on a tagged pointer") 2. 7dcd9dd8 ("arm64: hw_breakpoint: fix watchpoint matching for tagged pointers") 3. 276e9327 ("arm64: entry: improve data abort handling of tagged pointers") This patchset extends tagged pointer support to syscall arguments. As per the proposed ABI change [3], tagged pointers are only allowed to be passed to syscalls when they point to memory ranges obtained by anonymous mmap() or sbrk() (see the patchset [3] for more details). For non-memory syscalls this is done by untaging user pointers when the kernel performs pointer checking to find out whether the pointer comes from userspace (most notably in access_ok). The untagging is done only when the pointer is being checked, the tag is preserved as the pointer makes its way through the kernel and stays tagged when the kernel dereferences the pointer when perfoming user memory accesses. Memory syscalls (mmap, mprotect, etc.) don't do user memory accesses but rather deal with memory ranges, and untagged pointers are better suited to describe memory ranges internally. Thus for memory syscalls we untag pointers completely when they enter the kernel. === Other approaches One of the alternative approaches to untagging that was considered is to completely strip the pointer tag as the pointer enters the kernel with some kind of a syscall wrapper, but that won't work with the countless number of different ioctl calls. With this approach we would need a custom wrapper for each ioctl variation, which doesn't seem practical. An alternative approach to untagging pointers in memory syscalls prologues is to inspead allow tagged pointers to be passed to find_vma() (and other vma related functions) and untag them there. Unfortunately, a lot of find_vma() callers then compare or subtract the returned vma start and end fields against the pointer that was being searched. Thus this approach would still require changing all find_vma() callers. === Testing The following testing approaches has been taken to find potential issues with user pointer untagging: 1. Static testing (with sparse [2] and separately with a custom static analyzer based on Clang) to track casts of __user pointers to integer types to find places where untagging needs to be done. 2. Static testing with grep to find parts of the kernel that call find_vma() (and other similar functions) or directly compare against vm_start/vm_end fields of vma. 3. Static testing with grep to find parts of the kernel that compare user pointers with TASK_SIZE or other similar consts and macros. 4. Dynamic testing: adding BUG_ON(has_tag(addr)) to find_vma() and running a modified syzkaller version that passes tagged pointers to the kernel. Based on the results of the testing the requried patches have been added to the patchset. === Notes This patchset is meant to be merged together with "arm64 relaxed ABI" [3]. This patchset is a prerequisite for ARM's memory tagging hardware feature support [4]. This patchset has been merged into the Pixel 2 & 3 kernel trees and is now being used to enable testing of Pixel phones with HWASan. Thanks! [1] http://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html [2] https://github.com/lucvoo/sparse-dev/commit/5f960cb10f56ec2017c128ef9d16060… [3] https://lkml.org/lkml/2019/3/18/819 [4] https://community.arm.com/processors/b/blog/posts/arm-a-profile-architectur… Changes in v15: - Removed unnecessary untagging from radeon_ttm_tt_set_userptr(). - Removed unnecessary untagging from amdgpu_ttm_tt_set_userptr(). - Moved untagging to validate_range() in userfaultfd code. - Moved untagging to ib_uverbs_(re)reg_mr() from mlx4_get_umem_mr(). - Rebased onto 5.1. Changes in v14: - Moved untagging for most memory syscalls to an arm64 specific implementation, instead of doing that in the common code. - Dropped "net, arm64: untag user pointers in tcp_zerocopy_receive", since the provided user pointers don't come from an anonymous map and thus are not covered by this ABI relaxation. - Dropped "kernel, arm64: untag user pointers in prctl_set_mm*". - Moved untagging from __check_mem_type() to tee_shm_register(). - Updated untagging for the amdgpu and radeon drivers to cover the MMU notifier, as suggested by Felix. - Since this ABI relaxation doesn't actually allow tagged instruction pointers, dropped the following patches: - Dropped "tracing, arm64: untag user pointers in seq_print_user_ip". - Dropped "uprobes, arm64: untag user pointers in find_active_uprobe". - Dropped "bpf, arm64: untag user pointers in stack_map_get_build_id_offset". - Rebased onto 5.1-rc7 (37624b58). Changes in v13: - Simplified untagging in tcp_zerocopy_receive(). - Looked at find_vma() callers in drivers/, which allowed to identify a few other places where untagging is needed. - Added patch "mm, arm64: untag user pointers in get_vaddr_frames". - Added patch "drm/amdgpu, arm64: untag user pointers in amdgpu_ttm_tt_get_user_pages". - Added patch "drm/radeon, arm64: untag user pointers in radeon_ttm_tt_pin_userptr". - Added patch "IB/mlx4, arm64: untag user pointers in mlx4_get_umem_mr". - Added patch "media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get". - Added patch "tee/optee, arm64: untag user pointers in check_mem_type". - Added patch "vfio/type1, arm64: untag user pointers". Changes in v12: - Changed untagging in tcp_zerocopy_receive() to also untag zc->address. - Fixed untagging in prctl_set_mm* to only untag pointers for vma lookups and validity checks, but leave them as is for actual user space accesses. - Updated the link to the v2 of the "arm64 relaxed ABI" patchset [3]. - Dropped the documentation patch, as the "arm64 relaxed ABI" patchset [3] handles that. Changes in v11: - Added "uprobes, arm64: untag user pointers in find_active_uprobe" patch. - Added "bpf, arm64: untag user pointers in stack_map_get_build_id_offset" patch. - Fixed "tracing, arm64: untag user pointers in seq_print_user_ip" to correctly perform subtration with a tagged addr. - Moved untagged_addr() from SYSCALL_DEFINE3(mprotect) and SYSCALL_DEFINE4(pkey_mprotect) to do_mprotect_pkey(). - Moved untagged_addr() definition for other arches from include/linux/memory.h to include/linux/mm.h. - Changed untagging in strn*_user() to perform userspace accesses through tagged pointers. - Updated the documentation to mention that passing tagged pointers to memory syscalls is allowed. - Updated the test to use malloc'ed memory instead of stack memory. Changes in v10: - Added "mm, arm64: untag user pointers passed to memory syscalls" back. - New patch "fs, arm64: untag user pointers in fs/userfaultfd.c". - New patch "net, arm64: untag user pointers in tcp_zerocopy_receive". - New patch "kernel, arm64: untag user pointers in prctl_set_mm*". - New patch "tracing, arm64: untag user pointers in seq_print_user_ip". Changes in v9: - Rebased onto 4.20-rc6. - Used u64 instead of __u64 in type casts in the untagged_addr macro for arm64. - Added braces around (addr) in the untagged_addr macro for other arches. Changes in v8: - Rebased onto 65102238 (4.20-rc1). - Added a note to the cover letter on why syscall wrappers/shims that untag user pointers won't work. - Added a note to the cover letter that this patchset has been merged into the Pixel 2 kernel tree. - Documentation fixes, in particular added a list of syscalls that don't support tagged user pointers. Changes in v7: - Rebased onto 17b57b18 (4.19-rc6). - Dropped the "arm64: untag user address in __do_user_fault" patch, since the existing patches already handle user faults properly. - Dropped the "usb, arm64: untag user addresses in devio" patch, since the passed pointer must come from a vma and therefore be untagged. - Dropped the "arm64: annotate user pointers casts detected by sparse" patch (see the discussion to the replies of the v6 of this patchset). - Added more context to the cover letter. - Updated Documentation/arm64/tagged-pointers.txt. Changes in v6: - Added annotations for user pointer casts found by sparse. - Rebased onto 050cdc6c (4.19-rc1+). Changes in v5: - Added 3 new patches that add untagging to places found with static analysis. - Rebased onto 44c929e1 (4.18-rc8). Changes in v4: - Added a selftest for checking that passing tagged pointers to the kernel succeeds. - Rebased onto 81e97f013 (4.18-rc1+). Changes in v3: - Rebased onto e5c51f30 (4.17-rc6+). - Added linux-arch@ to the list of recipients. Changes in v2: - Rebased onto 2d618bdf (4.17-rc3+). - Removed excessive untagging in gup.c. - Removed untagging pointers returned from __uaccess_mask_ptr. Changes in v1: - Rebased onto 4.17-rc1. Changes in RFC v2: - Added "#ifndef untagged_addr..." fallback in linux/uaccess.h instead of defining it for each arch individually. - Updated Documentation/arm64/tagged-pointers.txt. - Dropped "mm, arm64: untag user addresses in memory syscalls". - Rebased onto 3eb2ce82 (4.16-rc7). Signed-off-by: Andrey Konovalov <andreyknvl(a)google.com> Andrey Konovalov (17): uaccess: add untagged_addr definition for other arches arm64: untag user pointers in access_ok and __uaccess_mask_ptr lib, arm64: untag user pointers in strn*_user mm: add ksys_ wrappers to memory syscalls arms64: untag user pointers passed to memory syscalls mm: untag user pointers in do_pages_move mm, arm64: untag user pointers in mm/gup.c mm, arm64: untag user pointers in get_vaddr_frames fs, arm64: untag user pointers in copy_mount_options fs, arm64: untag user pointers in fs/userfaultfd.c drm/amdgpu, arm64: untag user pointers drm/radeon, arm64: untag user pointers in radeon_gem_userptr_ioctl IB, arm64: untag user pointers in ib_uverbs_(re)reg_mr() media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get tee, arm64: untag user pointers in tee_shm_register vfio/type1, arm64: untag user pointers in vaddr_get_pfn selftests, arm64: add a selftest for passing tagged pointers to kernel arch/arm64/include/asm/uaccess.h | 10 +- arch/arm64/kernel/sys.c | 128 ++++++++++++++++- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 + drivers/gpu/drm/radeon/radeon_gem.c | 2 + drivers/infiniband/core/uverbs_cmd.c | 4 + drivers/media/v4l2-core/videobuf-dma-contig.c | 9 +- drivers/tee/tee_shm.c | 1 + drivers/vfio/vfio_iommu_type1.c | 2 + fs/namespace.c | 2 +- fs/userfaultfd.c | 22 +-- include/linux/mm.h | 4 + include/linux/syscalls.h | 22 +++ ipc/shm.c | 7 +- lib/strncpy_from_user.c | 3 +- lib/strnlen_user.c | 3 +- mm/frame_vector.c | 2 + mm/gup.c | 4 + mm/madvise.c | 129 +++++++++--------- mm/mempolicy.c | 21 ++- mm/migrate.c | 1 + mm/mincore.c | 57 ++++---- mm/mlock.c | 20 ++- mm/mmap.c | 30 +++- mm/mprotect.c | 6 +- mm/mremap.c | 27 ++-- mm/msync.c | 35 +++-- tools/testing/selftests/arm64/.gitignore | 1 + tools/testing/selftests/arm64/Makefile | 11 ++ .../testing/selftests/arm64/run_tags_test.sh | 12 ++ tools/testing/selftests/arm64/tags_test.c | 21 +++ 31 files changed, 436 insertions(+), 164 deletions(-) create mode 100644 tools/testing/selftests/arm64/.gitignore create mode 100644 tools/testing/selftests/arm64/Makefile create mode 100755 tools/testing/selftests/arm64/run_tags_test.sh create mode 100644 tools/testing/selftests/arm64/tags_test.c -- 2.21.0.1020.gf2820cf01a-goog

5 years, 10 months

13
98
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror