- Linux-kselftest-mirror - lists.linaro.org

selftests: bpf: test_sock: WARNING: workqueue.c:3030 __flush_work+0x3fc/0x470

by Naresh Kamboju

Do you see kernel WARNING while running bpf: test_sock test case ? This kernel warning is popping up continuously for ~725 times on all devices ( arm64, arm, x86_64 and i386). selftests: bpf: test_sock Test case: bind4 load with invalid access: src_ip6 .. [PASS] Test case: bind4 load with invalid access: mark .. [PASS] Test case: bind6 load with invalid access: src_ip4 .. [PASS] Test case: sock_create load with invalid access: src_port .. [PASS] Test case: sock_create load w/o expected_attach_type (compat mode) .. [PASS] Test case: sock_create load w/ expected_attach_type .. [PASS] Test case: attach type mismatch bind4 vs bind6 .. [PASS] Test case: attach type mismatch bind6 vs bind4 .. [PASS] Test case: attach type mismatch default vs bind4 .. [PASS] Test case: attach type mismatch bind6 vs sock_create .. [PASS] Test case: bind4 reject all .. [PASS] Test case: bind6 reject all .. [PASS] Test case: bind6 deny specific IP & port .. [PASS] Test case: bind4 allow specific IP & port .. [PASS] Test case: bind4 allow all .. [PASS] Test case: bind6 allow all .. [PASS] Summ[ 200.359313] WARNING: CPU: 1 PID: 3400 at /usr/src/kernel/kernel/workqueue.c:3030 __flush_work+0x3fc/0x470 [ 200.369390] Modules linked in: tun algif_hash af_alg x86_pkg_temp_thermal fuse [ 200.376621] CPU: 1 PID: 3400 Comm: kworker/1:156 Not tainted 5.1.0 #1 [ 200.383061] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 200.390455] Workqueue: events sk_psock_destroy_deferred [ 200.395679] RIP: 0010:__flush_work+0x3fc/0x470 [ 200.400123] Code: 03 00 31 c0 e9 a4 fe ff ff 41 8b 0c 24 49 8b 54 24 08 83 e1 08 49 0f ba 2c 24 03 80 c9 f0 e9 d0 fd ff ff 0f 0b e9 83 fe ff ff <0f> 0b 31 c0 e9 7a fe ff ff e8 e6 1f 06 00 84 c0 0f 85 fd fe ff ff [ 200.418859] RSP: 0018:ffffa5d68487bca0 EFLAGS: 00010246 [ 200.424079] RAX: 0000000000000000 RBX: ffff9abc19269468 RCX: 0000000000000006 [ 200.431200] RDX: 0000000000001b35 RSI: 0000000000000001 RDI: ffff9abc19269468 [ 200.438324] RBP: ffffa5d68487bd68 R08: 0000000000000000 R09: 0000000000000000 [ 200.445449] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9abc19269468 [ 200.452572] R13: 0000000000000001 R14: ffffa5d68487bd98 R15: ffffffffabe91000 [ 200.459696] FS: 0000000000000000(0000) GS:ffff9abc6f880000(0000) knlGS:0000000000000000 [ 200.467776] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 200.473521] CR2: 00007f6c3ebf3cb0 CR3: 00000001d920a006 CR4: 00000000003606e0 [ 200.480644] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 200.487768] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 200.494891] Call Trace: [ 200.497338] ? get_work_pool+0x90/0x90 [ 200.501090] ? mark_held_locks+0x4d/0x80 [ 200.505015] ? __cancel_work_timer+0x11a/0x1d0 [ 200.509452] ? cancel_delayed_work_sync+0x13/0x20 [ 200.514151] ? lockdep_hardirqs_on+0xf6/0x190 [ 200.518509] ? __cancel_work_timer+0x11a/0x1d0 [ 200.522946] ? get_work_pool+0x90/0x90 [ 200.526691] __cancel_work_timer+0x134/0x1d0 [ 200.530965] cancel_delayed_work_sync+0x13/0x20 [ 200.535497] strp_done+0x1c/0x50 [ 200.538729] sk_psock_destroy_deferred+0x34/0x1c0 [ 200.543434] process_one_work+0x281/0x610 [ 200.547439] worker_thread+0x3c/0x3f0 [ 200.551105] kthread+0x12c/0x150 [ 200.554337] ? process_one_work+0x610/0x610 [ 200.558515] ? kthread_park+0x90/0x90 [ 200.562180] ret_from_fork+0x3a/0x50 [ 200.565762] irq event stamp: 2382 [ 200.569079] hardirqs last enabled at (2381): [<ffffffffabe9569a>] __cancel_work_timer+0x11a/0x1d0 [ 200.578030] hardirqs last disabled at (2382): [<ffffffffabe01b7b>] trace_hardirqs_off_thunk+0x1a/0x1c [ 200.587234] softirqs last enabled at (1806): [<fffffffface00334>] __do_softirq+0x334/0x445 [ 200.595573] softirqs last disabled at (1761): [<ffffffffabe76e70>] irq_exit+0xc0/0xd0 [ 200.603398] ---[ end trace 447ba7732b3f8640 ]--- Test full log link, https://qa-reports.linaro.org/lkft/linux-mainline-oe/build/v5.1-9822-g47782… Best regards Naresh Kamboju

5 years, 8 months

1
0
0 0

next-20190513 kselftest results

by ci_notify＠linaro.org

Summary ------------------------------------------------------------------------ kernel: 5.1.0 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git branch: master git commit: 04c4b6775d34f12f196e056debed9e8718585342 git describe: next-20190513 Test details: https://qa-reports.linaro.org/lkft/linux-next-oe/build/next-20190513 Regressions (compared to build next-20190510) ------------------------------------------------------------------------ No regressions Fixes (compared to build next-20190510) ------------------------------------------------------------------------ No fixes In total: ------------------------------------------------------------------------ Ran 12 total tests in the following environments and test suites. pass 11 fail 1 xfail 0 skip 0 Environments -------------- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 Test Suites ----------- * boot-lkft-kselftests-master-520 * boot-lkft-kselftests-vsyscall-mode-native-master-520 * boot-lkft-kselftests-vsyscall-mode-none-master-520 Failures ------------------------------------------------------------------------ qemu_i386: juno-r2: qemu_arm64: qemu_x86_64: hi6220-hikey: dragonboard-410c: * boot-lkft-kselftests-master-520/dragonboard-410c i386: x86: qemu_arm: x15: Skips ------------------------------------------------------------------------ No skips -- Linaro LKFT https://lkft.linaro.org

5 years, 8 months

1
0
0 0

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

by Josh Poimboeuf

On Wed, May 08, 2019 at 05:39:07PM +0200, Peter Zijlstra wrote: > On Wed, May 08, 2019 at 07:42:48AM -0500, Josh Poimboeuf wrote: > > On Wed, May 08, 2019 at 02:04:16PM +0200, Peter Zijlstra wrote: > > > > Do the x86_64 variants also want some ORC annotation? > > > > Maybe so. Though it looks like regs->ip isn't saved. The saved > > registers might need to be tweaked. I'll need to look into it. > > What all these sites do (and maybe we should look at unifying them > somehow) is turn a CALL frame (aka RET-IP) into an exception frame (aka > pt_regs). > > So regs->ip will be the return address (which is fixed up to be the CALL > address in the handler). But from what I can tell, trampoline_handler() hard-codes regs->ip to point to kretprobe_trampoline(), and the original return address is placed in regs->sp. Masami, is there a reason why regs->ip doesn't have the original return address and regs->sp doesn't have the original SP? I think that would help the unwinder understand things. -- Josh

5 years, 8 months

5
22
0 0

[PATCH v2] selftests: bpf: Add files generated after build to .gitignore

by Kelsey Skunberg

The following files are generated after building /selftests/bpf/ and should be added to .gitignore: - libbpf.pc - libbpf.so.* Signed-off-by: Kelsey Skunberg <skunberg.kelsey(a)gmail.com> --- Change since v1: - Add libbpf.so.* in replace of libbpf.so.0 and libbpf.so.0.0.3 - Update commit log to reflect file change tools/testing/selftests/bpf/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index 41e8a689aa77..a877803e4ba8 100644 --- a/tools/testing/selftests/bpf/.gitignore +++ b/tools/testing/selftests/bpf/.gitignore @@ -32,3 +32,5 @@ test_tcpnotify_user test_libbpf test_tcp_check_syncookie_user alu32 +libbpf.pc +libbpf.so.* -- 2.20.1

5 years, 8 months

2
1
0 0

Build-time tests?

by Joe Lawrence

Hello kbuild, kselftest, I've been working on a patchset which adds an additional build script to the toolchain when compiling livepatches. There are a few kernel section features in which this script does not yet support, but can detect and abort when it encounters. To test this detection, I've written a small set of kernel modules that require such sections. A few questions: Is build-testing out of scope for kernel selftests? For expediency, it was really easy to spin out new lib/livepatch kernel modules. Does kbuild support the notion of expected failure? In this case, the build script returns a non-zero error and the build stops. Am I trying to fit a square peg in a round hole? I could easily keep these build tests in a private branch, but could they exist in a different format somewhere else in the tree? Suggestions welcome, -- Joe

5 years, 8 months

2
1
0 0

[PATCH] selftests: bpf: Add files generated when compiled to .gitignore

by Kelsey Skunberg

The following files are generated when /selftests/bpf/ is compiled and should be added to .gitignore: - libbpf.pc - libbpf.so.0 - libbpf.so.0.0.3 Signed-off-by: Kelsey Skunberg <skunberg.kelsey(a)gmail.com> --- tools/testing/selftests/bpf/.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index 41e8a689aa77..ceb11f98fe4f 100644 --- a/tools/testing/selftests/bpf/.gitignore +++ b/tools/testing/selftests/bpf/.gitignore @@ -32,3 +32,6 @@ test_tcpnotify_user test_libbpf test_tcp_check_syncookie_user alu32 +libbpf.pc +libbpf.so.0 +libbpf.so.0.0.3 -- 2.20.1

5 years, 8 months

2
2
0 0

[PATCH] selftests: kvm: Add files generated when compiled to .gitignore

by Kelsey Skunberg

The following files are generated in /selftests/kvm/ after compiling and should be added to /selftests/kvm/.gitignore: - /x86_64/hyperv_cpuid - /x86_64/smm_test Signed-off-by: Kelsey Skunberg <skunberg.kelsey(a)gmail.com> --- tools/testing/selftests/kvm/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore index 2689d1ea6d7a..81e9cb775ab8 100644 --- a/tools/testing/selftests/kvm/.gitignore +++ b/tools/testing/selftests/kvm/.gitignore @@ -6,4 +6,6 @@ /x86_64/vmx_close_while_nested_test /x86_64/vmx_tsc_adjust_test /x86_64/state_test +/x86_64/hyperv_cpuid +/x86_64/smm_test /dirty_log_test -- 2.20.1

5 years, 8 months

1
0
0 0

[PATCH 0/3] kheaders fixes for -rc

by Joel Fernandes (Google)

Linus, Greg, Masahiro, Here are some simple fixes for the kheaders feature. Please consider these patches for an rc release. They are based on Linus's master branch. Thanks! Joel Fernandes (Google) (3): kheaders: Move from proc to sysfs kheaders: Do not regenerate archive if config is not changed kheaders: Make it depend on sysfs init/Kconfig | 17 +++++---- kernel/Makefile | 4 +-- kernel/{gen_ikh_data.sh => gen_kheaders.sh} | 17 ++++++--- kernel/kheaders.c | 40 +++++++++------------ 4 files changed, 38 insertions(+), 40 deletions(-) rename kernel/{gen_ikh_data.sh => gen_kheaders.sh} (82%) -- 2.21.0.1020.gf2820cf01a-goog

5 years, 8 months

4
6
0 0

[PATCH v11 0/7] ptrace: add PTRACE_GET_SYSCALL_INFO request

by Dmitry V. Levin

[Andrew, could you take this patchset into your tree, please? Besides the patch for hexagon, all patches in this series have Acked-by or Reviewed-by tags already. I have been waiting and pinging the hexagon maintainer since November without any visible effect. The last Acked-by from the hexagon maintainer in linux.git was in October and the last Signed-off-by was in July. Since that time not a single change affecting hexagon was able to attract attention of the hexagon maintainer, so I don't think it's worth waiting any longer.] PTRACE_GET_SYSCALL_INFO is a generic ptrace API that lets ptracer obtain details of the syscall the tracee is blocked in. There are two reasons for a special syscall-related ptrace request. Firstly, with the current ptrace API there are cases when ptracer cannot retrieve necessary information about syscalls. Some examples include: * The notorious int-0x80-from-64-bit-task issue. See [1] for details. In short, if a 64-bit task performs a syscall through int 0x80, its tracer has no reliable means to find out that the syscall was, in fact, a compat syscall, and misidentifies it. * Syscall-enter-stop and syscall-exit-stop look the same for the tracer. Common practice is to keep track of the sequence of ptrace-stops in order not to mix the two syscall-stops up. But it is not as simple as it looks; for example, strace had a (just recently fixed) long-standing bug where attaching strace to a tracee that is performing the execve system call led to the tracer identifying the following syscall-exit-stop as syscall-enter-stop, which messed up all the state tracking. * Since the introduction of commit 84d77d3f06e7e8dea057d10e8ec77ad71f721be3 ("ptrace: Don't allow accessing an undumpable mm"), both PTRACE_PEEKDATA and process_vm_readv become unavailable when the process dumpable flag is cleared. On such architectures as ia64 this results in all syscall arguments being unavailable for the tracer. Secondly, ptracers also have to support a lot of arch-specific code for obtaining information about the tracee. For some architectures, this requires a ptrace(PTRACE_PEEKUSER, ...) invocation for every syscall argument and return value. PTRACE_GET_SYSCALL_INFO returns the following structure: struct ptrace_syscall_info { __u8 op; /* PTRACE_SYSCALL_INFO_* */ __u32 arch __attribute__((__aligned__(sizeof(__u32)))); __u64 instruction_pointer; __u64 stack_pointer; union { struct { __u64 nr; __u64 args[6]; } entry; struct { __s64 rval; __u8 is_error; } exit; struct { __u64 nr; __u64 args[6]; __u32 ret_data; } seccomp; }; }; The structure was chosen according to [2], except for the following changes: * seccomp substructure was added as a superset of entry substructure; * the type of nr field was changed from int to __u64 because syscall numbers are, as a practical matter, 64 bits; * stack_pointer field was added along with instruction_pointer field since it is readily available and can save the tracer from extra PTRACE_GETREGS/PTRACE_GETREGSET calls; * arch is always initialized to aid with tracing system calls * such as execve(); * instruction_pointer and stack_pointer are always initialized so they could be easily obtained for non-syscall stops; * a boolean is_error field was added along with rval field, this way the tracer can more reliably distinguish a return value from an error value. strace has been ported to PTRACE_GET_SYSCALL_INFO. Starting with release 4.26, strace uses PTRACE_GET_SYSCALL_INFO API as the preferred mechanism of obtaining syscall information. [1] https://lore.kernel.org/lkml/CA+55aFzcSVmdDj9Lh_gdbz1OzHyEm6ZrGPBDAJnywm2LF… [2] https://lore.kernel.org/lkml/CAObL_7GM0n80N7J_DFw_eQyfLyzq+sf4y2AvsCCV88Tb3… --- Notes: v11: * Added more Acked-by. * Rebased back to mainline as the prerequisite syscall_get_arch patchset has already been merged via audit tree. v10: * Added more Acked-by. v9: * Rebased to linux-next again due to syscall_get_arguments() signature change. v8: * Moved syscall_get_arch() specific patches to a separate patchset which is now merged into audit/next tree. * Rebased to linux-next. * Moved ptrace_get_syscall_info code under #ifdef CONFIG_HAVE_ARCH_TRACEHOOK, narrowing down the set of architectures supported by this implementation back to those 19 that enable CONFIG_HAVE_ARCH_TRACEHOOK because I failed to get all syscall_get_*(), instruction_pointer(), and user_stack_pointer() functions implemented on some niche architectures. This leaves the following architectures out: alpha, h8300, m68k, microblaze, and unicore32. v7: * Rebased to v5.0-rc1. * 5 arch-specific preparatory patches out of 25 have been merged into v5.0-rc1 via arch trees. v6: * Added syscall_get_arguments and syscall_set_arguments wrappers to asm-generic/syscall.h, requested by Geert. * Changed PTRACE_GET_SYSCALL_INFO return code: do not take trailing paddings into account, use the end of the last field of the structure being written. * Changed struct ptrace_syscall_info: * remove .frame_pointer field, is is not needed and not portable; * make .arch field explicitly aligned, remove no longer needed padding before .arch field; * remove trailing pads, they are no longer needed. v5: * Merged separate series and patches into the single series. * Changed PTRACE_EVENTMSG_SYSCALL_{ENTRY,EXIT} values as requested by Oleg. * Changed struct ptrace_syscall_info: generalized instruction_pointer, stack_pointer, and frame_pointer fields by moving them from ptrace_syscall_info.{entry,seccomp} substructures to ptrace_syscall_info and initializing them for all stops. * Added PTRACE_SYSCALL_INFO_NONE, set it when not in a syscall stop, so e.g. "strace -i" could use PTRACE_SYSCALL_INFO_SECCOMP to obtain instruction_pointer when the tracee is in a signal stop. * Patched all remaining architectures to provide all necessary syscall_get_* functions. * Made available for all architectures: do not conditionalize on CONFIG_HAVE_ARCH_TRACEHOOK since all syscall_get_* functions are implemented on all architectures. * Added a test for PTRACE_GET_SYSCALL_INFO to selftests/ptrace. v4: * Revisited PTRACE_EVENT_SECCOMP support: do not introduce task_struct.ptrace_event, use child->last_siginfo->si_code instead. * Implemented PTRACE_SYSCALL_INFO_SECCOMP and ptrace_syscall_info.seccomp support along with PTRACE_SYSCALL_INFO_{ENTRY,EXIT} and ptrace_syscall_info.{entry,exit}. v3: * Changed struct ptrace_syscall_info. * Added PTRACE_EVENT_SECCOMP support by adding ptrace_event to task_struct. * Added proper defines for ptrace_syscall_info.op values. * Renamed PT_SYSCALL_IS_ENTERING and PT_SYSCALL_IS_EXITING to PTRACE_EVENTMSG_SYSCALL_ENTRY and PTRACE_EVENTMSG_SYSCALL_EXIT and moved them to uapi. v2: * Stopped using task->ptrace. * Replaced entry_info.is_compat with entry_info.arch, used syscall_get_arch(). * Used addr argument of sys_ptrace to get expected size of the struct; return full size of the struct. Dmitry V. Levin (6): nds32: fix asm/syscall.h # acked hexagon: define syscall_get_error() and syscall_get_return_value() # waiting for ack since November mips: define syscall_get_error() # acked parisc: define syscall_get_error() # acked powerpc: define syscall_get_error() # acked selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO # acked Elvira Khabirova (1): ptrace: add PTRACE_GET_SYSCALL_INFO request # reviewed arch/hexagon/include/asm/syscall.h | 14 + arch/mips/include/asm/syscall.h | 6 + arch/nds32/include/asm/syscall.h | 27 +- arch/parisc/include/asm/syscall.h | 7 + arch/powerpc/include/asm/syscall.h | 10 + include/linux/tracehook.h | 9 +- include/uapi/linux/ptrace.h | 35 +++ kernel/ptrace.c | 101 ++++++- tools/testing/selftests/ptrace/.gitignore | 1 + tools/testing/selftests/ptrace/Makefile | 2 +- .../selftests/ptrace/get_syscall_info.c | 271 ++++++++++++++++++ 11 files changed, 468 insertions(+), 15 deletions(-) create mode 100644 tools/testing/selftests/ptrace/get_syscall_info.c -- ldv

5 years, 8 months

1
1
0 0

[PATCH] selftests/bpf: Fix compile warning in bpf selftest

by Alakesh Haloi

This fixes the following compile time warning flow_dissector_load.c: In function ‘detach_program’: flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security] error(1, errno, command); ^~~~~~~ Signed-off-by: Alakesh Haloi <alakesh.haloi(a)gmail.com> --- tools/testing/selftests/bpf/flow_dissector_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c index 77cafa66d048..7136ab9ffa73 100644 --- a/tools/testing/selftests/bpf/flow_dissector_load.c +++ b/tools/testing/selftests/bpf/flow_dissector_load.c @@ -52,7 +52,7 @@ static void detach_program(void) sprintf(command, "rm -r %s", cfg_pin_path); ret = system(command); if (ret) - error(1, errno, command); + error(1, errno, "%s", command); } static void parse_opts(int argc, char **argv) -- 2.17.1

5 years, 8 months

2
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror