August 2025 - Linux-kselftest-mirror

[PATCH] selftests/cachestat: fix grammar and debug prints

by Mallikarjun Thammanavar

Fix minor grammar in ksft_print_msg() output for better readability. Signed-off-by: Mallikarjun Thammanavar <mallikarjunst09(a)gmail.com> --- tools/testing/selftests/cachestat/test_cachestat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index 632ab44737ec..1417d7fb7910 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -76,7 +76,7 @@ bool write_exactly(int fd, size_t filesize) ssize_t write_len = write(fd, cursor, remained); if (write_len <= 0) { - ksft_print_msg("Unable write random data to file.\n"); + ksft_print_msg("Unable to write random data to file.\n"); ret = false; goto out_free_data; } @@ -183,7 +183,7 @@ static int test_cachestat(const char *filename, bool write_random, bool create, if (cs.nr_dirty) { ret = KSFT_FAIL; ksft_print_msg( - "Number of dirty should be zero after fsync.\n"); + "Number of dirty pages should be zero after fsync.\n"); } } else { ksft_print_msg("Cachestat (after fsync) returned non-zero.\n"); -- 2.43.0

1 week, 2 days

1
0
0 0

[PATCH] KVM: selftests: Fix typo in hyperv cpuid test message

by Alok Tiwari

Fix a typo in hyperv_cpuid.c test assertion log: replace "our of supported range" -> "out of supported range". Signed-off-by: Alok Tiwari <alok.a.tiwari(a)oracle.com> --- tools/testing/selftests/kvm/x86/hyperv_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/x86/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86/hyperv_cpuid.c index c863a689aa985..3c21af811d8f1 100644 --- a/tools/testing/selftests/kvm/x86/hyperv_cpuid.c +++ b/tools/testing/selftests/kvm/x86/hyperv_cpuid.c @@ -45,7 +45,7 @@ static void test_hv_cpuid(struct kvm_vcpu *vcpu, bool evmcs_expected) TEST_ASSERT((entry->function >= 0x40000000) && (entry->function <= 0x40000082), - "function %x is our of supported range", + "function %x is out of supported range", entry->function); TEST_ASSERT(entry->index == 0, -- 2.50.1

1 week, 2 days

1
0
0 0

[PATCH] selftests/filesystems: Grammatical correction in error message

by Prithvi Tambewagh

Grammatical correction in error message for TIOCGTPTERR failure Signed-off-by: Prithvi Tambewagh <activprithvi(a)gmail.com> --- tools/testing/selftests/filesystems/devpts_pts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/filesystems/devpts_pts.c b/tools/testing/selftests/filesystems/devpts_pts.c index b1fc9b916ace..b7652df7888b 100644 --- a/tools/testing/selftests/filesystems/devpts_pts.c +++ b/tools/testing/selftests/filesystems/devpts_pts.c @@ -129,7 +129,7 @@ static int do_tiocgptpeer(char *ptmx, char *expected_procfd_contents) fret = KSFT_SKIP; } else { fprintf(stderr, - "Failed to perform TIOCGPTPEER ioctl\n"); + "TIOCGPTPEER ioctl operation failed\n"); fret = EXIT_FAILURE; } goto do_cleanup; -- 2.34.1

1 week, 2 days

1
0
0 0

[PATCH] selftests: alsa: Fix typo in mixer-test.c

by Vivek Alurkar

Change "libray" to "library". Signed-off-by: Vivek Alurkar <primalkenja(a)gmail.com> --- tools/testing/selftests/alsa/mixer-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/alsa/mixer-test.c b/tools/testing/selftests/alsa/mixer-test.c index 2a4b2662035e..dc7b290fc4ad 100644 --- a/tools/testing/selftests/alsa/mixer-test.c +++ b/tools/testing/selftests/alsa/mixer-test.c @@ -685,7 +685,7 @@ static int write_and_verify(struct ctl_data *ctl, } /* - * Use the libray to compare values, if there's a mismatch + * Use the library to compare values, if there's a mismatch * carry on and try to provide a more useful diagnostic than * just "mismatch". */ -- 2.48.1

1 week, 2 days

2
1
0 0

[PATCH 0/1] docs: kselftest: remove link to obsolete wiki

by Brett A C Sheffield

Greetings, I've recently been getting my head around the kselftest system from a standing start. As I do so, it makes sense that I submit any patches to fix or clarify the accompanying documentation while I still have a newbie's perspective, as presumably that is who such documentation is aimed at. Paragraph three of the "Linux Kernel Selftests" documentation immediately sends me off elsewhere to a wiki which greets me with the ominous warning: "OBSOLETE CONTENT This wiki has been archived and the content is no longer updated." The wiki hasn't been updated since 2019, still refers to Freenode as an IRC network where one might find help, and mentions kernel versions that are probably older than some budding kernel developers. There are a few links to Google docs with slides from presentations given over a decade ago, but I don't think there's much in here that isn't covered more accessibly in the kernel Documentation/ If there's anything in the archived wiki that should be retained, lets move it into the main documentation. Cheers, Brett -- Brett A C Sheffield (1): docs: kselftest: remove link to obsolete wiki Documentation/dev-tools/kselftest.rst | 5 ----- 1 file changed, 5 deletions(-) -- 2.49.1

1 week, 2 days

1
1
0 0

[PATCH] selftests: coredump: Fix compilation issue

by Sahil Chandna

Building coredump selftests fails on x86 due to following issues: 1./usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant 35 | MS_RDONLY = 1, /* Mount read-only. */ | <linux/fs.h> pulls in kernel-internal headers that conflict with glibc's <sys/mount.h>, causing this error. 2.stackdump_test.c:25:1: note: ‘offsetof’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’? Missing <stddef.h> causes unresolved use of offsetof(). Fix this by: - dropping <linux/fs.h> and including <sys/mount.h> - including <stddef.h> for offsetof() Signed-off-by: Sahil Chandna <chandna.sahil(a)gmail.com> --- tools/testing/selftests/coredump/stackdump_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index a4ac80bb1003..881565d28fa9 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -6,7 +6,7 @@ #include <libgen.h> #include <limits.h> #include <linux/coredump.h> -#include <linux/fs.h> +#include <sys/mount.h> #include <linux/limits.h> #include <pthread.h> #include <string.h> @@ -18,6 +18,7 @@ #include <sys/socket.h> #include <sys/un.h> #include <unistd.h> +#include <stddef.h> #include "../kselftest_harness.h" #include "../filesystems/wrappers.h" -- 2.34.1

1 week, 2 days

1
0
0 0

[PATCH 0/3] kselftest/arm64: Cleanups and readability fixes

by vivekyadav1207731111＠gmail.com

From: Vivek Yadav <vivekyadav1207731111(a)gmail.com> Hi all, This small series makes cosmetic style cleanups in the arm64 kselftests to improve readability and suppress checkpatch warnings. These changes are purely cosmetic and do not affect functionality. Changes in this series: * Suppress unnecessary checkpatch warning in a comment * Add parentheses around sizeof for clarity * Remove redundant blank line --- Vivek Yadav (3): kselftest/arm64: Remove extra blank line kselftest/arm64: Supress warning and improve readability kselftest/arm64: Add parentheses around sizeof for clarity tools/testing/selftests/arm64/abi/hwcap.c | 1 - tools/testing/selftests/arm64/bti/assembler.h | 1 - tools/testing/selftests/arm64/fp/fp-ptrace.c | 1 - tools/testing/selftests/arm64/fp/fp-stress.c | 4 ++-- tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 +- tools/testing/selftests/arm64/fp/vec-syscfg.c | 1 - tools/testing/selftests/arm64/fp/zt-ptrace.c | 1 - tools/testing/selftests/arm64/gcs/gcs-locking.c | 1 - 8 files changed, 3 insertions(+), 9 deletions(-) -- 2.25.1

1 week, 2 days

1
3
0 0

[PATCH] selftests: timers: Fix wording and grammar in messages

by Preetpalbugs

Signed-off-by: Preetpalbugs <preetpal.singh(a)s.amity.edu> --- posix_timers.c | 290 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 290 insertions(+) create mode 100644 posix_timers.c diff --git a/posix_timers.c b/posix_timers.c new file mode 100644 index 0000000..486b71b --- /dev/null +++ b/posix_timers.c @@ -0,0 +1,290 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2013 Red Hat, Inc., Frederic Weisbecker <fweisbec(a)redhat.com> + * + * Selftests for a few posix timers interface. + * + * Kernel loop code stolen from Steven Rostedt <srostedt(a)redhat.com> + */ + +#include <sys/time.h> +#include <stdio.h> +#include <signal.h> +#include <unistd.h> +#include <time.h> +#include <pthread.h> + +#include "../kselftest.h" + +#define DELAY 2 +#define USECS_PER_SEC 1000000 + +static volatile int done; + +/* Busy loop in userspace to elapse ITIMER_VIRTUAL */ +static void user_loop(void) +{ + while (!done); +} + +/* + * Try to spend as much time as possible in kernelspace + * to elapse ITIMER_PROF. + */ +static void kernel_loop(void) +{ + void *addr = sbrk(0); + int err = 0; + + while (!done && !err) { + err = brk(addr + 4096); + err |= brk(addr); + } +} + +/* + * Sleep until ITIMER_REAL expiration. + */ +static void idle_loop(void) +{ + pause(); +} + +static void sig_handler(int nr) +{ + done = 1; +} + +/* + * Check the expected timer expiration matches the GTOD elapsed delta since + * we armed the timer. Keep a 0.5 sec error margin due to various jitter. + */ +static int check_diff(struct timeval start, struct timeval end) +{ + long long diff; + + diff = end.tv_usec - start.tv_usec; + diff += (end.tv_sec - start.tv_sec) * USECS_PER_SEC; + + if (llabs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) { + printf("Diff too high: %lld..", diff); + return -1; + } + + return 0; +} + +static int check_itimer(int which) +{ + const char *name; + int err; + struct timeval start, end; + struct itimerval val = { + .it_value.tv_sec = DELAY, + }; + + if (which == ITIMER_VIRTUAL) + name = "ITIMER_VIRTUAL"; + else if (which == ITIMER_PROF) + name = "ITIMER_PROF"; + else if (which == ITIMER_REAL) + name = "ITIMER_REAL"; + else + return -1; + + done = 0; + + if (which == ITIMER_VIRTUAL) + signal(SIGVTALRM, sig_handler); + else if (which == ITIMER_PROF) + signal(SIGPROF, sig_handler); + else if (which == ITIMER_REAL) + signal(SIGALRM, sig_handler); + + err = gettimeofday(&start, NULL); + if (err < 0) { + ksft_perror("Can't call gettimeofday()"); + return -1; + } + + err = setitimer(which, &val, NULL); + if (err < 0) { + ksft_perror("Can't set timer"); + return -1; + } + + if (which == ITIMER_VIRTUAL) + user_loop(); + else if (which == ITIMER_PROF) + kernel_loop(); + else if (which == ITIMER_REAL) + idle_loop(); + + err = gettimeofday(&end, NULL); + if (err < 0) { + ksft_perror("Can't call gettimeofday()"); + return -1; + } + + ksft_test_result(check_diff(start, end) == 0, "%s\n", name); + + return 0; +} + +static int check_timer_create(int which) +{ + const char *type; + int err; + timer_t id; + struct timeval start, end; + struct itimerspec val = { + .it_value.tv_sec = DELAY, + }; + + if (which == CLOCK_THREAD_CPUTIME_ID) { + type = "thread"; + } else if (which == CLOCK_PROCESS_CPUTIME_ID) { + type = "process"; + } else { + ksft_print_msg("Unknown timer_create() type %d\n", which); + return -1; + } + + done = 0; + err = timer_create(which, NULL, &id); + if (err < 0) { + ksft_perror("Can't create timer"); + return -1; + } + signal(SIGALRM, sig_handler); + + err = gettimeofday(&start, NULL); + if (err < 0) { + ksft_perror("Can't call gettimeofday()"); + return -1; + } + + err = timer_settime(id, 0, &val, NULL); + if (err < 0) { + ksft_perror("Can't set timer"); + return -1; + } + + user_loop(); + + err = gettimeofday(&end, NULL); + if (err < 0) { + ksft_perror("Can't call gettimeofday()"); + return -1; + } + + ksft_test_result(check_diff(start, end) == 0, + "timer_create() per %s\n", type); + + return 0; +} + +static pthread_t ctd_thread; +static volatile int ctd_count, ctd_failed; + +static void ctd_sighandler(int sig) +{ + if (pthread_self() != ctd_thread) + ctd_failed = 1; + ctd_count--; +} + +static void *ctd_thread_func(void *arg) +{ + struct itimerspec val = { + .it_value.tv_sec = 0, + .it_value.tv_nsec = 1000 * 1000, + .it_interval.tv_sec = 0, + .it_interval.tv_nsec = 1000 * 1000, + }; + timer_t id; + + /* 1/10 seconds to ensure the leader sleeps */ + usleep(10000); + + ctd_count = 100; + if (timer_create(CLOCK_PROCESS_CPUTIME_ID, NULL, &id)) + return "Can't create timer\n"; + if (timer_settime(id, 0, &val, NULL)) + return "Can't set timer\n"; + + while (ctd_count > 0 && !ctd_failed) + ; + + if (timer_delete(id)) + return "Can't delete timer\n"; + + return NULL; +} + +/* + * Test that only the running thread receives the timer signal. + */ +static int check_timer_distribution(void) +{ + const char *errmsg; + + signal(SIGALRM, ctd_sighandler); + + errmsg = "Can't create thread\n"; + if (pthread_create(&ctd_thread, NULL, ctd_thread_func, NULL)) + goto err; + + errmsg = "Cannot join thread\n"; + if (pthread_join(ctd_thread, (void **)&errmsg) || errmsg) + goto err; + + if (!ctd_failed) + ksft_test_result_pass("check signal distribution\n"); + else if (ksft_min_kernel_version(6, 3)) + ksft_test_result_fail("check signal distribution\n"); + else + ksft_test_result_skip("check signal distribution (old kernel)\n"); + return 0; +err: + ksft_print_msg("%s", errmsg); + return -1; +} + +int main(int argc, char **argv) +{ + ksft_print_header(); + ksft_set_plan(6); + + ksft_print_msg("Testing POSIX timers. False negative may happen on CPU execution \n"); + ksft_print_msg("This may happen on CPU-based timers if other threads run on the CPU...\n"); + + if (check_itimer(ITIMER_VIRTUAL) < 0) + ksft_exit_fail(); + + if (check_itimer(ITIMER_PROF) < 0) + ksft_exit_fail(); + + if (check_itimer(ITIMER_REAL) < 0) + ksft_exit_fail(); + + if (check_timer_create(CLOCK_THREAD_CPUTIME_ID) < 0) + ksft_exit_fail(); + + /* + * It's unfortunately hard to reliably test a timer expiration + * on parallel multithread cputime. We could arm it to expire + * on DELAY * nr_threads, with nr_threads busy looping, then wait + * the normal DELAY since the time is elapsing nr_threads faster. + * But for that we need to ensure we have real physical free CPUs + * to ensure true parallelism. So test only one thread until we + * find a better solution. + */ + if (check_timer_create(CLOCK_PROCESS_CPUTIME_ID) < 0) + ksft_exit_fail(); + + if (check_timer_distribution() < 0) + ksft_exit_fail(); + + ksft_finished(); +} -- 2.50.1

1 week, 3 days

1
0
0 0

[PATCH bpf-next 0/4] Add overwrite mode for bpf ring buffer

by Xu Kuohai

From: Xu Kuohai <xukuohai(a)huawei.com> When the bpf ring buffer is full, new events can not be recorded util the consumer consumes some events to free space. This may cause critical events to be discarded, such as in fault diagnostic, where recent events are more critical than older ones. So add ovewrite mode for bpf ring buffer. In this mode, the new event overwrites the oldest event when the buffer is full. Xu Kuohai (4): bpf: Add overwrite mode for bpf ring buffer libbpf: ringbuf: Add overwrite ring buffer process selftests/bpf: Add test for overwrite ring buffer selftests/bpf/benchs: Add overwrite mode bench for rb-libbpf include/uapi/linux/bpf.h | 4 + kernel/bpf/ringbuf.c | 159 +++++++++++++++--- tools/include/uapi/linux/bpf.h | 4 + tools/lib/bpf/ringbuf.c | 103 +++++++++++- tools/testing/selftests/bpf/Makefile | 3 +- .../selftests/bpf/benchs/bench_ringbufs.c | 22 ++- .../bpf/benchs/run_bench_ringbufs.sh | 4 + .../selftests/bpf/prog_tests/ringbuf.c | 74 ++++++++ .../bpf/progs/test_ringbuf_overwrite.c | 98 +++++++++++ 9 files changed, 442 insertions(+), 29 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/test_ringbuf_overwrite.c -- 2.43.0

1 week, 3 days

6
14
0 0

[PATCH bpf-next v14 0/2] libbpf: fix USDT SIB argument handling causing unrecognized register error

by Jiawei Zhao

When using GCC on x86-64 to compile an usdt prog with -O1 or higher optimization, the compiler will generate SIB addressing mode for global array and PC-relative addressing mode for global variable, e.g. "1@-96(%rbp,%rax,8)" and "-1@4+t1(%rip)". The current USDT implementation in libbpf cannot parse these two formats, causing `bpf_program__attach_usdt()` to fail with -ENOENT (unrecognized register). This patch series adds support for SIB addressing mode in USDT probes. The main changes include: - add correct handling logic for SIB-addressed arguments in `parse_usdt_arg`. - add an usdt_o2 test case to cover SIB addressing mode. Testing shows that the SIB probe correctly generates 8@(%rcx,%rax,8) argument spec and passes all validation checks. The modification history of this patch series: Change since v1: - refactor the code to make it more readable - modify the commit message to explain why and how Change since v2: - fix the `scale` uninitialized error Change since v3: - force -O2 optimization for usdt.test.o to generate SIB addressing usdt and pass all test cases. Change since v4: - split the patch into two parts, one for the fix and the other for the test Change since v5: - Only enable optimization for x86 architecture to generate SIB addressing usdt argument spec. Change since v6: - Add an usdt_o2 test case to cover SIB addressing mode. - Reinstate the usdt.c test case. Change since v7: - Refactor modifications to __bpf_usdt_arg_spec to avoid increasing its size, achieving better compatibility - Fix some minor code style issues - Refactor the usdt_o2 test case, removing semaphore and adding GCC attribute to force -O2 optimization Change since v8: - Refactor the usdt_o2 test case, using assembly to force SIB addressing mode. Change since v9: - Only enable the usdt_o2 test case on x86_64 and i386 architectures since the SIB addressing mode is only supported on x86_64 and i386. Change since v10: - Replace `__attribute__((optimize("O2")))` with `#pragma GCC optimize("O1")` to fix the issue where the optimized compilation condition works improperly. - Renamed test case usdt_o2 and relevant files name to usdt_o1 in that O1 level optimization is enough to generate SIB addressing usdt argument spec. Change since v11: - Replace `STAP_PROBE1` with `STAP_PROBE_ASM` - Use bit fields instead of bit shifting operations - Merge the usdt_o1 test case into the usdt test case Change since v12: - This patch is same with the v12 but with a new version number. Change since v13(resolve some review comments): - https://lore.kernel.org/bpf/CAEf4BzZWd2zUC=U6uGJFF3EMZ7zWGLweQAG3CJWTeHy-5y… - https://lore.kernel.org/bpf/CAEf4Bzbs3hV_Q47+d93tTX13WkrpkpOb4=U04mZCjHyZg4… Jiawei Zhao (2): libbpf: fix USDT SIB argument handling causing unrecognized register error selftests/bpf: Enrich subtest_basic_usdt case in selftests to cover SIB handling logic tools/lib/bpf/usdt.bpf.h | 44 ++++++++++++- tools/lib/bpf/usdt.c | 57 +++++++++++++++-- tools/testing/selftests/bpf/prog_tests/usdt.c | 62 ++++++++++++++++++- tools/testing/selftests/bpf/progs/test_usdt.c | 32 ++++++++++ 4 files changed, 186 insertions(+), 9 deletions(-) -- 2.43.0

1 week, 3 days

1
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror August 2025