The <bits/version.h> header needs to be regenerated. The changes to the generated file were not in the diff posted to the mailing list (but are committed to git).
On Mon, 25 Sept 2023 at 11:55, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
In CI config tcwg_gcc_check/master-arm after:
| gcc patch https://patchwork.sourceware.org/patch/76638 | Author: Jonathan Wakely jwakely@redhat.com | Date: Mon Sep 25 09:53:24 2023 +0100 | | libstdc++: Define C++23 std::forward_like (P2445R1) | | Tested x86_64-linux. Pushed to trunk. | | -- >8 -- | | libstdc++-v3/ChangeLog: | ... 8 lines of the commit log omitted. | ... applied on top of baseline commit: | c25d6f15211 LoongArch: doc: Update -m[no-]explicit-relocs for r14-4160
FAIL: 12 regressions
regressions.sum: === libstdc++ tests ===
Running libstdc++:libstdc++-dg/conformance.exp ... FAIL: 20_util/forward_like/1.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/1.cc -std=gnu++26 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line ) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line 5) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line 7) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++26 (test for errors, line ) ... and 7 more entries
You can find the failure logs in *.log.1.xz files in
The full lists of regressions and progressions are in
The list of [ignored] baseline and flaky failures are in
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1059/artifact/art...
Hi Jonathan,
Thanks for the heads up.
We do run contrib/gcc_update --touch after applying patches, and before starting the build, but I realize it doesn't help in the case of bits/version.h
It looks like we should run make update-version? Is that documented somewhere? (I'm wondering what's the list of such regeneration rules, I was mainly aware of the autoconf part)
Thanks,
Christophe
On Mon, 25 Sept 2023 at 22:09, Jonathan Wakely jwakely@redhat.com wrote:
The <bits/version.h> header needs to be regenerated. The changes to the generated file were not in the diff posted to the mailing list (but are committed to git).
On Mon, 25 Sept 2023 at 11:55, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your
patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
In CI config tcwg_gcc_check/master-arm after:
| gcc patch https://patchwork.sourceware.org/patch/76638 | Author: Jonathan Wakely jwakely@redhat.com | Date: Mon Sep 25 09:53:24 2023 +0100 | | libstdc++: Define C++23 std::forward_like (P2445R1) | | Tested x86_64-linux. Pushed to trunk. | | -- >8 -- | | libstdc++-v3/ChangeLog: | ... 8 lines of the commit log omitted. | ... applied on top of baseline commit: | c25d6f15211 LoongArch: doc: Update -m[no-]explicit-relocs for
r14-4160
FAIL: 12 regressions
regressions.sum: === libstdc++ tests ===
Running libstdc++:libstdc++-dg/conformance.exp ... FAIL: 20_util/forward_like/1.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/1.cc -std=gnu++26 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line
)
FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line
FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line
FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++26 (test for errors, line
)
... and 7 more entries
You can find the failure logs in *.log.1.xz files in
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact... .
The full lists of regressions and progressions are in
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact... .
The list of [ignored] baseline and flaky failures are in
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact... .
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below can be used to reproduce a debug environment:
Current build :
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact...
Reference build :
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1059/artifact/art...
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.org
On Thu, 28 Sept 2023 at 16:42, Christophe Lyon christophe.lyon@linaro.org wrote:
Hi Jonathan,
Thanks for the heads up.
We do run contrib/gcc_update --touch after applying patches, and before starting the build, but I realize it doesn't help in the case of bits/version.h
It looks like we should run make update-version?
Yes, in $objdir/$target/libstdc++-v3/include Or you can just run 'autogen version.def' in $srcdir/libstdc++-v3/include/bits instead, which is what the update-version makefile target does.
Is that documented somewhere? (I'm wondering what's the list of such regeneration rules, I was mainly aware of the autoconf part)
Hmm, no, it's not. We should add it to the docs.
For libstdc++ I use 'autoreconf' in the source dir, to run both automake and autoconf (other parts of GCC don't use automake, just autoconf).
Thanks,
Christophe
On Mon, 25 Sept 2023 at 22:09, Jonathan Wakely jwakely@redhat.com wrote:
The <bits/version.h> header needs to be regenerated. The changes to the generated file were not in the diff posted to the mailing list (but are committed to git).
On Mon, 25 Sept 2023 at 11:55, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
In CI config tcwg_gcc_check/master-arm after:
| gcc patch https://patchwork.sourceware.org/patch/76638 | Author: Jonathan Wakely jwakely@redhat.com | Date: Mon Sep 25 09:53:24 2023 +0100 | | libstdc++: Define C++23 std::forward_like (P2445R1) | | Tested x86_64-linux. Pushed to trunk. | | -- >8 -- | | libstdc++-v3/ChangeLog: | ... 8 lines of the commit log omitted. | ... applied on top of baseline commit: | c25d6f15211 LoongArch: doc: Update -m[no-]explicit-relocs for r14-4160
FAIL: 12 regressions
regressions.sum: === libstdc++ tests ===
Running libstdc++:libstdc++-dg/conformance.exp ... FAIL: 20_util/forward_like/1.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/1.cc -std=gnu++26 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line ) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line 5) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for errors, line 7) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++23 (test for excess errors) FAIL: 20_util/forward_like/2_neg.cc -std=gnu++26 (test for errors, line ) ... and 7 more entries
You can find the failure logs in *.log.1.xz files in
The full lists of regressions and progressions are in
The list of [ignored] baseline and flaky failures are in
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/3840/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1059/artifact/art...
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.org
linaro-toolchain@lists.linaro.org