On Jun 19, 2025, Alexandre Oliva <oliva(a)adacore.com> wrote:
> Or maybe the requirements for this testcase should be stated as
> arm_arch_v7? I'd have to add arm_arch_v7 to
> check_effective_target_arm_arch_FUNC_ok et al, if there aren't reasons
> why it's not there, but I'd be happy to do that, and use dg-add-options
> instead of an explicit -march=armv7, like pr117675.c, if that would be
> preferred.
It turned out that the regression report I got from linaro was related
https://linaro.atlassian.net/browse/GNU-1599
While testing a configuration with -mfloat-abi=hard, -marmv7 is rejected
because it doesn't have an FPU.
Requiring thumb2 wouldn't have avoided this failure, but requiring armv7
is a proper fix for both problems.
(sorry it me took so long; I'm still busy busy with other
fp2sp-elimination-disabled-during-lra problems affecting arm)
Without stating the architecture version required by the test, test
runs with options that are incompatible with the required
architecture version fail, e.g. -mfloat-abi=hard.
armv7 was not covered by the long list of arm variants in
target-supports.exp, so add it, and use it for the effective target
requirement and for the option.
Tested on arm-eabi, and also on arm-vx7r2 with gcc-14. Ok to install?
for gcc/testsuite/ChangeLog
PR rtl-optimization/120424
* lib/target-supports.exp (arm arches): Add arm_arch_v7.
* g++.target/arm/pr120424.C: Require armv7 support. Use
dg-add-options arm_arch_v7 instead of explicit -march=armv7.
---
gcc/testsuite/g++.target/arm/pr120424.C | 4 +++-
gcc/testsuite/lib/target-supports.exp | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.target/arm/pr120424.C b/gcc/testsuite/g++.target/arm/pr120424.C
index 4d0e49013c04a..40295ac80da93 100644
--- a/gcc/testsuite/g++.target/arm/pr120424.C
+++ b/gcc/testsuite/g++.target/arm/pr120424.C
@@ -1,5 +1,7 @@
/* { dg-do compile } */
-/* { dg-options "-march=armv7 -O2 -fstack-clash-protection -fnon-call-exceptions" } */
+/* { dg-require-effective-target arm_arch_v7_ok } */
+/* { dg-options "-O2 -fstack-clash-protection -fnon-call-exceptions" } */
+/* { dg-add-options arm_arch_v7 } */
/* { dg-final { scan-assembler-not {#-8} } } */
/* LRA register elimination gets confused when register spilling
causes arm_frame_pointer_required to switch from false to true, and
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index dfffe3adfbdd0..858fa1787f19c 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -6073,6 +6073,7 @@ foreach { armfunc armflag armdefs } {
v6z_arm "-march=armv6z+fp -marm" "__ARM_ARCH_6Z__ && !__thumb__"
v6z_thumb "-march=armv6z+fp -mthumb -mfloat-abi=softfp" "__ARM_ARCH_6Z__ && __thumb__"
v6m "-march=armv6-m -mthumb -mfloat-abi=soft" __ARM_ARCH_6M__
+ v7 "-march=armv7" __ARM_ARCH_7__
v7a "-march=armv7-a+fp" __ARM_ARCH_7A__
v7a_arm "-march=armv7-a+fp -marm" "__ARM_ARCH_7A__ && !__thumb__"
v7a_fp_hard "-march=armv7-a+fp -mfpu=auto -mfloat-abi=hard" __ARM_ARCH_7A__
--
Alexandre Oliva, happy hacker https://blog.lx.oliva.nom.br/
Free Software Activist FSFLA co-founder GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity.
Excluding neuro-others for not behaving ""normal"" is *not* inclusive!
[This is a CI regression report that wasn't sent due to infra problem.]
Hi Florian,
Your glibc patch fixes a lot of failures in GDB testsuite, but also creates a few new FAILs -- are these expected?
Thanks!
===
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In master-aarch64, after:
| commit glibc-2.41.9000-556-g620f0730f31
| Author: Florian Weimer <fweimer(a)redhat.com>
| Date: Mon Jul 28 14:16:52 2025 +0200
|
| elf: Compile _dl_debug_state separately (bug 33224)
|
| This ensures that the compiler will not inline it, so that
| debuggers which do not use the Systemtap probes can reliably
| set a breakpoint on it.
| ... 3 lines of the commit log omitted.
Produces 8 regressions 1564 fixes:
|
| regressions.sum:
| Running gdb:gdb.dap/cxx-exception.exp ...
| FAIL: gdb.dap/cxx-exception.exp: exceptions in log file
| Running gdb:gdb.dap/ptrref.exp ...
| FAIL: gdb.dap/ptrref.exp: exceptions in log file
| Running gdb:gdb.threads/process-dies-while-detaching.exp ...
| ... and 7 more
|
| fixes.sum:
| Running gdb:gdb.arch/aarch64-sve-sigunwind.exp ...
| FAIL: gdb.arch/aarch64-sve-sigunwind.exp: $\z2.b.u contents were correctly unwound
| FAIL: gdb.arch/aarch64-sve-sigunwind.exp: size of $\z3.b.u was correctly unwound
| FAIL: gdb.arch/aarch64-sve-sigunwind.exp: $\z12.b.u contents were correctly unwound
| FAIL: gdb.arch/aarch64-sve-sigunwind.exp: $\z22.b.u contents were correctly unwound
| ... and 1676 more
Used configuration :
*CI config* tcwg_gnu_native_check_gdb master-aarch64
*configure and test flags:* none, autodetected on aarch64-unknown-linux-gnu
We track this bug report under https://linaro.atlassian.net/browse/GNU-692. Please let us know if you have a fix.
If you have any questions regarding this report, please ask on linaro-toolchain(a)lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
* https://ci.linaro.org/job/tcwg_gnu_native_check_gdb--master-aarch64-build/1…
The full lists of regressions and improvements as well as configure and make commands are in
* https://ci.linaro.org/job/tcwg_gnu_native_check_gdb--master-aarch64-build/1…
The list of [ignored] baseline and flaky failures are in
* https://ci.linaro.org/job/tcwg_gnu_native_check_gdb--master-aarch64-build/1…
Current build : https://ci.linaro.org/job/tcwg_gnu_native_check_gdb--master-aarch64-build/1…
Reference build : https://ci.linaro.org/job/tcwg_gnu_native_check_gdb--master-aarch64-build/1…
Instruction to reproduce the build : https://gitlab.com/Linaro/tcwg/ci/interesting-commits/-/raw/master/glibc/sh…
Full commit : https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=620f0730f311635cd0e1…
--
Maxim Kuvyrkov
https://www.linaro.org
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In tcwg_flang_build/main-aarch64, after:
| commit llvmorg-22-init-2744-ga15b629527a9
| Author: Jon Roelofs <jonathan_roelofs(a)apple.com>
| Date: Tue Aug 5 17:08:00 2025 -0700
|
| Revert "Strip the full path from __FILE__ in the LDBG macro and keep only the filename (#150677)"
|
| This reverts commit 5d26e3c227f4b4a1761a8b0001b3165198def479.
|
| It breaks the modules build of clang, since every source file has a different
| ... 9 lines of the commit log omitted.
Produces Failure:
| Results changed to
| # reset_artifacts:
| -10
| # true:
| 0
| # build_llvm -- clang;lld;flang;clang-tools-extra openmp :
| # FAILED
| # First few build errors in logs:
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:71:12: error: a type specifier is required for all declarations
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:77:4: error: identifier 'raw_ldbg_ostream' after '~' in destructor name does not name a type
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:54:9: error: member initializer 'os' does not name a non-static data member or base class
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:59:23: error: use of undeclared identifier 'os'
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:61:12: error: use of undeclared identifier 'os'
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:73:7: error: only constructors take base initializers
| # 00:03:30 ../llvm/llvm/include/llvm/Support/DebugLog.h:75:5: error: use of undeclared identifier 'SetUnbuffered'
| # 00:03:30 ../llvm/mlir/lib/IR/PatternLoggingListener.cpp:10:3: error: use of undeclared identifier '_GET_LDBG_MACRO'
| # 00:03:30 ../llvm/mlir/lib/IR/PatternLoggingListener.cpp:17:3: error: use of undeclared identifier '_GET_LDBG_MACRO'
| # 00:03:30 ../llvm/mlir/lib/IR/PatternLoggingListener.cpp:24:3: error: use of undeclared identifier '_GET_LDBG_MACRO'
|
| From
| # reset_artifacts:
| -10
| # true:
| 0
| # build_llvm -- clang;lld;flang;clang-tools-extra openmp :
| 1
Used configuration :
tcwg_flang_build/main-aarch64
We track this bug report under https://linaro.atlassian.net/browse/LLVM-1738. Please let us know if you have a fix.
If you have any questions regarding this report, please ask on linaro-toolchain(a)lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in
* https://ci.linaro.org/job/tcwg_flang_build--main-aarch64-build/5111/artifac…
The full lists of regressions and improvements as well as configure and make commands are in
* https://ci.linaro.org/job/tcwg_flang_build--main-aarch64-build/5111/artifac…
Current build : https://ci.linaro.org/job/tcwg_flang_build--main-aarch64-build/5111/artifac…
Reference build : https://ci.linaro.org/job/tcwg_flang_build--main-aarch64-build/5108/artifac…
Instruction to reproduce the build : https://gitlab.com/Linaro/tcwg/ci/interesting-commits/-/raw/master/llvm/sha…
Full commit : https://github.com/llvm/llvm-project/commit/a15b629527a975ec592c95d69d04ef3…
Dear Linaro Community,
I am looking for advice on how to reproduce a flang-arm64-windows-msvc LLVM build bot failure (hopefully I ended up in the right place here).
I had to revert an LLVM PR (https://github.com/llvm/llvm-project/pull/150783) that broke the flang-arm64-windows-msvc LLVM buildbot yesterday due to some tablegen-related problem. I did prepare a reland PR (https://github.com/llvm/llvm-project/pull/151125) that addresses a potential issue. However, since I did not see any other buildbot failures and since I was not able to reproduce the problem locally, I wonder if there is a way to run the flang-arm64-windows-msvc buildbot on my reland PR? Alternatively, hints on how to reproduce the problem locally on a x86 Linux machine would be appreciated.
Best,
Tobias
Hello Tom,
ci_notify(a)linaro.org writes:
> Dear contributor,
>
> Our automatic CI has detected problems related to your patch(es). Please find some details
> below.
>
> In gdb_check master-arm, after:
> | 9 patches in gdb
> | Patchwork URL: https://patchwork.sourceware.org/patch/117104
> | 02107b8252d [PATCH 9/9] [gdb/testsuite] Add gdb.tui/tui-mode-switch.exp
> | 74b2f1eb572 [PATCH 8/9] [gdb/testsuite] Add Term::with_term
> | 6f3e219e902 [PATCH 7/9] [gdb/testsuite] Add Term::_esc_0x3d and Term::_esc_0x3e
> | 9d1466d5f3f [PATCH 6/9] [gdb/testsuite] Add Term::_esc_0x28_B and Term::_esc_0x28_0
> | 2c51f81639a [PATCH 5/9] [gdb/testsuite] Add Term::_csi_r
> | ... and 4 more patches in gdb
> | ... applied on top of baseline commit:
> | 0937ed3f050 Add forgotten ChangeLog entry for commit
> | 7c1c13e896c76879bcf3fb29332e0a59918bc9e0.
>
> Produces 23 regressions 3 fixes:
<snip>
> Current build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-precommit/5001/artifac…
> Reference build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-build/3017/artifact/ar…
This is a false positive. We're currently moving our CI jobs to another
machine (of a different kind, even) and the reference build ran on the
new machine while the build with the patches ran on the old one. Sorry
for the noise.
--
Thiago
Hello Tom,
ci_notify(a)linaro.org writes:
> In gdb_check master-arm, after:
> | 3 patches in gdb
> | Patchwork URL: https://patchwork.sourceware.org/patch/117137
> | a05322508b7 [PATCH 3/3] Require Tcl 8.6.2
> | 2b7dc482e23 [PATCH 2/3] Rewrite tcl_version_at_least
> | a88c3d9f501 [PATCH 1/3] Require Tcl 8.5
> | ... applied on top of baseline commit:
> | 0937ed3f050 Add forgotten ChangeLog entry for commit
> | 7c1c13e896c76879bcf3fb29332e0a59918bc9e0.
>
> Produces 23 regressions 3 fixes:
<snip>
> Current build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-precommit/5004/artifac…
> Reference build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-build/3017/artifact/ar…
This is a false positive. We're currently moving our CI jobs to another
machine (of a different kind, even) and the reference build ran on the
new machine while the build with the patches ran on the old one. The
same happened with the other patch about which we notified you today.
Sorry for the noise.
--
Thiago
Hello,
ci_notify(a)linaro.org writes:
> In gdb_check master-arm, after:
> | gdb patch https://patchwork.sourceware.org/patch/117052
> | Author: Aria Nolan <aria(a)chytrid.org>
> | Date: Sat Jul 26 18:44:40 2025 -0600
> |
> | [PATCH] gdb: turn off completions for the inferior command
> |
> | The inferior command takes an inferior ID as an argument. The current
> | completer for the command offers symbols. This patch removes the completion,
> | since the IDs are sequential so it makes little sense to offer that.
> | ... 2 lines of the commit log omitted.
> | ... applied on top of baseline commit:
> | 0937ed3f050 Add forgotten ChangeLog entry for commit
> | 7c1c13e896c76879bcf3fb29332e0a59918bc9e0.
>
> Produces 23 regressions 3 fixes:
<snip>
> Current build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-precommit/5000/artifac…
> Reference build :
> https://ci.linaro.org/job/tcwg_gdb_check--master-arm-build/3017/artifact/ar…
This is a false positive. We're currently moving our CI jobs to another
machine (of a different kind, even) and the reference build ran on the
new machine while the build with the patch ran on the old one. Sorry for
the noise.
--
Thiago