--- Hi,
Can you review this patch for me and help me get it upstream?
This is an official request for help from LEG to the TCWG, if that matters :-)
Cheers, mwh
libatomic/configure.tgt | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index b9e5d6c..7eaab38 100644 --- a/libatomic/configure.tgt +++ b/libatomic/configure.tgt @@ -95,11 +95,6 @@ fi
# Other system configury case "${target}" in - aarch64*) - # This is currently not supported in AArch64. - UNSUPPORTED=1 - ;; - arm*-*-linux*) # OS support for atomic primitives. config_path="${config_path} linux/arm posix"
This is the same patch which we (Cavium) uses internally if that matters.
Thanks, Andrew
Sent from my iPad
On Oct 1, 2013, at 6:52 PM, "Michael Hudson-Doyle" michael.hudson@linaro.org wrote:
Hi,
Can you review this patch for me and help me get it upstream?
This is an official request for help from LEG to the TCWG, if that matters :-)
Cheers, mwh
libatomic/configure.tgt | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index b9e5d6c..7eaab38 100644 --- a/libatomic/configure.tgt +++ b/libatomic/configure.tgt @@ -95,11 +95,6 @@ fi
# Other system configury case "${target}" in
- aarch64*)
- # This is currently not supported in AArch64.
- UNSUPPORTED=1
- ;;
- arm*-*-linux*) # OS support for atomic primitives. config_path="${config_path} linux/arm posix"
-- 1.8.1.2
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
Hi Michael,
The patch seems good to me. I think you can post it on the mailing list for upstream review at gcc-patches@gcc.gnu.org with the AArch64 port maintainers in CC (richard.earnshaw@arm.com and marcus.shawcroft@arm.com), and just add the testsuite results of the lib in your mail, and the ChangeLog entry, something like :
2013-10-02 Michael Hudson-Doyle michael.hudson@linaro.org
* configure.tgt: Add AArch64 support.
Thanks, Yvan
On 2 October 2013 03:53, Pinski, Andrew Andrew.Pinski@caviumnetworks.com wrote:
This is the same patch which we (Cavium) uses internally if that matters.
Thanks, Andrew
Sent from my iPad
On Oct 1, 2013, at 6:52 PM, "Michael Hudson-Doyle" michael.hudson@linaro.org wrote:
Hi,
Can you review this patch for me and help me get it upstream?
This is an official request for help from LEG to the TCWG, if that matters :-)
Cheers, mwh
libatomic/configure.tgt | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index b9e5d6c..7eaab38 100644 --- a/libatomic/configure.tgt +++ b/libatomic/configure.tgt @@ -95,11 +95,6 @@ fi
# Other system configury case "${target}" in
- aarch64*)
- # This is currently not supported in AArch64.
- UNSUPPORTED=1
- ;;
- arm*-*-linux*) # OS support for atomic primitives. config_path="${config_path} linux/arm posix"
-- 1.8.1.2
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
Hi Yvan,
Thanks for the reply!
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
The patch seems good to me. I think you can post it on the mailing list for upstream review at gcc-patches@gcc.gnu.org with the AArch64 port maintainers in CC (richard.earnshaw@arm.com and marcus.shawcroft@arm.com), and just add the testsuite results of the lib in your mail,
Ah yes, tests. Here's what I've done:
1) I followed these instructions:
https://wiki.linaro.org/WorkingGroups/ToolChain/BuildingGNUToolchains
2) I started a foundation model and copied "aarch64-unknown-linux-gnu/libatomic/.libs/libatomic.so*" from the build2 tree to /lib on the model (is there some automagic way of doing this bit?)
3) I ran
$ PATH=$TOOLS_PATH/bin:$PATH DEJAGNU="/home/mwhudson/aarch64-none-linux-gnu-foundation.exp" make check-target-libatomic AM_RUNTESTFLAGS=--verbose > runtest-log-v-2.txt 2>&1
I'm attaching the output file, but this bit looks promising:
=== libatomic Summary ===
# of expected passes 34 # of unsupported tests 10 runtest completed at Thu Oct 3 10:25:57 2013
If you (or anyone else on the list) can sanity check the above, I'll send it off to gcc-patches tomorrow.
Cheers, mwh
make[1]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' Making check in testsuite make[2]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make check-DEJAGNU make[3]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd ../../../../gcc/libatomic/testsuite && pwd`; export srcdir; \ EXPECT=expect; export EXPECT; \ runtest=runtest; \ if /bin/bash -c "$runtest --version" > /dev/null 2>&1; then \ exit_status=0; l='libatomic'; for tool in $l; do \ if $runtest --verbose --tool $tool --srcdir $srcdir ; \ then :; else exit_status=1; fi; \ done; \ else echo "WARNING: could not find `runtest'" 1>&2; :;\ fi; \ exit $exit_status Expect binary is expect Using /usr/share/dejagnu/runtest.exp as main test driver Verbose level is 1 Login name is mwhudson Found ~/.dejagnurc Found /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite/site.exp Found /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite/site.exp Using test sources in ../../../../gcc/libatomic/testsuite Using test binaries in /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite Tool root directory is /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu Using /usr/share/dejagnu to find libraries Found /usr/share/dejagnu/site.exp Found /home/mwhudson/aarch64-none-linux-gnu-foundation.exp Loading /usr/share/dejagnu/utils.exp Loading /usr/share/dejagnu/framework.exp Loading /usr/share/dejagnu/debugger.exp Loading /usr/share/dejagnu/remote.exp Loading /usr/share/dejagnu/telnet.exp Loading /usr/share/dejagnu/rlogin.exp Loading /usr/share/dejagnu/kermit.exp Loading /usr/share/dejagnu/tip.exp Loading /usr/share/dejagnu/rsh.exp Loading /usr/share/dejagnu/ftp.exp Loading /usr/share/dejagnu/target.exp Loading /usr/share/dejagnu/targetdb.exp Loading /usr/share/dejagnu/libgloss.exp Loading library file ../../../../gcc/libatomic/testsuite/lib/libatomic.exp Loading /usr/share/dejagnu/dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/file-format.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-supports.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-supports-dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanasm.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scandump.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanrtl.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scantree.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanipa.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/prune.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-libpath.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/wrapper.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/gcc-defs.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/torture-options.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/timeout.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/timeout-dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/fortran-modules.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp set_ld_library_path_env_vars: ld_library_path= compiler is /home/mwhudson/work/gcc/build2/gcc/xgcc GCC path is . Testing libatomic Opening log files in . Test Run By mwhudson on Thu Oct 3 10:16:20 2013 Target is aarch64-unknown-linux-gnu Host is aarch64-unknown-linux-gnu Build is x86_64-unknown-linux-gnu
=== libatomic tests ===
setting trap for SIGTERM to terminated setting trap for SIGINT to interrupted by user setting trap for SIGQUIT to interrupted by user dirlist is /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards pushing config for build, name is narsil dirlist is /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards pushing config for host, name is narsil target list is "aarch64-linux" Schedule of variations: aarch64-linux
target is aarch64-linux Running target aarch64-linux dirlist is /home/mwhudson/tmp/boards/narsil /usr/share/dejagnu/baseboards/narsil /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards Using /home/mwhudson/tmp/boards/aarch64-linux.exp as board description file for target. Using /usr/share/dejagnu/config/unix.exp as generic interface file for target. Using /home/mwhudson/work/gcc/gcc/libatomic/testsuite/config/default.exp as tool-and-target-specific interface file. Loading /usr/share/dejagnu/standard.exp pushing config for target, name is aarch64-linux Running /home/mwhudson/work/gcc/gcc/libatomic/testsuite/libatomic.c/c.exp ... compiler is /home/mwhudson/work/gcc/build2/gcc/xgcc GCC path is . Loading /home/mwhudson/work/gcc/gcc/libatomic/testsuite/lib/libatomic-dg.exp Testing libatomic.c/atomic-compare-exchange-1.c doing compile pid is 8525 -8525 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-1.exe.8494 < pid is 8556 8557 -8556 -8557 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-1.exe.8494 < pid is 8563 8564 -8563 -8564 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-1.exe.8494.o /tmp/atomic-compare-exchange-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-1.exe.8494.o /tmp/atomic-compare-exchange-1.exe.8494 < pid is 8566 8567 -8566 -8567 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-2.c doing compile pid is 8571 -8571 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-2.exe.8494 < pid is 8594 8595 -8594 -8595 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-2.exe.8494 < pid is 8597 8598 -8597 -8598 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-2.exe.8494.o /tmp/atomic-compare-exchange-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-2.exe.8494.o /tmp/atomic-compare-exchange-2.exe.8494 < pid is 8600 8601 -8600 -8601 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-3.c doing compile pid is 8604 -8604 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-3.exe.8494 < pid is 8621 8622 -8621 -8622 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-3.exe.8494 < pid is 8624 8625 -8624 -8625 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-3.exe.8494.o /tmp/atomic-compare-exchange-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-3.exe.8494.o /tmp/atomic-compare-exchange-3.exe.8494 < pid is 8628 8629 -8628 -8629 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-4.c Testing libatomic.c/atomic-compare-exchange-5.c Testing libatomic.c/atomic-exchange-1.c doing compile pid is 8635 -8635 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-1.exe.8494 < pid is 8651 8652 -8651 -8652 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-1.exe.8494 < pid is 8654 8655 -8654 -8655 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-1.exe.8494.o /tmp/atomic-exchange-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-1.exe.8494.o /tmp/atomic-exchange-1.exe.8494 < pid is 8658 8659 -8658 -8659 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-2.c doing compile pid is 8662 -8662 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-2.exe.8494 < pid is 8681 8682 -8681 -8682 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-2.exe.8494 < pid is 8699 8700 -8699 -8700 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-2.exe.8494.o /tmp/atomic-exchange-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-2.exe.8494.o /tmp/atomic-exchange-2.exe.8494 < pid is 8704 8705 -8704 -8705 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-3.c doing compile pid is 8708 -8708 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-3.exe.8494 < pid is 8724 8725 -8724 -8725 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-3.exe.8494 < pid is 8727 8728 -8727 -8728 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-3.exe.8494.o /tmp/atomic-exchange-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-3.exe.8494.o /tmp/atomic-exchange-3.exe.8494 < pid is 8730 8731 -8730 -8731 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-4.c Testing libatomic.c/atomic-exchange-5.c Testing libatomic.c/atomic-generic.c doing compile pid is 8735 -8735 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-generic.exe.8494 < pid is 8752 8753 -8752 -8753 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-generic.exe.8494 < pid is 8757 8758 -8757 -8758 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-generic.exe.8494.o /tmp/atomic-generic.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-generic.exe.8494.o /tmp/atomic-generic.exe.8494 < pid is 8776 8777 -8776 -8777 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-1.c doing compile pid is 8803 -8803 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-1.exe.8494 < pid is 8819 8820 -8819 -8820 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-1.exe.8494 < pid is 8822 8823 -8822 -8823 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-1.exe.8494.o /tmp/atomic-load-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-1.exe.8494.o /tmp/atomic-load-1.exe.8494 < pid is 8837 8838 -8837 -8838 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-2.c doing compile pid is 8843 -8843 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-2.exe.8494 < pid is 8863 8864 -8863 -8864 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-2.exe.8494 < pid is 8870 8871 -8870 -8871 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-2.exe.8494.o /tmp/atomic-load-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-2.exe.8494.o /tmp/atomic-load-2.exe.8494 < pid is 8874 8875 -8874 -8875 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-3.c doing compile pid is 8878 -8878 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-3.exe.8494 < pid is 8898 8899 -8898 -8899 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-3.exe.8494 < pid is 8901 8902 -8901 -8902 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-3.exe.8494.o /tmp/atomic-load-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-3.exe.8494.o /tmp/atomic-load-3.exe.8494 < pid is 8905 8906 -8905 -8906 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-4.c Testing libatomic.c/atomic-load-5.c Testing libatomic.c/atomic-op-1.c doing compile pid is 8911 -8911 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-1.exe.8494 < pid is 8955 8956 -8955 -8956 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-1.exe.8494 < pid is 8958 8959 -8958 -8959 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-1.exe.8494.o /tmp/atomic-op-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-1.exe.8494.o /tmp/atomic-op-1.exe.8494 < pid is 8961 8962 -8961 -8962 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-2.c doing compile pid is 8966 -8966 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-2.exe.8494 < pid is 8985 8986 -8985 -8986 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-2.exe.8494 < pid is 8991 8992 -8991 -8992 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-2.exe.8494.o /tmp/atomic-op-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-2.exe.8494.o /tmp/atomic-op-2.exe.8494 < pid is 8996 8997 -8996 -8997 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-3.c doing compile pid is 9001 -9001 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-3.exe.8494 < pid is 9017 9018 -9017 -9018 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-3.exe.8494 < pid is 9023 9024 -9023 -9024 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-3.exe.8494.o /tmp/atomic-op-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-3.exe.8494.o /tmp/atomic-op-3.exe.8494 < pid is 9026 9027 -9026 -9027 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-4.c Testing libatomic.c/atomic-op-5.c Testing libatomic.c/atomic-store-1.c doing compile pid is 9030 -9030 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-1.exe.8494 < pid is 9046 9047 -9046 -9047 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-1.exe.8494 < pid is 9054 9055 -9054 -9055 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-1.exe.8494.o /tmp/atomic-store-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-1.exe.8494.o /tmp/atomic-store-1.exe.8494 < pid is 9057 9058 -9057 -9058 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-2.c doing compile pid is 9061 -9061 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-2.exe.8494 < pid is 9083 9084 -9083 -9084 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-2.exe.8494 < pid is 9086 9087 -9086 -9087 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-2.exe.8494.o /tmp/atomic-store-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-2.exe.8494.o /tmp/atomic-store-2.exe.8494 < pid is 9093 9094 -9093 -9094 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-3.c doing compile pid is 9103 -9103 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-3.exe.8494 < pid is 9122 9123 -9122 -9123 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-3.exe.8494 < pid is 9125 9126 -9125 -9126 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-3.exe.8494.o /tmp/atomic-store-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-3.exe.8494.o /tmp/atomic-store-3.exe.8494 < pid is 9128 9129 -9128 -9129 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-4.c Testing libatomic.c/atomic-store-5.c Testing libatomic.c/generic-2.c doing compile pid is 9132 -9132 output is status 0 Executing aarch64-linux:chmod +x /tmp/generic-2.exe.8494 < pid is 9148 9149 -9148 -9149 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/generic-2.exe.8494 < pid is 9151 9152 -9151 -9152 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/generic-2.exe.8494.o /tmp/generic-2.exe.8494 Executing aarch64-linux:rm -f /tmp/generic-2.exe.8494.o /tmp/generic-2.exe.8494 < pid is 9154 9155 -9154 -9155 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
=== libatomic Summary ===
# of expected passes 34 # of unsupported tests 10 runtest completed at Thu Oct 3 10:25:57 2013 make[3]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make[2]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make[2]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make DO=all multi-do # make make[3]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' if [ -z "" ]; then \ true; \ else \ rootpre=`${PWDCMD-pwd}`/; export rootpre; \ srcrootpre=`cd ../../../gcc/libatomic; ${PWDCMD-pwd}`/; export srcrootpre; \ lib=`echo "${rootpre}" | sed -e 's,^.*/([^/][^/]*)/$,\1,'`; \ compiler="/home/mwhudson/work/gcc/build2/./gcc/xgcc -B/home/mwhudson/work/gcc/build2/./gcc/ -B/home/mwhudson/tools/aarch64-unknown-linux-gnu/bin/ -B/home/mwhudson/tools/aarch64-unknown-linux-gnu/lib/ -isystem /home/mwhudson/tools/aarch64-unknown-linux-gnu/include -isystem /home/mwhudson/tools/aarch64-unknown-linux-gnu/sys-include "; \ for i in `${compiler} --print-multi-lib 2>/dev/null`; do \ dir=`echo $i | sed -e 's/;.*$//'`; \ if [ "${dir}" = "." ]; then \ true; \ else \ if [ -d ../${dir}/${lib} ]; then \ flags=`echo $i | sed -e 's/^[^;]*;//' -e 's/@/ -/g'`; \ if (cd ../${dir}/${lib}; make \ CFLAGS="-g -O2 ${flags}" \ CCASFLAGS="-g -O2 ${flags}" \ FCFLAGS=" ${flags}" \ FFLAGS=" ${flags}" \ ADAFLAGS=" ${flags}" \ prefix="/home/mwhudson/tools" \ exec_prefix="/home/mwhudson/tools" \ GCJFLAGS=" ${flags}" \ GOCFLAGS="-O2 -g ${flags}" \ CXXFLAGS="-g -O2 -D_GNU_SOURCE ${flags}" \ LIBCFLAGS="-g -O2 ${flags}" \ LIBCXXFLAGS="-g -O2 -D_GNU_SOURCE -fno-implicit-templates ${flags}" \ LDFLAGS=" ${flags}" \ MULTIFLAGS="${flags}" \ DESTDIR="" \ INSTALL="/usr/bin/install -c" \ INSTALL_DATA="/usr/bin/install -c -m 644" \ INSTALL_PROGRAM="/usr/bin/install -c" \ INSTALL_SCRIPT="/usr/bin/install -c" \ all); then \ true; \ else \ exit 1; \ fi; \ else true; \ fi; \ fi; \ done; \ fi make[3]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make[2]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make[1]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic'
and the ChangeLog entry, something like :
2013-10-02 Michael Hudson-Doyle michael.hudson@linaro.org
* configure.tgt: Add AArch64 support.
Thanks, Yvan
On 2 October 2013 03:53, Pinski, Andrew Andrew.Pinski@caviumnetworks.com wrote:
This is the same patch which we (Cavium) uses internally if that matters.
Thanks, Andrew
Sent from my iPad
On Oct 1, 2013, at 6:52 PM, "Michael Hudson-Doyle" michael.hudson@linaro.org wrote:
Hi,
Can you review this patch for me and help me get it upstream?
This is an official request for help from LEG to the TCWG, if that matters :-)
Cheers, mwh
libatomic/configure.tgt | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index b9e5d6c..7eaab38 100644 --- a/libatomic/configure.tgt +++ b/libatomic/configure.tgt @@ -95,11 +95,6 @@ fi
# Other system configury case "${target}" in
- aarch64*)
- # This is currently not supported in AArch64.
- UNSUPPORTED=1
- ;;
- arm*-*-linux*) # OS support for atomic primitives. config_path="${config_path} linux/arm posix"
-- 1.8.1.2
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
On 2 October 2013 23:32, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Hi Yvan,
Thanks for the reply!
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
The patch seems good to me. I think you can post it on the mailing list for upstream review at gcc-patches@gcc.gnu.org with the AArch64 port maintainers in CC (richard.earnshaw@arm.com and marcus.shawcroft@arm.com), and just add the testsuite results of the lib in your mail,
Ah yes, tests. Here's what I've done:
I followed these instructions:
https://wiki.linaro.org/WorkingGroups/ToolChain/BuildingGNUToolchains
I started a foundation model and copied "aarch64-unknown-linux-gnu/libatomic/.libs/libatomic.so*" from the build2 tree to /lib on the model (is there some automagic way of doing this bit?)
I ran
$ PATH=$TOOLS_PATH/bin:$PATH DEJAGNU="/home/mwhudson/aarch64-none-linux-gnu-foundation.exp" make check-target-libatomic AM_RUNTESTFLAGS=--verbose > runtest-log-v-2.txt 2>&1
I'm attaching the output file, but this bit looks promising:
=== libatomic Summary ===
# of expected passes 34 # of unsupported tests 10 runtest completed at Thu Oct 3 10:25:57 2013
If you (or anyone else on the list) can sanity check the above, I'll send it off to gcc-patches tomorrow.
Cheers, mwh
make[1]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' Making check in testsuite make[2]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make check-DEJAGNU make[3]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd ../../../../gcc/libatomic/testsuite && pwd`; export srcdir; \ EXPECT=expect; export EXPECT; \ runtest=runtest; \ if /bin/bash -c "$runtest --version" > /dev/null 2>&1; then \ exit_status=0; l='libatomic'; for tool in $l; do \ if $runtest --verbose --tool $tool --srcdir $srcdir ; \ then :; else exit_status=1; fi; \ done; \ else echo "WARNING: could not find `runtest'" 1>&2; :;\ fi; \ exit $exit_status Expect binary is expect Using /usr/share/dejagnu/runtest.exp as main test driver Verbose level is 1 Login name is mwhudson Found ~/.dejagnurc Found /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite/site.exp Found /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite/site.exp Using test sources in ../../../../gcc/libatomic/testsuite Using test binaries in /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite Tool root directory is /home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu Using /usr/share/dejagnu to find libraries Found /usr/share/dejagnu/site.exp Found /home/mwhudson/aarch64-none-linux-gnu-foundation.exp Loading /usr/share/dejagnu/utils.exp Loading /usr/share/dejagnu/framework.exp Loading /usr/share/dejagnu/debugger.exp Loading /usr/share/dejagnu/remote.exp Loading /usr/share/dejagnu/telnet.exp Loading /usr/share/dejagnu/rlogin.exp Loading /usr/share/dejagnu/kermit.exp Loading /usr/share/dejagnu/tip.exp Loading /usr/share/dejagnu/rsh.exp Loading /usr/share/dejagnu/ftp.exp Loading /usr/share/dejagnu/target.exp Loading /usr/share/dejagnu/targetdb.exp Loading /usr/share/dejagnu/libgloss.exp Loading library file ../../../../gcc/libatomic/testsuite/lib/libatomic.exp Loading /usr/share/dejagnu/dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/file-format.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-supports.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-supports-dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanasm.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scandump.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanrtl.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scantree.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/scanipa.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/prune.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/target-libpath.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/wrapper.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/gcc-defs.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/torture-options.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/timeout.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/timeout-dg.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/fortran-modules.exp Found ../../../../gcc/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp set_ld_library_path_env_vars: ld_library_path= compiler is /home/mwhudson/work/gcc/build2/gcc/xgcc GCC path is . Testing libatomic Opening log files in . Test Run By mwhudson on Thu Oct 3 10:16:20 2013 Target is aarch64-unknown-linux-gnu Host is aarch64-unknown-linux-gnu Build is x86_64-unknown-linux-gnu
=== libatomic tests ===
setting trap for SIGTERM to terminated setting trap for SIGINT to interrupted by user setting trap for SIGQUIT to interrupted by user dirlist is /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards pushing config for build, name is narsil dirlist is /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards pushing config for host, name is narsil target list is "aarch64-linux" Schedule of variations: aarch64-linux
target is aarch64-linux Running target aarch64-linux dirlist is /home/mwhudson/tmp/boards/narsil /usr/share/dejagnu/baseboards/narsil /home/mwhudson/tmp/boards /usr/share/dejagnu/baseboards Using /home/mwhudson/tmp/boards/aarch64-linux.exp as board description file for target. Using /usr/share/dejagnu/config/unix.exp as generic interface file for target. Using /home/mwhudson/work/gcc/gcc/libatomic/testsuite/config/default.exp as tool-and-target-specific interface file. Loading /usr/share/dejagnu/standard.exp pushing config for target, name is aarch64-linux Running /home/mwhudson/work/gcc/gcc/libatomic/testsuite/libatomic.c/c.exp ... compiler is /home/mwhudson/work/gcc/build2/gcc/xgcc GCC path is . Loading /home/mwhudson/work/gcc/gcc/libatomic/testsuite/lib/libatomic-dg.exp Testing libatomic.c/atomic-compare-exchange-1.c doing compile pid is 8525 -8525 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-1.exe.8494 < pid is 8556 8557 -8556 -8557 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-1.exe.8494 < pid is 8563 8564 -8563 -8564 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-1.exe.8494.o /tmp/atomic-compare-exchange-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-1.exe.8494.o /tmp/atomic-compare-exchange-1.exe.8494 < pid is 8566 8567 -8566 -8567 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-2.c doing compile pid is 8571 -8571 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-2.exe.8494 < pid is 8594 8595 -8594 -8595 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-2.exe.8494 < pid is 8597 8598 -8597 -8598 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-2.exe.8494.o /tmp/atomic-compare-exchange-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-2.exe.8494.o /tmp/atomic-compare-exchange-2.exe.8494 < pid is 8600 8601 -8600 -8601 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-3.c doing compile pid is 8604 -8604 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-compare-exchange-3.exe.8494 < pid is 8621 8622 -8621 -8622 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-compare-exchange-3.exe.8494 < pid is 8624 8625 -8624 -8625 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-compare-exchange-3.exe.8494.o /tmp/atomic-compare-exchange-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-compare-exchange-3.exe.8494.o /tmp/atomic-compare-exchange-3.exe.8494 < pid is 8628 8629 -8628 -8629 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-compare-exchange-4.c Testing libatomic.c/atomic-compare-exchange-5.c Testing libatomic.c/atomic-exchange-1.c doing compile pid is 8635 -8635 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-1.exe.8494 < pid is 8651 8652 -8651 -8652 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-1.exe.8494 < pid is 8654 8655 -8654 -8655 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-1.exe.8494.o /tmp/atomic-exchange-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-1.exe.8494.o /tmp/atomic-exchange-1.exe.8494 < pid is 8658 8659 -8658 -8659 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-2.c doing compile pid is 8662 -8662 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-2.exe.8494 < pid is 8681 8682 -8681 -8682 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-2.exe.8494 < pid is 8699 8700 -8699 -8700 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-2.exe.8494.o /tmp/atomic-exchange-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-2.exe.8494.o /tmp/atomic-exchange-2.exe.8494 < pid is 8704 8705 -8704 -8705 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-3.c doing compile pid is 8708 -8708 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-exchange-3.exe.8494 < pid is 8724 8725 -8724 -8725 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-exchange-3.exe.8494 < pid is 8727 8728 -8727 -8728 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-exchange-3.exe.8494.o /tmp/atomic-exchange-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-exchange-3.exe.8494.o /tmp/atomic-exchange-3.exe.8494 < pid is 8730 8731 -8730 -8731 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-exchange-4.c Testing libatomic.c/atomic-exchange-5.c Testing libatomic.c/atomic-generic.c doing compile pid is 8735 -8735 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-generic.exe.8494 < pid is 8752 8753 -8752 -8753 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-generic.exe.8494 < pid is 8757 8758 -8757 -8758 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-generic.exe.8494.o /tmp/atomic-generic.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-generic.exe.8494.o /tmp/atomic-generic.exe.8494 < pid is 8776 8777 -8776 -8777 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-1.c doing compile pid is 8803 -8803 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-1.exe.8494 < pid is 8819 8820 -8819 -8820 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-1.exe.8494 < pid is 8822 8823 -8822 -8823 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-1.exe.8494.o /tmp/atomic-load-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-1.exe.8494.o /tmp/atomic-load-1.exe.8494 < pid is 8837 8838 -8837 -8838 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-2.c doing compile pid is 8843 -8843 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-2.exe.8494 < pid is 8863 8864 -8863 -8864 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-2.exe.8494 < pid is 8870 8871 -8870 -8871 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-2.exe.8494.o /tmp/atomic-load-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-2.exe.8494.o /tmp/atomic-load-2.exe.8494 < pid is 8874 8875 -8874 -8875 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-3.c doing compile pid is 8878 -8878 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-load-3.exe.8494 < pid is 8898 8899 -8898 -8899 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-load-3.exe.8494 < pid is 8901 8902 -8901 -8902 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-load-3.exe.8494.o /tmp/atomic-load-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-load-3.exe.8494.o /tmp/atomic-load-3.exe.8494 < pid is 8905 8906 -8905 -8906 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-load-4.c Testing libatomic.c/atomic-load-5.c Testing libatomic.c/atomic-op-1.c doing compile pid is 8911 -8911 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-1.exe.8494 < pid is 8955 8956 -8955 -8956 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-1.exe.8494 < pid is 8958 8959 -8958 -8959 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-1.exe.8494.o /tmp/atomic-op-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-1.exe.8494.o /tmp/atomic-op-1.exe.8494 < pid is 8961 8962 -8961 -8962 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-2.c doing compile pid is 8966 -8966 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-2.exe.8494 < pid is 8985 8986 -8985 -8986 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-2.exe.8494 < pid is 8991 8992 -8991 -8992 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-2.exe.8494.o /tmp/atomic-op-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-2.exe.8494.o /tmp/atomic-op-2.exe.8494 < pid is 8996 8997 -8996 -8997 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-3.c doing compile pid is 9001 -9001 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-op-3.exe.8494 < pid is 9017 9018 -9017 -9018 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-op-3.exe.8494 < pid is 9023 9024 -9023 -9024 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-op-3.exe.8494.o /tmp/atomic-op-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-op-3.exe.8494.o /tmp/atomic-op-3.exe.8494 < pid is 9026 9027 -9026 -9027 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-op-4.c Testing libatomic.c/atomic-op-5.c Testing libatomic.c/atomic-store-1.c doing compile pid is 9030 -9030 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-1.exe.8494 < pid is 9046 9047 -9046 -9047 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-1.exe.8494 < pid is 9054 9055 -9054 -9055 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-1.exe.8494.o /tmp/atomic-store-1.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-1.exe.8494.o /tmp/atomic-store-1.exe.8494 < pid is 9057 9058 -9057 -9058 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-2.c doing compile pid is 9061 -9061 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-2.exe.8494 < pid is 9083 9084 -9083 -9084 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-2.exe.8494 < pid is 9086 9087 -9086 -9087 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-2.exe.8494.o /tmp/atomic-store-2.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-2.exe.8494.o /tmp/atomic-store-2.exe.8494 < pid is 9093 9094 -9093 -9094 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-3.c doing compile pid is 9103 -9103 output is status 0 Executing aarch64-linux:chmod +x /tmp/atomic-store-3.exe.8494 < pid is 9122 9123 -9122 -9123 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/atomic-store-3.exe.8494 < pid is 9125 9126 -9125 -9126 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/atomic-store-3.exe.8494.o /tmp/atomic-store-3.exe.8494 Executing aarch64-linux:rm -f /tmp/atomic-store-3.exe.8494.o /tmp/atomic-store-3.exe.8494 < pid is 9128 9129 -9128 -9129 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Testing libatomic.c/atomic-store-4.c Testing libatomic.c/atomic-store-5.c Testing libatomic.c/generic-2.c doing compile pid is 9132 -9132 output is status 0 Executing aarch64-linux:chmod +x /tmp/generic-2.exe.8494 < pid is 9148 9149 -9148 -9149 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
Executing aarch64-linux:/tmp/generic-2.exe.8494 < pid is 9151 9152 -9151 -9152 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
remote_file deleting /tmp/generic-2.exe.8494.o /tmp/generic-2.exe.8494 Executing aarch64-linux:rm -f /tmp/generic-2.exe.8494.o /tmp/generic-2.exe.8494 < pid is 9154 9155 -9154 -9155 output is XYZ0ZYX status 0 /usr/bin/ssh -p 8022 status is 0, output is XYZ0ZYX
=== libatomic Summary ===
# of expected passes 34 # of unsupported tests 10 runtest completed at Thu Oct 3 10:25:57 2013 make[3]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make[2]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic/testsuite' make[2]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make DO=all multi-do # make make[3]: Entering directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' if [ -z "" ]; then \ true; \ else \ rootpre=`${PWDCMD-pwd}`/; export rootpre; \ srcrootpre=`cd ../../../gcc/libatomic; ${PWDCMD-pwd}`/; export srcrootpre; \ lib=`echo "${rootpre}" | sed -e 's,^.*/([^/][^/]*)/$,\1,'`; \ compiler="/home/mwhudson/work/gcc/build2/./gcc/xgcc -B/home/mwhudson/work/gcc/build2/./gcc/ -B/home/mwhudson/tools/aarch64-unknown-linux-gnu/bin/ -B/home/mwhudson/tools/aarch64-unknown-linux-gnu/lib/ -isystem /home/mwhudson/tools/aarch64-unknown-linux-gnu/include -isystem /home/mwhudson/tools/aarch64-unknown-linux-gnu/sys-include "; \ for i in `${compiler} --print-multi-lib 2>/dev/null`; do \ dir=`echo $i | sed -e 's/;.*$//'`; \ if [ "${dir}" = "." ]; then \ true; \ else \ if [ -d ../${dir}/${lib} ]; then \ flags=`echo $i | sed -e 's/^[^;]*;//' -e 's/@/ -/g'`; \ if (cd ../${dir}/${lib}; make \ CFLAGS="-g -O2 ${flags}" \ CCASFLAGS="-g -O2 ${flags}" \ FCFLAGS=" ${flags}" \ FFLAGS=" ${flags}" \ ADAFLAGS=" ${flags}" \ prefix="/home/mwhudson/tools" \ exec_prefix="/home/mwhudson/tools" \ GCJFLAGS=" ${flags}" \ GOCFLAGS="-O2 -g ${flags}" \ CXXFLAGS="-g -O2 -D_GNU_SOURCE ${flags}" \ LIBCFLAGS="-g -O2 ${flags}" \ LIBCXXFLAGS="-g -O2 -D_GNU_SOURCE -fno-implicit-templates ${flags}" \ LDFLAGS=" ${flags}" \ MULTIFLAGS="${flags}" \ DESTDIR="" \ INSTALL="/usr/bin/install -c" \ INSTALL_DATA="/usr/bin/install -c -m 644" \ INSTALL_PROGRAM="/usr/bin/install -c" \ INSTALL_SCRIPT="/usr/bin/install -c" \ all); then \ true; \ else \ exit 1; \ fi; \ else true; \ fi; \ fi; \ done; \ fi make[3]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make[2]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic' make[1]: Leaving directory `/home/mwhudson/work/gcc/build2/aarch64-unknown-linux-gnu/libatomic'
and the ChangeLog entry, something like :
2013-10-02 Michael Hudson-Doyle michael.hudson@linaro.org
* configure.tgt: Add AArch64 support.
Thanks, Yvan
On 2 October 2013 03:53, Pinski, Andrew Andrew.Pinski@caviumnetworks.com wrote:
This is the same patch which we (Cavium) uses internally if that matters.
Thanks, Andrew
Sent from my iPad
On Oct 1, 2013, at 6:52 PM, "Michael Hudson-Doyle" michael.hudson@linaro.org wrote:
Hi,
Can you review this patch for me and help me get it upstream?
This is an official request for help from LEG to the TCWG, if that matters :-)
Cheers, mwh
libatomic/configure.tgt | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index b9e5d6c..7eaab38 100644 --- a/libatomic/configure.tgt +++ b/libatomic/configure.tgt @@ -95,11 +95,6 @@ fi
# Other system configury case "${target}" in
- aarch64*)
- # This is currently not supported in AArch64.
- UNSUPPORTED=1
- ;;
- arm*-*-linux*) # OS support for atomic primitives. config_path="${config_path} linux/arm posix"
-- 1.8.1.2
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
linaro-toolchain mailing list linaro-toolchain@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-toolchain
Thanks, I've just posted it to gcc-patches.
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
[...]
Michael, Yvan,
Michael - thanks for posting upstream.
Yvan can you do the commit on Michael's behalf as and when it gets approved?
Thanks,
Matt
On 3 October 2013 23:45, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Thanks, I've just posted it to gcc-patches.
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
Yes, no problem.
Yvan
On 4 October 2013 10:56, Matthew Gretton-Dann matthew.gretton-dann@linaro.org wrote:
Michael, Yvan,
Michael - thanks for posting upstream.
Yvan can you do the commit on Michael's behalf as and when it gets approved?
Thanks,
Matt
On 3 October 2013 23:45, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Thanks, I've just posted it to gcc-patches.
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
-- Matthew Gretton-Dann Linaro Toolchain Working Group matthew.gretton-dann@linaro.org
Hello again,
My patch has been committed to trunk now (in two parts, r203773, and r203774). Is it appropriate to ask for this to be backported to the linaro branch? If so can you do it? Apologies if this would have happened anyway without the pestering...
Cheers, mwh
Yvan Roux yvan.roux@linaro.org writes:
Yes, no problem.
Yvan
On 4 October 2013 10:56, Matthew Gretton-Dann matthew.gretton-dann@linaro.org wrote:
Michael, Yvan,
Michael - thanks for posting upstream.
Yvan can you do the commit on Michael's behalf as and when it gets approved?
Thanks,
Matt
On 3 October 2013 23:45, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Thanks, I've just posted it to gcc-patches.
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
-- Matthew Gretton-Dann Linaro Toolchain Working Group matthew.gretton-dann@linaro.org
Michael,
So you've made the request now :-). It has technically missed the deadline for the 2013.11 release, but will be in the 2013.12 release.
Thanks,
Matt
On 20 October 2013 22:21, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Hello again,
My patch has been committed to trunk now (in two parts, r203773, and r203774). Is it appropriate to ask for this to be backported to the linaro branch? If so can you do it? Apologies if this would have happened anyway without the pestering...
Cheers, mwh
Yvan Roux yvan.roux@linaro.org writes:
Yes, no problem.
Yvan
On 4 October 2013 10:56, Matthew Gretton-Dann matthew.gretton-dann@linaro.org wrote:
Michael, Yvan,
Michael - thanks for posting upstream.
Yvan can you do the commit on Michael's behalf as and when it gets approved?
Thanks,
Matt
On 3 October 2013 23:45, Michael Hudson-Doyle michael.hudson@linaro.org wrote:
Thanks, I've just posted it to gcc-patches.
Yvan Roux yvan.roux@linaro.org writes:
Hi Michael,
If think it's ok for an upstreaming request.
Thanks, Yvan
-- Matthew Gretton-Dann Linaro Toolchain Working Group matthew.gretton-dann@linaro.org
linaro-toolchain@lists.linaro.org