Hi,
Florian Hahn and I landed 2 patches for fixing FindLastIV reductions idiom. https://github.com/llvm/llvm-project/commit/0e528ac404e13ed2d952a2d83aaf8383... https://github.com/llvm/llvm-project/commit/3397950f2d21426c7520d114a1258812... I think those can fix the issue you are facing. Please try them, and let me know if you still have regression on it.
Mel
On Fri, Dec 13, 2024 at 7:11 AM ci_notify@linaro.org wrote:
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In tcwg_flang_test/main-aarch64-Ofast-sve_vla, after: | commit llvmorg-20-init-15150-gb3cba9be41bf | Author: Mel Chen mel.chen@sifive.com | Date: Thu Dec 12 16:48:31 2024 +0800 | | [LoopVectorize] Vectorize select-cmp reduction pattern for increasing integer induction variable (#67812) | | Consider the following loop: | ``` | int rdx = init; | ... 12 lines of the commit log omitted.
Produces 2 regressions: | Running test-suite:Fujitsu/Fortran/0365 ... | FAIL: test-suite :: Fujitsu/Fortran/0365/Fujitsu-Fortran-0365_0185.test | FAIL: test-suite :: Fujitsu/Fortran/0365/Fujitsu-Fortran-0365_0186.test | # "FAIL" means : the execution of the compiled binary failed / output of the binary differs from the expected one
Used configuration :
- Toolchain : cmake -G Ninja ../llvm/llvm
"-DLLVM_ENABLE_PROJECTS=clang;lld;flang;openmp;clang-tools-extra" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=True -DCMAKE_INSTALL_PREFIX=../llvm-install "-DLLVM_TARGETS_TO_BUILD=AArch64" -DCLANG_DEFAULT_LINKER=lld
- Testsuite : export
LD_LIBRARY_PATH=$\WORKSPACE/llvm-install/lib/aarch64-unknown-linux-gnu${LD_LIBRARY_PATH:+:$\LD_LIBRARY_PATH} cmake -GNinja -DCMAKE_C_COMPILER="$\WORKSPACE/llvm-install/bin/clang" -DCMAKE_CXX_COMPILER="$\WORKSPACE/llvm-install/bin/clang++" -DCMAKE_Fortran_COMPILER="$\WORKSPACE/llvm-install/bin/flang-new" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS= -DCMAKE_CXX_FLAGS= -DCMAKE_Fortran_FLAGS= -DCMAKE_C_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DCMAKE_Fortran_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DTEST_SUITE_FORTRAN=ON -DTEST_SUITE_SUBDIRS=Fujitsu "$\WORKSPACE/test/test-suite"
We track this bug report under https://linaro.atlassian.net/browse/LLVM-1482. Please let us know if you have a fix.
If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The full lists of regressions and improvements as well as configure and make commands are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The list of [ignored] baseline and flaky failures are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Fujitsu testsuite : https://github.com/fujitsu/compiler-test-suite/
Current build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... Reference build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
Full commit : https://github.com/llvm/llvm-project/commit/b3cba9be41bfa89bc0ec212706c6028a...
Hi,
I confirmed the regession was fixed. Thanks!
Takahiro Kawashima, Fujitsu
Hi,
Florian Hahn and I landed 2 patches for fixing FindLastIV reductions idiom. https://github.com/llvm/llvm-project/commit/0e528ac404e13ed2d952a2d83aaf8383... https://github.com/llvm/llvm-project/commit/3397950f2d21426c7520d114a1258812... I think those can fix the issue you are facing. Please try them, and let me know if you still have regression on it.
Mel
On Fri, Dec 13, 2024 at 7:11 AM ci_notify@linaro.org wrote:
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In tcwg_flang_test/main-aarch64-Ofast-sve_vla, after: | commit llvmorg-20-init-15150-gb3cba9be41bf | Author: Mel Chen mel.chen@sifive.com | Date: Thu Dec 12 16:48:31 2024 +0800 | | [LoopVectorize] Vectorize select-cmp reduction pattern for increasing integer induction variable (#67812) | | Consider the following loop: | ``` | int rdx = init; | ... 12 lines of the commit log omitted.
Produces 2 regressions: | Running test-suite:Fujitsu/Fortran/0365 ... | FAIL: test-suite :: Fujitsu/Fortran/0365/Fujitsu-Fortran-0365_0185.test | FAIL: test-suite :: Fujitsu/Fortran/0365/Fujitsu-Fortran-0365_0186.test | # "FAIL" means : the execution of the compiled binary failed / output of the binary differs from the expected one
Used configuration :
- Toolchain : cmake -G Ninja ../llvm/llvm
"-DLLVM_ENABLE_PROJECTS=clang;lld;flang;openmp;clang-tools-extra" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=True -DCMAKE_INSTALL_PREFIX=../llvm-install "-DLLVM_TARGETS_TO_BUILD=AArch64" -DCLANG_DEFAULT_LINKER=lld
- Testsuite : export
LD_LIBRARY_PATH=$\WORKSPACE/llvm-install/lib/aarch64-unknown-linux-gnu${LD_LIBRARY_PATH:+:$\LD_LIBRARY_PATH} cmake -GNinja -DCMAKE_C_COMPILER="$\WORKSPACE/llvm-install/bin/clang" -DCMAKE_CXX_COMPILER="$\WORKSPACE/llvm-install/bin/clang++" -DCMAKE_Fortran_COMPILER="$\WORKSPACE/llvm-install/bin/flang-new" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS= -DCMAKE_CXX_FLAGS= -DCMAKE_Fortran_FLAGS= -DCMAKE_C_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DCMAKE_Fortran_FLAGS_RELEASE="-O3 -ffast-math -march=armv8.4-a+sve -msve-vector-bits=scalable -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -DNDEBUG" -DTEST_SUITE_FORTRAN=ON -DTEST_SUITE_SUBDIRS=Fujitsu "$\WORKSPACE/test/test-suite"
We track this bug report under https://linaro.atlassian.net/browse/LLVM-1482. Please let us know if you have a fix.
If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The full lists of regressions and improvements as well as configure and make commands are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The list of [ignored] baseline and flaky failures are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Fujitsu testsuite : https://github.com/fujitsu/compiler-test-suite/
Current build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... Reference build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
Full commit : https://github.com/llvm/llvm-project/commit/b3cba9be41bfa89bc0ec212706c6028a...
linaro-toolchain@lists.linaro.org