On Apr 6, 2020, at 08:21, Yvan Roux yvan.roux@linaro.org wrote:

Hi Louis,

Yes the issue due to this directory <TMP>/ModuleCache not being removed after it is used or cleaned up at the beginning. So it's on our side or into the test itself which doesn't remove these files at the end.

Are you using some special CMake variable to point the build to that Module cache? If so, then it would be the responsibility of the bot to clean it up.

Louis

All our bots run inside containers, they are available here https://hub.docker.com/u/linaro https://hub.docker.com/u/linaro

Thanks Yvan

On Mon, 6 Apr 2020 at 10:08, Louis Dionne <ldionne@apple.com mailto:ldionne@apple.com> wrote:

...

On Apr 2, 2020, at 13:28, Louis Dionne via libcxx-dev <libcxx-dev@lists.llvm.org mailto:libcxx-dev@lists.llvm.org> wrote:

Hi,

It looks like several bots assigned to you started failing after e6a39f00e8d0 was committed:

http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions>>

They all fail on the test libcxx/test/libcxx/modules/stds_include.sh.cpp with the following error:

<...>/libcxx/test/libcxx/modules/stds_include.sh.cpp:28:2: fatal error: file '<...>/libcxx/include/type_traits' has been modified since the module file '<TMP>/ModuleCache/1E92AHT/std-1V9DLRO.pcm' was built
#include <vector>
 ^
<...>/libcxx/test/libcxx/modules/stds_include.sh.cpp:28:2: note: please rebuild precompiled header '<TMP>/ModuleCache/1E92AHT/std-1V9DLRO.pcm'
1 error generated.

Our other bots are not failing, so I very strongly suspect this is not because of the change itself, but rather some weirdness in your bot configuration. For that reason, I will *not* revert the change (that would likely not improve the situation anyway). Can you please collaborate with us to understand and fix the issue?

Also, is there a Docker image used to run the bots? That is our preferred way of handling libc++/libc++abi bots, because that means anyone can reproduce the failures locally. If the bots don't require anything specific beyond the CMake configuration they're testing, you could even use our existing Docker images based on Debian.

Louis

---

linaro-toolchain mailing list linaro-toolchain@lists.linaro.org mailto:linaro-toolchain@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-toolchain https://lists.linaro.org/mailman/listinfo/linaro-toolchain

Nevermind, it seems that this is a Clang bug instead. See:

commit 62f3a9650a9f289a07a5f480764fb655178c2334 Author: Eric Fiselier eric@efcs.ca Date: Sat Apr 4 03:18:01 2020 -0400

[libc++] Attempt to workaround module invalidation bug

Cheers, Louis

On Apr 6, 2020, at 09:30, Yvan Roux yvan.roux@linaro.org wrote:

On Mon, 6 Apr 2020 at 15:18, Louis Dionne <ldionne@apple.com mailto:ldionne@apple.com> wrote:

...

On Apr 6, 2020, at 08:21, Yvan Roux <yvan.roux@linaro.org mailto:yvan.roux@linaro.org> wrote:

Hi Louis,

Yes the issue due to this directory <TMP>/ModuleCache not being removed after it is used or cleaned up at the beginning. So it's on our side or into the test itself which doesn't remove these files at the end.

Are you using some special CMake variable to point the build to that Module cache? If so, then it would be the responsibility of the bot to clean it up.

Nope, there is nothing special on cmake command line.

http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux/bui... http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux/builds/1512/steps/cmake/logs/stdio

Yvan

Louis

...

All our bots run inside containers, they are available here https://hub.docker.com/u/linaro https://hub.docker.com/u/linaro

Thanks Yvan

On Mon, 6 Apr 2020 at 10:08, Louis Dionne <ldionne@apple.com mailto:ldionne@apple.com> wrote:

...

On Apr 2, 2020, at 13:28, Louis Dionne via libcxx-dev <libcxx-dev@lists.llvm.org mailto:libcxx-dev@lists.llvm.org> wrote:

Hi,

It looks like several bots assigned to you started failing after e6a39f00e8d0 was committed:

http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux-noexceptions>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv8-linux>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux>>
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions> <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions <http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions>>

They all fail on the test libcxx/test/libcxx/modules/stds_include.sh.cpp with the following error:

<...>/libcxx/test/libcxx/modules/stds_include.sh.cpp:28:2: fatal error: file '<...>/libcxx/include/type_traits' has been modified since the module file '<TMP>/ModuleCache/1E92AHT/std-1V9DLRO.pcm' was built
#include <vector>
 ^
<...>/libcxx/test/libcxx/modules/stds_include.sh.cpp:28:2: note: please rebuild precompiled header '<TMP>/ModuleCache/1E92AHT/std-1V9DLRO.pcm'
1 error generated.

Our other bots are not failing, so I very strongly suspect this is not because of the change itself, but rather some weirdness in your bot configuration. For that reason, I will *not* revert the change (that would likely not improve the situation anyway). Can you please collaborate with us to understand and fix the issue?

Also, is there a Docker image used to run the bots? That is our preferred way of handling libc++/libc++abi bots, because that means anyone can reproduce the failures locally. If the bots don't require anything specific beyond the CMake configuration they're testing, you could even use our existing Docker images based on Debian.

Louis

---

linaro-toolchain mailing list linaro-toolchain@lists.linaro.org mailto:linaro-toolchain@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-toolchain https://lists.linaro.org/mailman/listinfo/linaro-toolchain