Hi,
Can I get a reduced .ll showing the regression, or some reduced steps for reproducing the bug? I suspect the bug is elsewhere, and not in the commit itself.
Warm regards, Ram
On Thu, Sep 5, 2024 at 3:39 AM ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
We understand that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
We track this report status in https://linaro.atlassian.net/browse/LLVM-1340 , please let us know if you are looking at the problem and/or when you have a fix.
In CI config tcwg_flang_test/main-aarch64-Ofast-sve_vla after:
| commit llvmorg-20-init-4622-g16900d3b98e6 | Author: Ramkumar Ramachandra ramkumar.ramachandra@codasip.com | Date: Wed Sep 4 22:01:04 2024 +0100 | | LICM: hoist BO assoc when BinOp is in RHS (#107072) | | Extend hoistBOAssociation smoothly to handle the case when the inner | BinaryOperator is in the RHS of the outer BinaryOperator. This completes | the generalization of hoistBOAssociation, and the only limitation after | this patch is the fact that only Add and Mul are hoisted.
FAIL: 1 regressions
regressions.sum: === test-suite tests ===
Running test-suite:Fujitsu/Fortran/0354 ... FAIL: test-suite :: Fujitsu/Fortran/0354/Fujitsu-Fortran-0354_0334.test
You can find the failure logs in *.log.1.xz files in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The full lists of regressions and improvements as well as configure and make commands are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The list of [ignored] baseline and flaky failures are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
The configuration of this build is: CI config tcwg_flang_test/main-aarch64-Ofast-sve_vla
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... Reference build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Reproduce last good and first bad builds: https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
Full commit : https://github.com/llvm/llvm-project/commit/16900d3b98e6c8fbdad4411a054e3566...
List of configurations that regressed due to this commit :
- tcwg_flang_test
** main-aarch64-Ofast-sve_vla *** FAIL: 1 regressions
https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Hi,
I took a look. This is probably caused by a floating-point arithmetic error.
The Fortran source program is https://github.com/fujitsu/compiler-test-suite/blob/main/Fortran/0354/0354_0... . The compilation flags are `-O3 -ffast-math`.
Changing `1.0E-6` to `1.0E-3` in the first line resolves this failure. Adding `-fno-associative-math` also resolves this failure.
If this floating-point arithmetic error is intended to occur, you don't need to investigate it.
Regards, Takahiro Kawashima
Hi,
Can I get a reduced .ll showing the regression, or some reduced steps for reproducing the bug? I suspect the bug is elsewhere, and not in the commit itself.
Warm regards, Ram
On Thu, Sep 5, 2024 at 3:39 AM ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
We understand that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
We track this report status in https://linaro.atlassian.net/browse/LLVM-1340 , please let us know if you are looking at the problem and/or when you have a fix.
In CI config tcwg_flang_test/main-aarch64-Ofast-sve_vla after:
| commit llvmorg-20-init-4622-g16900d3b98e6 | Author: Ramkumar Ramachandra ramkumar.ramachandra@codasip.com | Date: Wed Sep 4 22:01:04 2024 +0100 | | LICM: hoist BO assoc when BinOp is in RHS (#107072) | | Extend hoistBOAssociation smoothly to handle the case when the inner | BinaryOperator is in the RHS of the outer BinaryOperator. This completes | the generalization of hoistBOAssociation, and the only limitation after | this patch is the fact that only Add and Mul are hoisted.
FAIL: 1 regressions
regressions.sum: === test-suite tests ===
Running test-suite:Fujitsu/Fortran/0354 ... FAIL: test-suite :: Fujitsu/Fortran/0354/Fujitsu-Fortran-0354_0334.test
You can find the failure logs in *.log.1.xz files in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The full lists of regressions and improvements as well as configure and make commands are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... The list of [ignored] baseline and flaky failures are in
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
The configuration of this build is: CI config tcwg_flang_test/main-aarch64-Ofast-sve_vla
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/... Reference build : https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Reproduce last good and first bad builds: https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
Full commit : https://github.com/llvm/llvm-project/commit/16900d3b98e6c8fbdad4411a054e3566...
List of configurations that regressed due to this commit :
- tcwg_flang_test
** main-aarch64-Ofast-sve_vla *** FAIL: 1 regressions
https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vla-build/...
Takahiro Kawashima (Fujitsu) t-kawashima@fujitsu.com wrote:
I took a look. This is probably caused by a floating-point arithmetic error.
The Fortran source program is https://github.com/fujitsu/compiler-test-suite/blob/main/Fortran/0354/0354_0... . The compilation flags are `-O3 -ffast-math`.
Changing `1.0E-6` to `1.0E-3` in the first line resolves this failure. Adding `-fno-associative-math` also resolves this failure.
If this floating-point arithmetic error is intended to occur, you don't need to investigate it.
Thanks for investigating. Under `-ffast-math`, we're allowed to reassociate floating-point ops, and indeed we do, so I think the source code change is the right fix.
Warm regards, Ram
linaro-toolchain@lists.linaro.org
-
Ramkumar Ramachandra -
Takahiro Kawashima (Fujitsu)