CS has this patch in SG++: http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00199.html
This patch improves code size in a useful, target independent way, but was not committed upstream. It's not clear why. Since the patch does not belong to CodeSourcery, we can't upstream it ourselves either.
Is that patch a suitable candidate for Linaro GCC?
It is not upstreamable due to copyright issues, but we have a policy that we can keep such patches, if we wish.
The principle of not letting Linaro and SG++ diverge too far also suggests keeping it.
Any thoughts? If nobody objects soon I shall merge it in.
Andrew
Andrew Stubbs ams@codesourcery.com wrote:
CS has this patch in SG++: http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00199.html
This patch improves code size in a useful, target independent way, but was not committed upstream. It's not clear why. Since the patch does not belong to CodeSourcery, we can't upstream it ourselves either.
Steven asked: "What do you folks think of this patch?" and the only answer was by Richi: "I think it's reasonable."
So I'm not sure why it didn't go in. Maybe we should just ping Steven?
Is that patch a suitable candidate for Linaro GCC?
It is not upstreamable due to copyright issues, but we have a policy that we can keep such patches, if we wish.
What copyright issues? Steven ought to have an assignment in place ...
The principle of not letting Linaro and SG++ diverge too far also suggests keeping it.
Any thoughts? If nobody objects soon I shall merge it in.
Since there don't appear to be any fundamental objections to inclusion of the patch into mainline, and since the patch doesn't introduce any user-visible feature (like syntax extensions or command line options) that could cause build breaks for users if it were to go away after all, I would say this patch is fine for us ...
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
-- Dr. Ulrich Weigand | Phone: +49-7031/16-3727 STSM, GNU compiler and toolchain for Linux on System z and Cell/B.E. IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart, HRB 243294
On Mon, Aug 02, 2010 at 04:31:16PM +0200, Ulrich Weigand wrote:
Steven asked: "What do you folks think of this patch?" and the only answer was by Richi: "I think it's reasonable."
So I'm not sure why it didn't go in. Maybe we should just ping Steven?
It's been a while, but I think discussion elsewhere (a bug log maybe?) indicated that Steven wasn't happy with it.
Daniel Jacobowitz dan@codesourcery.com wrote:
On Mon, Aug 02, 2010 at 04:31:16PM +0200, Ulrich Weigand wrote:
Steven asked: "What do you folks think of this patch?" and the only answer was by Richi: "I think it's reasonable."
So I'm not sure why it didn't go in. Maybe we should just ping Steven?
It's been a while, but I think discussion elsewhere (a bug log maybe?) indicated that Steven wasn't happy with it.
Hmm, right, that's probably: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38785
Latest status seems to be that the original patch no longer applies, but Joern did an updated (and somewhat modified) version. This seems to have triggered a more general discussion on how to correctly estimate the effect of adding PHI nodes on code size ...
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
-- Dr. Ulrich Weigand | Phone: +49-7031/16-3727 STSM, GNU compiler and toolchain for Linux on System z and Cell/B.E. IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart, HRB 243294
On 02/08/10 16:03, Ulrich Weigand wrote:
Latest status seems to be that the original patch no longer applies, but Joern did an updated (and somewhat modified) version. This seems to have triggered a more general discussion on how to correctly estimate the effect of adding PHI nodes on code size ...
Do you mean this one?
http://gcc.gnu.org/ml/gcc-patches/2009-03/msg00250.html
We have this patch applied also, so now there are two PRE patches to consider.
Andrew
Andrew Stubbs ams@codesourcery.com wrote on 08/02/2010 06:47:36 PM:
On 02/08/10 16:03, Ulrich Weigand wrote:
Latest status seems to be that the original patch no longer applies, but Joern did an updated (and somewhat modified) version. This seems to have triggered a more general discussion on how to correctly estimate the effect of adding PHI nodes on code size ...
Do you mean this one?
Yes, that's the one.
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
-- Dr. Ulrich Weigand | Phone: +49-7031/16-3727 STSM, GNU compiler and toolchain for Linux on System z and Cell/B.E. IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart, HRB 243294
linaro-toolchain@lists.linaro.org
-
Andrew Stubbs -
Daniel Jacobowitz -
Ulrich Weigand