I get this problem when the CI is building a patchset for the binutils with my patches.
The patchset consists of 7 patches, and I suspect that this error message is generated when only part of the 7 patches are applied.
Could this be true?
They are interdependent, so there is no way to reorder the patches to make this work if not all the patches are applied.
Den 2024-07-07 kl. 02:47, skrev ci_notify@linaro.org:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
In binutils_build master-arm after:
| 2 patches in binutils | Patchwork URL: https://patchwork.sourceware.org/patch/93436 | dd57e0ed6f6 ldgram.y: Add ASCII parsing | 304119944bb ldlex.l: Add ASCII token | ... applied on top of baseline commit: | 85a67d0a39a Automatic date update in version.in
Results changed to # reset_artifacts: -10 # true: 0 # build_abe binutils: # FAILED # First few build errors in logs: # 00:01:58 /home/tcwg-build/workspace/tcwg_gnu_2/abe/snapshots/binutils.git~master/ld/ldgram.y:711:21: error: too many arguments to function ‘lang_add_string’ # 00:01:58 /home/tcwg-build/workspace/tcwg_gnu_2/abe/snapshots/binutils.git~master/ld/ldgram.y:717:19: error: too many arguments to function ‘lang_add_string’ # 00:01:58 make[4]: *** [Makefile:2290: ldgram.o] Error 1 # 00:01:58 make[3]: *** [Makefile:1903: all-recursive] Error 1 # 00:01:58 make[2]: *** [Makefile:1092: all] Error 2 # 00:01:58 make[1]: *** [Makefile:8044: all-ld] Error 2 # 00:01:58 make: *** [Makefile:1028: all] Error 2
From # reset_artifacts: -10 # true: 0 # build_abe binutils: 1
The configuration of this build is: CI config tcwg_binutils_build master-arm
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_binutils_build--master-arm-precommit/2298/art... Reference build : https://ci.linaro.org/job/tcwg_binutils_build--master-arm-build/1304/artifac...
Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files.
Hi Ulf,
Indeed, this report is for building binutils with only 2 first patches applied. Patch #3 fixes this failure; see https://patchwork.sourceware.org/project/binutils/list/?series=35932 .
However, the point of our CI testing "incomplete" patch series is to catch cases when a problem is introduced and then fixed in the same patch series. My understanding is that all GNU toolchain projects strive to be "correct" at every revision. This, of course, is not an issue if you plan to squash your changes before merging them.
Does this answer your question?
Thank you,
-- Maxim Kuvyrkov https://www.linaro.org
On Jul 8, 2024, at 16:08, Ulf Samuelsson linaro-toolchain@emagii.com wrote:
I get this problem when the CI is building a patchset for the binutils with my patches.
The patchset consists of 7 patches, and I suspect that this error message is generated when only part of the 7 patches are applied.
Could this be true?
They are interdependent, so there is no way to reorder the patches to make this work if not all the patches are applied.
Den 2024-07-07 kl. 02:47, skrev ci_notify@linaro.org:
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
In binutils_build master-arm after:
| 2 patches in binutils | Patchwork URL: https://patchwork.sourceware.org/patch/93436 | dd57e0ed6f6 ldgram.y: Add ASCII parsing | 304119944bb ldlex.l: Add ASCII token | ... applied on top of baseline commit: | 85a67d0a39a Automatic date update in version.in
Results changed to # reset_artifacts: -10 # true: 0 # build_abe binutils: # FAILED # First few build errors in logs: # 00:01:58 /home/tcwg-build/workspace/tcwg_gnu_2/abe/snapshots/binutils.git~master/ld/ldgram.y:711:21: error: too many arguments to function ‘lang_add_string’ # 00:01:58 /home/tcwg-build/workspace/tcwg_gnu_2/abe/snapshots/binutils.git~master/ld/ldgram.y:717:19: error: too many arguments to function ‘lang_add_string’ # 00:01:58 make[4]: *** [Makefile:2290: ldgram.o] Error 1 # 00:01:58 make[3]: *** [Makefile:1903: all-recursive] Error 1 # 00:01:58 make[2]: *** [Makefile:1092: all] Error 2 # 00:01:58 make[1]: *** [Makefile:8044: all-ld] Error 2 # 00:01:58 make: *** [Makefile:1028: all] Error 2
From # reset_artifacts: -10 # true: 0 # build_abe binutils: 1
The configuration of this build is: CI config tcwg_binutils_build master-arm
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_binutils_build--master-arm-precommit/2298/art... Reference build : https://ci.linaro.org/job/tcwg_binutils_build--master-arm-build/1304/artifac...
Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files.
-- Best Regards Ulf Samuelsson
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.org
linaro-toolchain@lists.linaro.org
-
Maxim Kuvyrkov -
Ulf Samuelsson