On Wed, 26 Mar 2025 at 00:55, ci_notify@linaro.org wrote:
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In gcc_check master-aarch64, after: | commit gcc-15-8904-ge200f53a555 | Author: Jonathan Wakely jwakely@redhat.com | Date: Tue Mar 25 13:24:08 2025 +0000 | | libstdc++: Optimize std::vector construction from input iterators [PR108487] | | LWG 3291 make std::ranges::iota_view's iterator have input_iterator_tag | as its iterator_category, even though it satisfies the C++20 | std::forward_iterator concept. This means that the traditional | ... 41 lines of the commit log omitted.
Produces 2 regressions: | | regressions.sum: | Running g++:g++.dg/dg.exp ... | FAIL: g++.dg/tree-ssa/initlist-opt1.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>" | FAIL: g++.dg/tree-ssa/initlist-opt2.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>"
Used configuration : *CI config* tcwg_gcc_check master-aarch64 *configure and test flags:* none, autodetected on aarch64-unknown-linux-gnu
We track this bug report under https://linaro.atlassian.net/browse/GNU-1548. Please let us know if you have a fix.
I have a fix:
--- a/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C +++ b/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C @@ -4,7 +4,7 @@ // { dg-skip-if "requires hosted libstdc++ for string" { ! hostedlib } }
// Test that we do range-initialization from const char *. -// { dg-final { scan-tree-dump {_M_range_initialize<const char* const*>} "gimple" } } +// { dg-final { scan-tree-dump {_M_range_initialize_n<const char* const*} "gimple" } } // { dg-final { scan-tree-dump {static const char.*72} "gimple" } }
#include <string>
If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
The full lists of regressions and improvements as well as configure and make commands are in
The list of [ignored] baseline and flaky failures are in
Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3491/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3490/artifact...
Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha...
Full commit : https://gcc.gnu.org/git/?p=gcc.git%3Ba=commitdiff%3Bh=e200f53a5556516ec831e6...
On Wed, 26 Mar 2025 at 09:55, Jonathan Wakely jwakely.gcc@gmail.com wrote:
On Wed, 26 Mar 2025 at 00:55, ci_notify@linaro.org wrote:
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In gcc_check master-aarch64, after: | commit gcc-15-8904-ge200f53a555 | Author: Jonathan Wakely jwakely@redhat.com | Date: Tue Mar 25 13:24:08 2025 +0000 | | libstdc++: Optimize std::vector construction from input iterators [PR108487] | | LWG 3291 make std::ranges::iota_view's iterator have input_iterator_tag | as its iterator_category, even though it satisfies the C++20 | std::forward_iterator concept. This means that the traditional | ... 41 lines of the commit log omitted.
Produces 2 regressions: | | regressions.sum: | Running g++:g++.dg/dg.exp ... | FAIL: g++.dg/tree-ssa/initlist-opt1.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>" | FAIL: g++.dg/tree-ssa/initlist-opt2.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>"
Used configuration : *CI config* tcwg_gcc_check master-aarch64 *configure and test flags:* none, autodetected on aarch64-unknown-linux-gnu
We track this bug report under https://linaro.atlassian.net/browse/GNU-1548. Please let us know if you have a fix.
I have a fix:
--- a/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C +++ b/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C @@ -4,7 +4,7 @@ // { dg-skip-if "requires hosted libstdc++ for string" { ! hostedlib } }
// Test that we do range-initialization from const char *. -// { dg-final { scan-tree-dump {_M_range_initialize<const char* const*>} "gimple" } } +// { dg-final { scan-tree-dump {_M_range_initialize_n<const char* const*} "gimple" } } // { dg-final { scan-tree-dump {static const char.*72} "gimple" } }
#include <string>
Now posted as https://gcc.gnu.org/pipermail/gcc-patches/2025-March/679317.html
If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
The full lists of regressions and improvements as well as configure and make commands are in
The list of [ignored] baseline and flaky failures are in
Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3491/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3490/artifact...
Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha...
Full commit : https://gcc.gnu.org/git/?p=gcc.git%3Ba=commitdiff%3Bh=e200f53a5556516ec831e6...
On Wed, 26 Mar 2025 at 10:17, Jonathan Wakely jwakely.gcc@gmail.com wrote:
On Wed, 26 Mar 2025 at 09:55, Jonathan Wakely jwakely.gcc@gmail.com wrote:
On Wed, 26 Mar 2025 at 00:55, ci_notify@linaro.org wrote:
Dear contributor,
Our automatic CI has detected problems related to your patch(es). Please find some details below.
In gcc_check master-aarch64, after: | commit gcc-15-8904-ge200f53a555 | Author: Jonathan Wakely jwakely@redhat.com | Date: Tue Mar 25 13:24:08 2025 +0000 | | libstdc++: Optimize std::vector construction from input iterators [PR108487] | | LWG 3291 make std::ranges::iota_view's iterator have input_iterator_tag | as its iterator_category, even though it satisfies the C++20 | std::forward_iterator concept. This means that the traditional | ... 41 lines of the commit log omitted.
Produces 2 regressions: | | regressions.sum: | Running g++:g++.dg/dg.exp ... | FAIL: g++.dg/tree-ssa/initlist-opt1.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>" | FAIL: g++.dg/tree-ssa/initlist-opt2.C -std=c++26 scan-tree-dump gimple "_M_range_initialize<const char\* const\*>"
Used configuration : *CI config* tcwg_gcc_check master-aarch64 *configure and test flags:* none, autodetected on aarch64-unknown-linux-gnu
We track this bug report under https://linaro.atlassian.net/browse/GNU-1548. Please let us know if you have a fix.
I have a fix:
--- a/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C +++ b/gcc/testsuite/g++.dg/tree-ssa/initlist-opt1.C @@ -4,7 +4,7 @@ // { dg-skip-if "requires hosted libstdc++ for string" { ! hostedlib } }
// Test that we do range-initialization from const char *. -// { dg-final { scan-tree-dump {_M_range_initialize<const char* const*>} "gimple" } } +// { dg-final { scan-tree-dump {_M_range_initialize_n<const char* const*} "gimple" } } // { dg-final { scan-tree-dump {static const char.*72} "gimple" } }
#include <string>
Now posted as https://gcc.gnu.org/pipermail/gcc-patches/2025-March/679317.html
A slightly simpler version of the patch has now been pushed as r15-8934-g101f302363e877
If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.
-----------------8<--------------------------8<--------------------------8<--------------------------
The information below contains the details of the failures, and the ways to reproduce a debug environment:
You can find the failure logs in *.log.1.xz files in
The full lists of regressions and improvements as well as configure and make commands are in
The list of [ignored] baseline and flaky failures are in
Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3491/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/3490/artifact...
Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha...
Full commit : https://gcc.gnu.org/git/?p=gcc.git%3Ba=commitdiff%3Bh=e200f53a5556516ec831e6...
linaro-toolchain@lists.linaro.org
-
Jonathan Wakely