Re: [Linaro-mm-sig] [PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret
On Wed, Oct 30, 2019 at 8:45 AM Andrew F. Davis afd@ti.com wrote:
On 10/30/19 11:02 AM, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The variable ret is being assigned with a value that is never read, it is being re-assigned the same value on the err0 exit path. The assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value") Fixes: 47a32f9c1226 ("dma-buf: heaps: Add system heap to dmabuf heaps") Signed-off-by: Colin Ian King colin.king@canonical.com
The root of the issue is that ret is not used in the error path, it should be, I suggest this fix:
--- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -98,7 +98,7 @@ static int system_heap_allocate(struct dma_heap *heap, err0: kfree(helper_buffer);
return -ENOMEM;
return ret;}
Sounds good! If its ok I'll generate a commit crediting Colin for reporting the issue and Andrew for the fix and submit it to Sumit.
Many thanks to you both! -john
On 30/10/2019 17:21, John Stultz wrote:
On Wed, Oct 30, 2019 at 8:45 AM Andrew F. Davis afd@ti.com wrote:
On 10/30/19 11:02 AM, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The variable ret is being assigned with a value that is never read, it is being re-assigned the same value on the err0 exit path. The assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value") Fixes: 47a32f9c1226 ("dma-buf: heaps: Add system heap to dmabuf heaps") Signed-off-by: Colin Ian King colin.king@canonical.com
The root of the issue is that ret is not used in the error path, it should be, I suggest this fix:
--- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -98,7 +98,7 @@ static int system_heap_allocate(struct dma_heap *heap, err0: kfree(helper_buffer);
return -ENOMEM;
return ret;}
Sounds good! If its ok I'll generate a commit crediting Colin for reporting the issue and Andrew for the fix and submit it to Sumit.
Thanks for the correct fix.
Colin
Many thanks to you both! -john
linaro-mm-sig@lists.linaro.org
-
Colin Ian King -
John Stultz