On Sun, 12 Nov 2023 22:05:30 -0800 Mina Almasry wrote:

My issue here is that all these skb helpers call each other so I end up having to move a lot of the unrelated skb helpers to this new header (maybe that is acceptable but it feels weird).

Splitting pp headers again is not an option, we already split it into types and helpers.

The series doesn't apply and it's a bit hard for me to, in between LPC talks, figure out how to extract your patches from the GH UI to take a proper look :( We can defer this for now, and hopefully v4 will apply to net-next. But it will need to get solved.