The content of this message was lost. It was probably cross-posted to multiple lists and previously handled on another list.
On Sun, Nov 23, 2025 at 10:51:22PM +0000, Pavel Begunkov wrote:
diff --git a/include/linux/uio.h b/include/linux/uio.h index 5b127043a151..1b22594ca35b 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -29,6 +29,7 @@ enum iter_type { ITER_FOLIOQ, ITER_XARRAY, ITER_DISCARD,
- ITER_DMA_TOKEN,
Please use DMABUF/dmabuf naming everywhere, this is about dmabufs and not dma in general.
Otherwise this looks good.
On 12/4/25 10:43, Christoph Hellwig wrote:
On Sun, Nov 23, 2025 at 10:51:22PM +0000, Pavel Begunkov wrote:
diff --git a/include/linux/uio.h b/include/linux/uio.h index 5b127043a151..1b22594ca35b 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -29,6 +29,7 @@ enum iter_type { ITER_FOLIOQ, ITER_XARRAY, ITER_DISCARD,
- ITER_DMA_TOKEN,
Please use DMABUF/dmabuf naming everywhere, this is about dmabufs and not dma in general.
I guess I can do that (in all places) since it got that much fat around dmabuf, but for me it was always about passing dma addresses. Dmabuf was a way to pass buffers, even though mandatory for uapi.
+void iov_iter_dma_token(struct iov_iter *i, unsigned int direction,
struct dma_token *token,loff_t off, size_t count)+{
WARN_ON(direction & ~(READ | WRITE));*i = (struct iov_iter){.iter_type = ITER_DMA_TOKEN,.data_source = direction,.dma_token = token,.iov_offset = 0,
nit: iov_offset is getting below too. can get rid of this one.
.count = count,.iov_offset = off,};
linaro-mm-sig@lists.linaro.org
-
Anuj gupta -
asml.silence＠gmail.com -
Christoph Hellwig -
Pavel Begunkov