On Wed, Oct 09, 2024 at 07:15:42PM +0800, Shu-hsiang Yang wrote:
- Add camera isp7x module device document
- Add camera interface device document
Signed-off-by: Shu-hsiang Yang Shu-hsiang.Yang@mediatek.com
.../media/mediatek/mediatek,cam-raw.yaml | 169 ++++++++++++++++++ .../media/mediatek/mediatek,cam-yuv.yaml | 148 +++++++++++++++ .../media/mediatek/mediatek,camisp.yaml | 71 ++++++++ .../media/mediatek/mediatek,seninf-core.yaml | 106 +++++++++++ .../media/mediatek/mediatek,seninf.yaml | 88 +++++++++ 5 files changed, 582 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,cam-raw.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,cam-yuv.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,camisp.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,seninf-core.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,seninf.yaml
diff --git a/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-raw.yaml b/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-raw.yaml new file mode 100644 index 000000000000..c709e4bf0a18 --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-raw.yaml @@ -0,0 +1,169 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2024 MediaTek Inc.
+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/mediatek/mediatek,cam-raw.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: The cam-raw unit of MediaTek ISP system
+maintainers:
- Shu-hsiang Yang shu-hsiang.yang@mediatek.com
- Shun-yi Wang shun-yi.wang@mediatek.com
- Teddy Chen teddy.chen@mediatek.com
+description:
- MediaTek cam-raw is the camera RAW processing unit in MediaTek SoC.
+properties:
- compatible:
- const: mediatek,cam-raw
Compatibles should be SoC specific.
- "#address-cells":
- const: 2
- "#size-cells":
- const: 2
Don't need these. You don't have any child nodes with addresses.
- reg:
- items:
minItems: 2maxItems: 4
Drop items.
- minItems: 1
- maxItems: 2
You have to specify what each region is.
Why does it vary? A h/w block either has register region or it doesn't.
- reg-names:
- minItems: 1
- maxItems: 2
You must define the names.
- mediatek,cam-id:
- description:
Describes the index of MediaTek cam-raw unit for ISP- $ref: /schemas/types.yaml#/definitions/uint32
- enum: [0, 1, 2]
No, we don't put module indices in DT.
- mediatek,larbs:
- description:
Describes MediaTek bus infrastructure unit for ISP system.List of phandle to the local arbiters in the current SoCs.Refer to bindings/memory-controllers/mediatek,smi-larb.yaml.- $ref: /schemas/types.yaml#/definitions/phandle-array
- minItems: 1
- maxItems: 32
- interrupts:
- minItems: 1
- dma-ranges:
- description:
Describes the address information of IOMMU mapping to memory.Defines six fields for the MediaTek IOMMU extended iova, pa, and size.- minItems: 1
- power-domains:
- minItems: 1
- clocks:
- minItems: 4
- maxItems: 16
You have to define what the clocks are.
- clock-names:
- minItems: 4
- maxItems: 16
- assigned-clocks:
- maxItems: 1
- assigned-clock-parents:
- maxItems: 1
Drop. You don't need to document assigned-clocks.
- iommus:
- description:
Points to the respective IOMMU block with master port as argument, seeDocumentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.Ports are according to the HW.- minItems: 1
- maxItems: 32
+required:
- compatible
- reg
- reg-names
- interrupts
- power-domains
- clocks
- clock-names
- iommus
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- #include <dt-bindings/interrupt-controller/irq.h>
- #include <dt-bindings/power/mediatek,mt8188-power.h>
- #include <dt-bindings/clock/mediatek,mt8188-clk.h>
- #include <dt-bindings/memory/mediatek,mt8188-memory-port.h>
- soc {
#address-cells = <2>;#size-cells = <2>;cam_raw_a@16030000 {compatible = "mediatek,cam-raw";reg = <0 0x16030000 0 0x8000>,<0 0x16038000 0 0x8000>;reg-names = "base", "inner_base";mediatek,cam-id = <0>;mediatek,larbs = <&larb16a>;interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH 0>;#address-cells = <2>;#size-cells = <2>;dma-ranges = <0x2 0x0 0x0 0x40000000 0x1 0x0>;power-domains = <&spm MT8188_POWER_DOMAIN_CAM_SUBA>;clocks = <&camsys CLK_CAM_MAIN_CAM2MM0_GALS>,<&camsys CLK_CAM_MAIN_CAM2MM1_GALS>,<&camsys CLK_CAM_MAIN_CAM2SYS_GALS>,<&camsys CLK_CAM_MAIN_CAM>,<&camsys CLK_CAM_MAIN_CAMTG>,<&camsys_rawa CLK_CAM_RAWA_LARBX>,<&camsys_rawa CLK_CAM_RAWA_CAM>,<&camsys_rawa CLK_CAM_RAWA_CAMTG>,<&topckgen CLK_TOP_CAM>,<&topckgen CLK_TOP_CAMTG>,<&topckgen CLK_TOP_CAMTM>;clock-names = "camsys_cam2mm0_cgpdn","camsys_cam2mm1_cgpdn","camsys_cam2sys_cgpdn","camsys_cam_cgpdn","camsys_camtg_cgpdn","camsys_rawa_larbx_cgpdn","camsys_rawa_cam_cgpdn","camsys_rawa_camtg_cgpdn","topckgen_top_cam","topckgen_top_camtg","topckgen_top_camtm";assigned-clocks = <&topckgen CLK_TOP_CAM>;assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D5>;iommus = <&vpp_iommu M4U_PORT_L16A_IMGO_R1>,<&vpp_iommu M4U_PORT_L16A_CQI_R1>,<&vpp_iommu M4U_PORT_L16A_CQI_R2>,<&vpp_iommu M4U_PORT_L16A_BPCI_R1>,<&vpp_iommu M4U_PORT_L16A_LSCI_R1>,<&vpp_iommu M4U_PORT_L16A_RAWI_R2>,<&vpp_iommu M4U_PORT_L16A_RAWI_R3>,<&vpp_iommu M4U_PORT_L16A_UFDI_R2>,<&vpp_iommu M4U_PORT_L16A_UFDI_R3>,<&vpp_iommu M4U_PORT_L16A_RAWI_R4>,<&vpp_iommu M4U_PORT_L16A_RAWI_R5>,<&vpp_iommu M4U_PORT_L16A_AAI_R1>,<&vpp_iommu M4U_PORT_L16A_UFDI_R5>,<&vpp_iommu M4U_PORT_L16A_FHO_R1>,<&vpp_iommu M4U_PORT_L16A_AAO_R1>,<&vpp_iommu M4U_PORT_L16A_TSFSO_R1>,<&vpp_iommu M4U_PORT_L16A_FLKO_R1>;};- };
+... diff --git a/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-yuv.yaml b/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-yuv.yaml new file mode 100644 index 000000000000..30dfd5e5ecb1 --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek/mediatek,cam-yuv.yaml
Similar comments on the rest.
Rob
linaro-mm-sig@lists.linaro.org
-
Rob Herring