+static inline bool migrate_async_suitable(int migratetype)
On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton dhillf@gmail.com wrote:
Just nitpick, since the helper is not directly related to what async means, how about migrate_suitable(int migrate_type) ?
2012/2/3 Michal Nazarewicz mina86@mina86.com:
I feel current name is better suited since it says that it's OK to scan this block if it's an asynchronous compaction run.
On Sat, 04 Feb 2012 10:09:02 +0100, Hillf Danton dhillf@gmail.com wrote:
The input is the migrate type of page considered, and the async is only one of the modes that compaction should be carried out. Plus the helper is also used in other cases where async is entirely not concerned.
That said, the naming is not clear, if not misleading.
In the first version the function was called is_migrate_cma_or_movable() which described what the function checked. Mel did not like it though, hence the change to migrate_async_suitable(). Honestly, I'm not sure what would be the best name for function.