linaro-kernel

linaro-kernel@lists.linaro.org

10094 discussions

[PATCH v5 0/3] [RFC] Add support for PCI in AArch64

by Liviu Dudau

Hi, This patch adds support for PCI to AArch64. It is based on my v5 patch that adds support for creating generic host bridge structure from device tree. With that in place, I was able to boot a platform that has PCIe host bridge support and use a PCIe network card. Changes from v4: - Fixed the pci_domain_nr() implementation for arm64. Now we use find_pci_host_bride() to find the host bridge before we retrieve the domain number. Changes from v3: - Added Acks accumulated so far ;) - Still carrying Catalin's patch for moving the PCI_IO_BASE until it lands in linux-next or mainline, in order to ease applying the series Changes from v2: - Implement an arch specific version of pci_register_io_range() and pci_address_to_pio(). - Return 1 from pci_proc_domain(). Changes from v1: - Added Catalin's patch for moving the PCI_IO_BASE location and extend its size to 16MB - Integrated Arnd's version of pci_ioremap_io that uses a bitmap for keeping track of assigned IO space and returns an io_offset. At the moment the code is added in arch/arm64 but it can be moved in drivers/pci. - Added a fix for the generic ioport_map() function when !CONFIG_GENERIC_IOMAP as suggested by Arnd. v4 thread here: https://lkml.org/lkml/2014/3/3/298 v3 thread here: https://lkml.org/lkml/2014/2/28/211 v2 thread here: https://lkml.org/lkml/2014/2/27/255 v1 thread here: https://lkml.org/lkml/2014/2/3/389 The API used is different from the one used by ARM architecture. There is no pci_common_init_dev() function and no hw_pci structure, as that is no longer needed. Once the last signature is added to the legal agreement, I will post the host bridge driver code that I am using. Meanwhile, here is an example of what the probe function looks like, posted as an example: static int myhostbridge_probe(struct platform_device *pdev) { int err; struct device_node *dev; struct pci_host_bridge *bridge; struct myhostbridge_port *pp; resource_size_t lastbus; dev = pdev->dev.of_node; if (!of_device_is_available(dev)) { pr_warn("%s: disabled\n", dev->full_name); return -ENODEV; } pp = kzalloc(sizeof(struct myhostbridge_port), GFP_KERNEL); if (!pp) return -ENOMEM; bridge = of_create_pci_host_bridge(&pdev->dev, &myhostbridge_ops, pp); if (IS_ERR(bridge)) { err = PTR_ERR(bridge); goto bridge_create_fail; } err = myhostbridge_setup(bridge->bus); if (err) goto bridge_setup_fail; /* We always enable PCI domains and we keep domain 0 backward * compatible in /proc for video cards */ pci_add_flags(PCI_ENABLE_PROC_DOMAINS); pci_add_flags(PCI_REASSIGN_ALL_BUS | PCI_REASSIGN_ALL_RSRC); lastbus = pci_scan_child_bus(bridge->bus); pci_bus_update_busn_res_end(bridge->bus, lastbus); pci_assign_unassigned_bus_resources(bridge->bus); pci_bus_add_devices(bridge->bus); return 0; bridge_setup_fail: put_device(&bridge->dev); device_unregister(&bridge->dev); bridge_create_fail: kfree(pp); return err; } Best regards, Liviu Catalin Marinas (1): arm64: Extend the PCI I/O space to 16MB Liviu Dudau (2): Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases. arm64: Add architecture support for PCI Documentation/arm64/memory.txt | 16 ++-- arch/arm64/Kconfig | 19 ++++- arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/io.h | 5 +- arch/arm64/include/asm/pci.h | 49 ++++++++++++ arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/pci.c | 178 +++++++++++++++++++++++++++++++++++++++++ include/asm-generic/io.h | 2 +- 8 files changed, 261 insertions(+), 10 deletions(-) create mode 100644 arch/arm64/include/asm/pci.h create mode 100644 arch/arm64/kernel/pci.c -- 1.9.0

11 years, 2 months

[PATCH V6 Resend 1/5] cpufreq: suspend governors on system suspend/hibernate

by Viresh Kumar

This patch adds cpufreq suspend/resume calls to dpm_{suspend|resume}() for handling suspend/resume of cpufreq governors. Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables configuration for clusters/sockets with non-boot CPUs was getting lost after suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on removal of the last cpu for that policy and so deallocating memory for tunables. This is fixed by this patch as we don't allow any operation on governors after device suspend and before device resume now. We could have added these callbacks at dpm_{suspend|resume}_noirq() level but the problem here is that most of the devices (i.e. devices with ->suspend() callbacks) have already been suspended by now and so if drivers want to change frequency before suspending, then it might not be possible for many platforms (which depend on other peripherals like i2c, regulators, etc). Reported-and-tested-by: Lan Tianyu <tianyu.lan(a)intel.com> Reported-by: Jinhyuk Choi <jinchoi(a)broadcom.com> Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- V5->V6: 1-2-3/7 merged into 1/5 drivers/base/power/main.c | 5 +++ drivers/cpufreq/cpufreq.c | 111 +++++++++++++++++++++++----------------------- include/linux/cpufreq.h | 8 ++++ 3 files changed, 69 insertions(+), 55 deletions(-) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index 42355e4..86d5e4f 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -29,6 +29,7 @@ #include <linux/async.h> #include <linux/suspend.h> #include <trace/events/power.h> +#include <linux/cpufreq.h> #include <linux/cpuidle.h> #include <linux/timer.h> @@ -866,6 +867,8 @@ void dpm_resume(pm_message_t state) mutex_unlock(&dpm_list_mtx); async_synchronize_full(); dpm_show_time(starttime, state, NULL); + + cpufreq_resume(); } /** @@ -1434,6 +1437,8 @@ int dpm_suspend(pm_message_t state) might_sleep(); + cpufreq_suspend(); + mutex_lock(&dpm_list_mtx); pm_transition = state; async_error = 0; diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 56b7b1b..2e43c08 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -26,7 +26,7 @@ #include <linux/module.h> #include <linux/mutex.h> #include <linux/slab.h> -#include <linux/syscore_ops.h> +#include <linux/suspend.h> #include <linux/tick.h> #include <trace/events/power.h> @@ -47,6 +47,9 @@ static LIST_HEAD(cpufreq_policy_list); static DEFINE_PER_CPU(char[CPUFREQ_NAME_LEN], cpufreq_cpu_governor); #endif +/* Flag to suspend/resume CPUFreq governors */ +static bool cpufreq_suspended; + static inline bool has_target(void) { return cpufreq_driver->target_index || cpufreq_driver->target; @@ -1576,82 +1579,77 @@ static struct subsys_interface cpufreq_interface = { }; /** - * cpufreq_bp_suspend - Prepare the boot CPU for system suspend. + * cpufreq_suspend() - Suspend CPUFreq governors * - * This function is only executed for the boot processor. The other CPUs - * have been put offline by means of CPU hotplug. + * Called during system wide Suspend/Hibernate cycles for suspending governors + * as some platforms can't change frequency after this point in suspend cycle. + * Because some of the devices (like: i2c, regulators, etc) they use for + * changing frequency are suspended quickly after this point. */ -static int cpufreq_bp_suspend(void) +void cpufreq_suspend(void) { - int ret = 0; - - int cpu = smp_processor_id(); struct cpufreq_policy *policy; - pr_debug("suspending cpu %u\n", cpu); + if (!cpufreq_driver) + return; - /* If there's no policy for the boot CPU, we have nothing to do. */ - policy = cpufreq_cpu_get(cpu); - if (!policy) - return 0; + if (!has_target()) + return; - if (cpufreq_driver->suspend) { - ret = cpufreq_driver->suspend(policy); - if (ret) - printk(KERN_ERR "cpufreq: suspend failed in ->suspend " - "step on CPU %u\n", policy->cpu); + pr_debug("%s: Suspending Governors\n", __func__); + + list_for_each_entry(policy, &cpufreq_policy_list, policy_list) { + if (__cpufreq_governor(policy, CPUFREQ_GOV_STOP)) + pr_err("%s: Failed to stop governor for policy: %p\n", + __func__, policy); + else if (cpufreq_driver->suspend + && cpufreq_driver->suspend(policy)) + pr_err("%s: Failed to suspend driver: %p\n", __func__, + policy); } - cpufreq_cpu_put(policy); - return ret; + cpufreq_suspended = true; } /** - * cpufreq_bp_resume - Restore proper frequency handling of the boot CPU. + * cpufreq_resume() - Resume CPUFreq governors * - * 1.) resume CPUfreq hardware support (cpufreq_driver->resume()) - * 2.) schedule call cpufreq_update_policy() ASAP as interrupts are - * restored. It will verify that the current freq is in sync with - * what we believe it to be. This is a bit later than when it - * should be, but nonethteless it's better than calling - * cpufreq_driver->get() here which might re-enable interrupts... - * - * This function is only executed for the boot CPU. The other CPUs have not - * been turned on yet. + * Called during system wide Suspend/Hibernate cycle for resuming governors that + * are suspended with cpufreq_suspend(). */ -static void cpufreq_bp_resume(void) +void cpufreq_resume(void) { - int ret = 0; - - int cpu = smp_processor_id(); struct cpufreq_policy *policy; - pr_debug("resuming cpu %u\n", cpu); + if (!cpufreq_driver) + return; - /* If there's no policy for the boot CPU, we have nothing to do. */ - policy = cpufreq_cpu_get(cpu); - if (!policy) + if (!has_target()) return; - if (cpufreq_driver->resume) { - ret = cpufreq_driver->resume(policy); - if (ret) { - printk(KERN_ERR "cpufreq: resume failed in ->resume " - "step on CPU %u\n", policy->cpu); - goto fail; - } - } + pr_debug("%s: Resuming Governors\n", __func__); - schedule_work(&policy->update); + cpufreq_suspended = false; -fail: - cpufreq_cpu_put(policy); -} + list_for_each_entry(policy, &cpufreq_policy_list, policy_list) { + if (__cpufreq_governor(policy, CPUFREQ_GOV_START) + || __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS)) + pr_err("%s: Failed to start governor for policy: %p\n", + __func__, policy); + else if (cpufreq_driver->resume + && cpufreq_driver->resume(policy)) + pr_err("%s: Failed to resume driver: %p\n", __func__, + policy); -static struct syscore_ops cpufreq_syscore_ops = { - .suspend = cpufreq_bp_suspend, - .resume = cpufreq_bp_resume, -}; + /* + * schedule call cpufreq_update_policy() for boot CPU, i.e. last + * policy in list. It will verify that the current freq is in + * sync with what we believe it to be. + */ + if (list_is_last(&policy->policy_list, &cpufreq_policy_list)) + schedule_work(&policy->update); + } +} /** * cpufreq_get_current_driver - return current driver's name @@ -1868,6 +1866,10 @@ static int __cpufreq_governor(struct cpufreq_policy *policy, struct cpufreq_governor *gov = NULL; #endif + /* Don't start any governor operations if we are entering suspend */ + if (cpufreq_suspended) + return 0; + if (policy->governor->max_transition_latency && policy->cpuinfo.transition_latency > policy->governor->max_transition_latency) { @@ -2407,7 +2409,6 @@ static int __init cpufreq_core_init(void) cpufreq_global_kobject = kobject_create(); BUG_ON(!cpufreq_global_kobject); - register_syscore_ops(&cpufreq_syscore_ops); return 0; } diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 4d89e0e..94ed907 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -296,6 +296,14 @@ cpufreq_verify_within_cpu_limits(struct cpufreq_policy *policy) policy->cpuinfo.max_freq); } +#ifdef CONFIG_CPU_FREQ +void cpufreq_suspend(void); +void cpufreq_resume(void); +#else +static inline void cpufreq_suspend(void) {} +static inline void cpufreq_resume(void) {} +#endif + /********************************************************************* * CPUFREQ NOTIFIER INTERFACE * *********************************************************************/ -- 1.7.12.rc2.18.g61b472e

11 years, 2 months

[PATCH V2 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

by Viresh Kumar

We call __find_governor() during addition of first CPU of every policy from __cpufreq_add_dev() to find the last governor used for this CPU before it was hotplugged-out. After that we call cpufreq_parse_governor() in cpufreq_init_policy() either with this governor or default governor. And right after that policy->governor is set to NULL. There is no functional problem here with this code, but it is just that some of the code required in cpufreq_init_policy() is being called by its caller, i.e. __cpufreq_add_dev(). So, it would make more sense to get all these together at a single place to make code more readable. So, instead of doing this move the relevant parts to cpufreq_init_policy() policy only and initialize policy->governor to NULL at the beginning. In order to clean the code a bit more, some of the #ifdefs for CONFIG_HOTPLUG_CPU are also removed which used to maintain the last governor used for any CPU. Keeping that code wouldn't harm us much but would improve the cleanliness of code. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- V1->V2: - Improved commit logs - Removed unrelated whitespace changes - Removed some #ifdef CONFIG_HOTPLUG_CPU to clean code a bit. drivers/cpufreq/cpufreq.c | 38 ++++++++++++++------------------------ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 56b7b1b..fff2968 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -42,10 +42,8 @@ static DEFINE_RWLOCK(cpufreq_driver_lock); DEFINE_MUTEX(cpufreq_governor_lock); static LIST_HEAD(cpufreq_policy_list); -#ifdef CONFIG_HOTPLUG_CPU /* This one keeps track of the previously set governor of a removed CPU */ static DEFINE_PER_CPU(char[CPUFREQ_NAME_LEN], cpufreq_cpu_governor); -#endif static inline bool has_target(void) { @@ -879,18 +877,25 @@ err_out_kobj_put: static void cpufreq_init_policy(struct cpufreq_policy *policy) { + struct cpufreq_governor *gov = NULL; struct cpufreq_policy new_policy; int ret = 0; memcpy(&new_policy, policy, sizeof(*policy)); + /* Update governor of new_policy to the governor used before hotplug */ + gov = __find_governor(per_cpu(cpufreq_cpu_governor, policy->cpu)); + if (gov) + pr_debug("Restoring governor %s for cpu %d\n", + policy->governor->name, policy->cpu); + else + gov = CPUFREQ_DEFAULT_GOVERNOR; + + new_policy.governor = gov; + /* Use the default policy if its valid. */ if (cpufreq_driver->setpolicy) - cpufreq_parse_governor(policy->governor->name, - &new_policy.policy, NULL); - - /* assure that the starting sequence is run in cpufreq_set_policy */ - policy->governor = NULL; + cpufreq_parse_governor(gov->name, &new_policy.policy, NULL); /* set default policy */ ret = cpufreq_set_policy(policy, &new_policy); @@ -949,6 +954,8 @@ static struct cpufreq_policy *cpufreq_policy_restore(unsigned int cpu) read_unlock_irqrestore(&cpufreq_driver_lock, flags); + policy->governor = NULL; + return policy; } @@ -1036,7 +1043,6 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif, unsigned long flags; #ifdef CONFIG_HOTPLUG_CPU struct cpufreq_policy *tpolicy; - struct cpufreq_governor *gov; #endif if (cpu_is_offline(cpu)) @@ -1094,7 +1100,6 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif, else policy->cpu = cpu; - policy->governor = CPUFREQ_DEFAULT_GOVERNOR; cpumask_copy(policy->cpus, cpumask_of(cpu)); init_completion(&policy->kobj_unregister); @@ -1179,15 +1184,6 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif, blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_START, policy); -#ifdef CONFIG_HOTPLUG_CPU - gov = __find_governor(per_cpu(cpufreq_cpu_governor, cpu)); - if (gov) { - policy->governor = gov; - pr_debug("Restoring governor %s for cpu %d\n", - policy->governor->name, cpu); - } -#endif - if (!frozen) { ret = cpufreq_add_dev_interface(policy, dev); if (ret) @@ -1312,11 +1308,9 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, } } -#ifdef CONFIG_HOTPLUG_CPU if (!cpufreq_driver->setpolicy) strncpy(per_cpu(cpufreq_cpu_governor, cpu), policy->governor->name, CPUFREQ_NAME_LEN); -#endif down_read(&policy->rwsem); cpus = cpumask_weight(policy->cpus); @@ -1955,9 +1949,7 @@ EXPORT_SYMBOL_GPL(cpufreq_register_governor); void cpufreq_unregister_governor(struct cpufreq_governor *governor) { -#ifdef CONFIG_HOTPLUG_CPU int cpu; -#endif if (!governor) return; @@ -1965,14 +1957,12 @@ void cpufreq_unregister_governor(struct cpufreq_governor *governor) if (cpufreq_disabled()) return; -#ifdef CONFIG_HOTPLUG_CPU for_each_present_cpu(cpu) { if (cpu_online(cpu)) continue; if (!strcmp(per_cpu(cpufreq_cpu_governor, cpu), governor->name)) strcpy(per_cpu(cpufreq_cpu_governor, cpu), "\0"); } -#endif mutex_lock(&cpufreq_governor_mutex); list_del(&governor->governor_list); -- 1.7.12.rc2.18.g61b472e

11 years, 2 months

next boot: 45 pass, 2 fail (next-20140306)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: next Git describe: next-20140306 Failed boot tests (console logs at the end) =========================================== ste-snowball: FAIL: multi_v7_defconfig omap4-panda: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.3 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 50.7 sec am335x-boneblack PASS: 0 min 25.6 sec omap3-beagle-xm PASS: 1 min 0.9 sec legacy,3530beagle PASS: 1 min 19.7 sec omap4-panda PASS: 1 min 6.7 sec omap3-overo-tobi PASS: 0 min 23.0 sec am335x-bone PASS: 0 min 28.0 sec omap3-overo-storm-tobi PASS: 0 min 25.4 sec omap5-uevm PASS: 1 min 5.6 sec omap4-panda-es PASS: 1 min 6.7 sec legacy,3730storm PASS: 0 min 23.5 sec legacy,3530overo PASS: 0 min 20.9 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 48.8 sec sun7i-a20-cubieboard2 PASS: 0 min 14.3 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.2 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.4 sec imx6q-wandboard PASS: 0 min 16.7 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.8 sec sun4i-a10-cubieboard PASS: 0 min 17.0 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.9 sec mvebu_v7_defconfig ------------------ armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 20.2 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 37.1 sec multi_v7_defconfig ------------------ qcom-apq8074-dragonboard PASS: 0 min 59.4 sec ste-snowball FAIL: 0 min 33.5 sec tegra30-beaver PASS: 0 min 19.5 sec am335x-boneblack PASS: 0 min 23.9 sec omap3-beagle-xm PASS: 0 min 50.9 sec sun7i-a20-cubieboard2 PASS: 0 min 14.3 sec armada-370-mirabox PASS: 0 min 22.3 sec omap4-panda FAIL: 2 min 18.8 sec armada-xp-openblocks-ax3-4 PASS: 0 min 25.1 sec sun4i-a10-cubieboard PASS: 0 min 18.7 sec bcm28155-ap PASS: 1 min 4.1 sec omap3-overo-tobi PASS: 0 min 21.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.8 sec am335x-bone PASS: 0 min 26.3 sec omap3-overo-storm-tobi PASS: 0 min 24.7 sec omap5-uevm PASS: 1 min 52.4 sec imx6q-wandboard PASS: 0 min 16.2 sec omap4-panda-es PASS: 0 min 50.4 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 33.2 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.1 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 17.1 sec Console logs for failures ========================= multi_v7_defconfig ------------------ ste-snowball: FAIL: last 80 lines of boot log: ---------------------------------------------- (user:khilman) Reboot snowball Reboot: snowball ; ip9258 2 2 : ('off', 6, 'on') , sleep 6, MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ U8500 $ version U8500 $ versionsetenv ethaddr 6e:e6:84:36:8e:9e U-Boot 2009.11 (sept. 19 2011 - 17:03:11) U8500 $ setenv ethaddr 6e:e6:84:36:8e:9esetenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 Can't overwrite "ethaddr" U8500 $ setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' U8500 $ setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none'if test -n ${initenv}; then run initenv; fi U8500 $ if test -n ${initenv}; then run initenv; fiif test -n ${preboot}; then run preboot; fi U8500 $ if test -n ${preboot}; then run preboot; fisetenv autoload no; setenv autoboot no U8500 $ setenv autoload no; setenv autoboot nodhcp U8500 $ dhcp smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e BOOTP broadcast 1 BOOTP broadcast 2 DHCP client bound to address 192.168.1.159 U8500 $ setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 U8500 $ if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi U8500 $ tftp 0x00800000 192.168.1.2:tmp/snowball-2zSz_r/tmpPkFIZV-uImage tftp 0x00800000 192.168.1.2:tmp/snowball-2zSz_r/tmpPkFIZV-uImage smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e Using smc911x-0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.159 Filename 'tmp/snowball-2zSz_r/tmpPkFIZV-uImage'. Load address: 0x800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ##################################################### done Bytes transferred = 4590977 (460d81 hex) U8500 $printenv bootargs printenv bootargs bootargs=console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 ip=192.168.1.159:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none U8500 $ bootm 0x00800000 bootm 0x00800000 ## Booting kernel from Legacy Image at 00800000 ... Image Name: Linux Image Type: ARM Linux Kernel Image (uncompressed) Data Size: 4590913 Bytes = 4.4 MB Load Address: 00008000 Entry Point: 00008000 Loading Kernel Image ... OK OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 33.51 seconds. # PYBOOT: Result: FAIL omap4-panda: FAIL: last 80 lines of boot log: --------------------------------------------- [ 1.509765] loop: module loaded [ 1.520233] pegasus: v0.9.3 (2013/04/25), Pegasus/Pegasus II USB Ethernet driver [ 1.528045] usbcore: registered new interface driver pegasus [ 1.534027] usbcore: registered new interface driver asix [ 1.539733] usbcore: registered new interface driver ax88179_178a [ 1.546173] usbcore: registered new interface driver cdc_ether [ 1.552307] usbcore: registered new interface driver r815x [ 1.558105] usbcore: registered new interface driver smsc75xx [ 1.564178] usbcore: registered new interface driver smsc95xx [ 1.570220] usbcore: registered new interface driver net1080 [ 1.576202] usbcore: registered new interface driver cdc_subset [ 1.582427] usbcore: registered new interface driver zaurus [ 1.588378] usbcore: registered new interface driver cdc_ncm [ 1.594299] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 1.601135] ehci-pci: EHCI PCI platform driver [ 1.605834] ehci-platform: EHCI generic platform driver [ 1.611511] ehci-omap: OMAP-EHCI Host Controller driver [ 1.637329] ehci-omap 4a064c00.ehci: EHCI Host Controller [ 1.642974] ehci-omap 4a064c00.ehci: new USB bus registered, assigned bus number 1 [ 1.651336] ehci-omap 4a064c00.ehci: irq 109, io mem 0x4a064c00 [ 1.674835] ehci-omap 4a064c00.ehci: USB 2.0 started, EHCI 1.00 [ 1.681915] hub 1-0:1.0: USB hub found [ 1.685913] hub 1-0:1.0: 3 ports detected [ 1.690673] ehci-orion: EHCI orion driver [ 1.695098] SPEAr-ehci: EHCI SPEAr driver [ 1.699462] tegra-ehci: Tegra EHCI driver [ 1.704437] usbcore: registered new interface driver usb-storage [ 1.712799] mousedev: PS/2 mouse device common for all mice [ 1.721099] i2c /dev entries driver [ 1.727874] sdhci: Secure Digital Host Controller Interface driver [ 1.734313] sdhci: Copyright(c) Pierre Ossman [ 1.739837] omap_hsmmc 4809c000.mmc: unable to get vmmc regulator -517 [ 1.746734] platform 4809c000.mmc: Driver omap_hsmmc requests probe deferral [ 1.754425] omap_hsmmc 480d5000.mmc: unable to get vmmc regulator -517 [ 1.761322] platform 480d5000.mmc: Driver omap_hsmmc requests probe deferral [ 1.769226] sdhci-pltfm: SDHCI platform and OF driver helper [ 1.776153] usbcore: registered new interface driver usbhid [ 1.781982] usbhid: USB HID core driver [ 1.790618] TCP: cubic registered [ 1.794067] NET: Registered protocol family 17 [ 1.798980] Key type dns_resolver registered [ 1.804077] Power Management for TI OMAP4+ devices. [ 1.809204] Power Management for TI OMAP4. [ 1.813507] OMAP4 PM: u-boot >= v2012.07 is required for full PM support [ 1.820617] Registering SWP/SWPB emulation handler [ 1.826843] vwl1271: 1800 mV [ 1.834991] Skipping twl internal clock init and using bootloader value (unknown osc rate) [ 1.845092] twl 0-0048: PIH (irq 39) nested IRQs [ 1.851684] twl_rtc rtc.10: Enabling TWL-RTC [ 1.858673] twl_rtc rtc.10: rtc core: registered rtc.10 as rtc0 [ 1.865844] VAUX1_6030: 1000 <--> 3000 mV at 1800 mV [ 1.872039] VAUX2_6030: 1200 <--> 2800 mV at 1800 mV [ 1.878265] VAUX3_6030: 1000 <--> 3000 mV at 1200 mV [ 1.884460] VMMC: 1200 <--> 3000 mV at 3000 mV [ 1.890197] VPP: 1800 <--> 2500 mV at 1900 mV [ 1.895812] VUSIM: 1200 <--> 2900 mV at 1800 mV [ 1.900848] VDAC: 1800 mV [ 1.900848] VANA: 2100 mV [ 1.908416] VCXIO: 1800 mV [ 1.908447] VUSB: 3300 mV [ 1.915618] V1V8: 1800 mV [ 1.919311] V2V1: 2100 mV [ 1.927947] omap_i2c 48070000.i2c: bus 0 rev0.10 at 400 kHz [ 1.935821] omap_i2c 48072000.i2c: bus 1 rev0.10 at 400 kHz [ 1.947082] omap_i2c 48060000.i2c: bus 2 rev0.10 at 100 kHz [ 1.954803] omap_i2c 48350000.i2c: bus 3 rev0.10 at 400 kHz [ 1.963165] omap_hsmmc 4809c000.mmc: pins are not configured from the driver [ 2.005218] usb 1-1: new high-speed USB device number 2 using ehci-omap [ 2.128143] twl_rtc rtc.10: setting system clock to 2014-03-06 10:34:51 UTC (1394102091) [ 2.136657] spear_cpufreq: Invalid cpufreq_tbl [ 2.161193] hub 1-1:1.0: USB hub found [ 2.165710] hub 1-1:1.0: 5 ports detected [ 4.165588] mmc0: host does not support reading read-only switch. assuming write-enable. [ 4.176177] mmc0: new high speed SD card at address aaaa [ 4.182342] mmcblk0: mmc0:aaaa SD02G 1.84 GiB [ 4.188720] mmcblk0: p1 p2 ~$off # PYBOOT: Exception: kernel: ERROR: failed to boot: <class 'pexpect.TIMEOUT'> # PYBOOT: Time: 138.76 seconds. # PYBOOT: Result: FAIL

11 years, 2 months

[PATCH] ASoC: dapm: Sprinkle lockdep asserts through the code

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Try to spot locking issues by asserting that the DAPM mutex is held when it should be. There's a bit of fun due to us not requiring the lock to be held prior to the card being instantiated which mean we need to wrap the assert in some paths and this isn't methodical by any stretch of the imagination. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- I've only compile tested this so it's entirely possible there's some oversights here - at this point I'm mostly just throwing it out there for people to play with as a work in progress. sound/soc/soc-dapm.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 3728e21..c8a780d 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -111,6 +111,12 @@ static int dapm_down_seq[] = { [snd_soc_dapm_post] = 14, }; +static void dapm_assert_locked(struct snd_soc_dapm_context *dapm) +{ + if (dapm->card && dapm->card->instantiated) + lockdep_assert_held(&dapm->card->dapm_mutex); +} + static void pop_wait(u32 pop_time) { if (pop_time) @@ -144,6 +150,8 @@ static bool dapm_dirty_widget(struct snd_soc_dapm_widget *w) static void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason) { + dapm_assert_locked(w->dapm); + if (!dapm_dirty_widget(w)) { dev_vdbg(w->dapm->dev, "Marking %s dirty due to %s\n", w->name, reason); @@ -356,6 +364,8 @@ static void dapm_reset(struct snd_soc_card *card) { struct snd_soc_dapm_widget *w; + lockdep_assert_held(&card->dapm_mutex); + memset(&card->dapm_stats, 0, sizeof(card->dapm_stats)); list_for_each_entry(w, &card->widgets, list) { @@ -1750,6 +1760,8 @@ static int dapm_power_widgets(struct snd_soc_card *card, int event) ASYNC_DOMAIN_EXCLUSIVE(async_domain); enum snd_soc_bias_level bias; + lockdep_assert_held(&card->dapm_mutex); + trace_snd_soc_dapm_start(card); list_for_each_entry(d, &card->dapm_list, list) { @@ -2045,6 +2057,8 @@ static int soc_dapm_mux_update_power(struct snd_soc_card *card, struct snd_soc_dapm_path *path; int found = 0; + lockdep_assert_held(&card->dapm_mutex); + /* find dapm widget path assoc with kcontrol */ dapm_kcontrol_for_each_path(path, kcontrol) { if (!path->name || !e->texts[mux]) @@ -2095,6 +2109,8 @@ static int soc_dapm_mixer_update_power(struct snd_soc_card *card, struct snd_soc_dapm_path *path; int found = 0; + lockdep_assert_held(&card->dapm_mutex); + /* find dapm widget path assoc with kcontrol */ dapm_kcontrol_for_each_path(path, kcontrol) { found = 1; @@ -2260,6 +2276,8 @@ static int snd_soc_dapm_set_pin(struct snd_soc_dapm_context *dapm, { struct snd_soc_dapm_widget *w = dapm_find_widget(dapm, pin, true); + dapm_assert_locked(dapm); + if (!w) { dev_err(dapm->dev, "ASoC: DAPM unknown pin %s\n", pin); return -EINVAL; -- 1.9.0

11 years, 2 months

[PATCH] ASoC: dapm: Staticise dapm_mark_dirty()

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> The function is not called outside soc-dapm.c so there is no need for it to be exported. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- include/sound/soc-dapm.h | 1 - sound/soc/soc-dapm.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index 04d32d8..ef78f56 100644 --- a/include/sound/soc-dapm.h +++ b/include/sound/soc-dapm.h @@ -449,7 +449,6 @@ int snd_soc_dapm_ignore_suspend(struct snd_soc_dapm_context *dapm, void snd_soc_dapm_auto_nc_codec_pins(struct snd_soc_codec *codec); /* Mostly internal - should not normally be used */ -void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason); void dapm_mark_io_dirty(struct snd_soc_dapm_context *dapm); /* dapm path query */ diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 0d8ba30..3728e21 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -142,7 +142,7 @@ static bool dapm_dirty_widget(struct snd_soc_dapm_widget *w) return !list_empty(&w->dirty); } -void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason) +static void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason) { if (!dapm_dirty_widget(w)) { dev_vdbg(w->dapm->dev, "Marking %s dirty due to %s\n", @@ -150,7 +150,6 @@ void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason) list_add_tail(&w->dirty, &w->dapm->card->dapm_dirty); } } -EXPORT_SYMBOL_GPL(dapm_mark_dirty); void dapm_mark_io_dirty(struct snd_soc_dapm_context *dapm) { -- 1.9.0

11 years, 2 months

arm-soc boot: 41 pass, 2 fail (v3.14-rc3-511-g55b8643)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.14-rc3-511-g55b8643 Failed boot tests (console logs at the end) =========================================== armada-xp-openblocks-ax3-4: FAIL: mvebu_v7_defconfig ste-snowball: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.3 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 51.7 sec am335x-boneblack PASS: 0 min 25.6 sec omap3-beagle-xm PASS: 1 min 0.4 sec legacy,3530beagle PASS: 1 min 18.2 sec omap4-panda PASS: 1 min 5.9 sec omap3-overo-tobi PASS: 0 min 22.9 sec am335x-bone PASS: 0 min 27.3 sec omap3-overo-storm-tobi PASS: 0 min 25.4 sec omap4-panda-es PASS: 1 min 5.9 sec legacy,3730storm PASS: 0 min 23.4 sec legacy,3530overo PASS: 0 min 21.2 sec multi_lpae_defconfig -------------------- sun7i-a20-cubieboard2 PASS: 0 min 14.3 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.5 sec imx6q-wandboard PASS: 0 min 17.0 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 11.7 sec sun4i-a10-cubieboard PASS: 0 min 16.9 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.8 sec mvebu_v7_defconfig ------------------ armada-xp-openblocks-ax3-4 FAIL: 0 min 20.4 sec armada-370-mirabox PASS: 0 min 20.4 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 47.1 sec multi_v7_defconfig ------------------ ste-snowball FAIL: 0 min 33.5 sec tegra30-beaver PASS: 0 min 25.0 sec am335x-boneblack PASS: 0 min 23.6 sec omap3-beagle-xm PASS: 0 min 50.2 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.5 sec omap4-panda PASS: 1 min 0.2 sec armada-xp-openblocks-ax3-4 PASS: 0 min 25.0 sec sun4i-a10-cubieboard PASS: 0 min 18.7 sec bcm28155-ap PASS: 0 min 58.8 sec omap3-overo-tobi PASS: 0 min 21.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.0 sec am335x-bone PASS: 0 min 26.2 sec omap3-overo-storm-tobi PASS: 0 min 20.6 sec imx6q-wandboard PASS: 0 min 17.4 sec omap4-panda-es PASS: 0 min 51.2 sec imx6dl-wandboard,wand-dual PASS: 0 min 18.0 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 33.1 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.6 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.6 sec Console logs for failures ========================= mvebu_v7_defconfig ------------------ armada-xp-openblocks-ax3-4: FAIL: last 80 lines of boot log: ------------------------------------------------------------ mv_xor d0060900.xor: Marvell shared XOR driver mv_xor d0060900.xor: Marvell XOR: ( xor cpy ) mv_xor d0060900.xor: Marvell XOR: ( xor cpy ) mv_xor d00f0900.xor: Marvell shared XOR driver mv_xor d00f0900.xor: Marvell XOR: ( xor cpy ) mv_xor d00f0900.xor: Marvell XOR: ( xor cpy ) Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled d0012000.serial: ttyS0 at MMIO 0xd0012000 (irq = 20, base_baud = 15625000) is a 16550A console [ttyS0] enabled d0012100.serial: ttyS1 at MMIO 0xd0012100 (irq = 21, base_baud = 15625000) is a 16550A sata_mv d00a0000.sata: version 1.28 sata_mv d00a0000.sata: error getting phy -38 Unable to handle kernel NULL pointer dereference at virtual address 00000054 pgd = c0004000 [00000054] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0-rc3-00511-g55b8643 #1 task: ee82ab80 ti: ee83c000 task.ti: ee83c000 PC is at __clk_put+0x1c/0x8c LR is at clk_prepare_lock+0x10/0xfc pc : [<c02c92b4>] lr : [<c02c6960>] psr: 60000113 sp : ee83de08 ip : 00000000 fp : ee807900 r10: ee397c90 r9 : ee90b000 r8 : ffffffda r7 : ee90b010 r6 : 00000000 r5 : eeb080d0 r4 : 00000000 r3 : ee82ab80 r2 : ee82ab80 r1 : ee83ddf8 r0 : 00000054 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 10c53c7d Table: 0000406a DAC: 00000015 Process swapper/0 (pid: 1, stack limit = 0xee83c240) Stack: (0xee83de08 to 0xee83e000) de00: 00000001 c0206700 ee910c60 c00ffbcc c0516d30 0000001f de20: ee910c60 00000002 c03ea324 00000000 74726f70 ee910030 00000001 ee39ac18 de40: 0000008c ee90b010 c054f518 00000000 c054f518 c0516d30 0000008c ee83c030 de60: 00000000 c01cb250 c01cb238 c0588308 ee90b010 c01c99d8 00000007 ee90b010 de80: c054f518 ee90b044 00000000 c01c9c58 00000000 c054f518 c01c9bc0 c01c80d0 dea0: ee85a7dc ee85e134 c054f518 ee397d00 c054e478 c01c9280 c0499614 c05652c0 dec0: c054f518 c054f518 00000006 c05652c0 c05652c0 c01ca29c 00000000 c052c980 dee0: 00000006 c0516d60 c052c980 c000893c 0000008c ef7fce08 c04810f0 00000000 df00: 00000000 c04df2e0 00000063 ee83df20 c0035d80 c0035da4 00000113 ffffffff df20: ef7fce1b c03e3b20 0000008c c0035f74 c04dea80 00000006 ef7fce26 00000006 df40: c053deb0 c052c980 00000006 c05652c0 c05652c0 c050250c 0000008c c0525d14 df60: c0525d08 c0502c40 00000006 00000006 c050250c d45efc5d 0fbbed6f 4faffddf df80: fbff7bce 00000000 c03c6ffc 00000000 00000000 00000000 00000000 00000000 dfa0: 00000000 c03c7004 00000000 c000e338 00000000 00000000 00000000 00000000 dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 9757ffff dd7dfd3f [<c02c92b4>] (__clk_put) from [<c0206700>] (mv_platform_probe+0x2ac/0x414) [<c0206700>] (mv_platform_probe) from [<c01cb250>] (platform_drv_probe+0x18/0x48) [<c01cb250>] (platform_drv_probe) from [<c01c99d8>] (really_probe+0x80/0x214) [<c01c99d8>] (really_probe) from [<c01c9c58>] (__driver_attach+0x98/0x9c) [<c01c9c58>] (__driver_attach) from [<c01c80d0>] (bus_for_each_dev+0x60/0x94) [<c01c80d0>] (bus_for_each_dev) from [<c01c9280>] (bus_add_driver+0x148/0x1f0) [<c01c9280>] (bus_add_driver) from [<c01ca29c>] (driver_register+0x78/0xf8) [<c01ca29c>] (driver_register) from [<c0516d60>] (mv_init+0x30/0x50) [<c0516d60>] (mv_init) from [<c000893c>] (do_one_initcall+0xf8/0x144) [<c000893c>] (do_one_initcall) from [<c0502c40>] (kernel_init_freeable+0x138/0x1d8) [<c0502c40>] (kernel_init_freeable) from [<c03c7004>] (kernel_init+0x8/0xf0) [<c03c7004>] (kernel_init) from [<c000e338>] (ret_from_fork+0x14/0x3c) Code: 8a000012 ebfff5a8 e2840054 f57ff05b (e1903f9f) ---[ end trace 1cfd9c73b4ce09ca ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b CPU1: stopping CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.14.0-rc3-00511-g55b8643 #1 [<c0014940>] (unwind_backtrace) from [<c0011194>] (show_stack+0x10/0x14) [<c0011194>] (show_stack) from [<c03cb7fc>] (dump_stack+0x80/0x90) [<c03cb7fc>] (dump_stack) from [<c0013d04>] (handle_IPI+0x148/0x170) [<c0013d04>] (handle_IPI) from [<c00085cc>] (armada_370_xp_handle_irq+0xac/0xb0) [<c00085cc>] (armada_370_xp_handle_irq) from [<c0011cc0>] (__irq_svc+0x40/0x50) Exception stack(0xee877fa0 to 0xee877fe8) 7fa0: eefe55b8 00000000 0000094e 00000000 ee876000 c05384ac c03d2d00 ee876000 7fc0: c0565176 00000001 c0565176 ee876000 00000000 ee877fe8 c000eeac c00558b8 7fe0: 60000113 ffffffff [<c0011cc0>] (__irq_svc) from [<c00558b8>] (cpu_startup_entry+0xf4/0x134) [<c00558b8>] (cpu_startup_entry) from [<000086c4>] (0x86c4) ~$off # PYBOOT: Exception: kernel: Unable to handle kernel NULL pointer dereference at virtual address 00000054 # PYBOOT: Time: 20.40 seconds. # PYBOOT: Result: FAIL multi_v7_defconfig ------------------ ste-snowball: FAIL: last 80 lines of boot log: ---------------------------------------------- CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ U8500 $ version version U-Boot 2009.11 (sept. 19 2011 - 17:03:11) U8500 $ setenv ethaddr 6e:e6:84:36:8e:9e setenv ethaddr 6e:e6:84:36:8e:9e Can't overwrite "ethaddr" U8500 $ setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 U8500 $ setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' U8500 $ if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi U8500 $ if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi U8500 $ setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no U8500 $ dhcp dhcp smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e BOOTP broadcast 1 BOOTP broadcast 2 DHCP client bound to address 192.168.1.159 U8500 $ setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 U8500 $ if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi U8500 $ tftp 0x00800000 192.168.1.2:tmp/snowball-4Fyney/tmpgZKOJj-uImage tftp 0x00800000 192.168.1.2:tmp/snowball-4Fyney/tmpgZKOJj-uImage smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e Using smc911x-0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.159 Filename 'tmp/snowball-4Fyney/tmpgZKOJj-uImage'. Load address: 0x800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ################################################## done Bytes transferred = 4547113 (456229 hex) U8500 $ printenv bootargs printenv bootargs bootargs=console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 ip=192.168.1.159:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none U8500 $ bootm 0x00800000 bootm 0x00800000 ## Booting kernel from Legacy Image at 00800000 ... Image Name: Linux Image Type: ARM Linux Kernel Image (uncompressed) Data Size: 4547049 Bytes = 4.3 MB Load Address: 00008000 Entry Point: 00008000 Loading Kernel Image ... OK OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 33.50 seconds. # PYBOOT: Result: FAIL

11 years, 2 months

Re: backport 'add CPU power management menu/entries' issue

by Alex Shi

> You should apply ARM:7862/1 before the suspend series and then do not > miss: Think over the __get_cpu_var changes in upstream. I am going to give up too much patchset backporting for this change. and going to backport the this_cpu_ptr to __get_cpu_var by the following patch. If we have to backport __get_cpu_var change later, it is easy to revert this patch. What's your opinions on this? ========= */ - for (slots = this_cpu_ptr(bp_on_reg), i = 0; i < core_num_brps; ++i) { + for (slots = __get_cpu_var(bp_on_reg), i = 0; i < core_num_brps; ++i) { if (slots[i]) { hw_breakpoint_control(slots[i], HW_BREAKPOINT_RESTORE); } else { @@ -870,7 +870,7 @@ static void hw_breakpoint_reset(void *unused) } } - for (slots = this_cpu_ptr(wp_on_reg), i = 0; i < core_num_wrps; ++i) { + for (slots = __get_cpu_var(wp_on_reg), i = 0; i < core_num_wrps; ++i) { > > 65c021bb496a46ec06264e9d5e836dffa70ef380 > arm64: kernel: restore HW breakpoint registers in cpu_suspend > > fb4a96029c8a091c4365f57307e098543b48a222 > arm64: kernel: fix per-cpu offset restore on resume > I merged them both. Thanks! The following is all patches for this feature, the 13th is just mentioned patch. the git tree is git://git.linaro.org/kernel/linux-linaro-stable.git linux-linaro-lsk-test. -rw-rw-r-- 1 alexs alexs 7620 Mar 6 11:14 0001-arm64-kernel-build-MPIDR_EL1-hash-function-data-stru.patch -rw-rw-r-- 1 alexs alexs 4105 Mar 6 11:14 0002-arm64-kernel-suspend-resume-registers-save-restore.patch -rw-rw-r-- 1 alexs alexs 16485 Mar 6 11:14 0003-arm64-kernel-cpu_-suspend-resume-implementation.patch -rw-rw-r-- 1 alexs alexs 2688 Mar 6 11:14 0004-arm64-kernel-implement-fpsimd-CPU-PM-notifier.patch -rw-rw-r-- 1 alexs alexs 1863 Mar 6 11:14 0005-arm-kvm-implement-CPU-PM-notifier.patch -rw-rw-r-- 1 alexs alexs 5551 Mar 6 11:14 0006-arm64-kernel-refactor-code-to-install-uninstall-brea.patch -rw-rw-r-- 1 alexs alexs 5286 Mar 6 11:14 0007-arm64-kernel-implement-HW-breakpoints-CPU-PM-notifie.patch -rw-rw-r-- 1 alexs alexs 3195 Mar 6 11:14 0008-arm64-enable-generic-clockevent-broadcast.patch -rw-rw-r-- 1 alexs alexs 1394 Mar 6 11:14 0009-arm64-kernel-add-CPU-idle-call.patch -rw-rw-r-- 1 alexs alexs 2132 Mar 6 11:14 0010-arm64-kernel-add-PM-build-infrastructure.patch -rw-rw-r-- 1 alexs alexs 892 Mar 6 11:14 0011-arm64-add-CPU-power-management-menu-entries.patch -rw-rw-r-- 1 alexs alexs 1385 Mar 6 11:14 0012-arm64-kernel-add-MPIDR_EL1-accessors-macros.patch -rw-rw-r-- 1 alexs alexs 1902 Mar 6 11:14 0013-arm64-hw_breakpoint-compile-error-fixing.patch -rw-rw-r-- 1 alexs alexs 4343 Mar 6 11:14 0014-arm64-kernel-restore-HW-breakpoint-registers-in-cpu_.patch -rw-rw-r-- 1 alexs alexs 4353 Mar 6 11:14 0015-arm64-percpu-implement-optimised-pcpu-access-using-t.patch -rw-rw-r-- 1 alexs alexs 1814 Mar 6 11:14 0016-arm64-kernel-fix-per-cpu-offset-restore-on-resume.patch alexs@alex-mac:~/lsk/kernel$ Thanks!

11 years, 2 months

mainline boot: 47 pass, 0 fail (v3.14-rc5-185-gc3bebc7)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc5-185-gc3bebc7 Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.1 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 50.8 sec am335x-boneblack PASS: 0 min 25.6 sec omap3-beagle-xm PASS: 1 min 0.8 sec legacy,3530beagle PASS: 0 min 53.8 sec omap4-panda PASS: 1 min 5.7 sec omap3-overo-tobi PASS: 0 min 22.9 sec am335x-bone PASS: 0 min 32.4 sec omap3-overo-storm-tobi PASS: 0 min 24.8 sec omap5-uevm PASS: 1 min 7.5 sec omap4-panda-es PASS: 1 min 10.6 sec legacy,3730storm PASS: 0 min 20.7 sec legacy,3530overo PASS: 0 min 21.2 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 52.2 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 17.0 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 0 min 58.9 sec bcm_defconfig ------------- bcm28155-ap PASS: 1 min 14.5 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.9 sec sun4i-a10-cubieboard PASS: 0 min 17.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.0 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 17.2 sec tegra30-beaver PASS: 0 min 22.0 sec am335x-boneblack PASS: 0 min 23.3 sec omap3-beagle-xm PASS: 0 min 49.3 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.0 sec omap4-panda PASS: 0 min 53.6 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.9 sec sun4i-a10-cubieboard PASS: 0 min 18.5 sec bcm28155-ap PASS: 1 min 9.6 sec omap3-overo-tobi PASS: 0 min 21.5 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.9 sec am335x-bone PASS: 0 min 25.8 sec omap3-overo-storm-tobi PASS: 0 min 23.9 sec omap5-uevm PASS: 1 min 46.3 sec imx6q-wandboard PASS: 0 min 17.4 sec omap4-panda-es PASS: 0 min 55.8 sec imx6dl-wandboard,wand-dual PASS: 0 min 18.0 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 32.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.0 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.5 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 20.1 sec

11 years, 2 months

next boot: 46 pass, 1 fail (next-20140305)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: next Git describe: next-20140305 Failed boot tests (console logs at the end) =========================================== ste-snowball: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.3 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 51.3 sec am335x-boneblack PASS: 0 min 26.0 sec omap3-beagle-xm PASS: 1 min 0.8 sec legacy,3530beagle PASS: 1 min 1.4 sec omap4-panda PASS: 1 min 5.2 sec omap3-overo-tobi PASS: 0 min 23.4 sec am335x-bone PASS: 0 min 27.3 sec omap3-overo-storm-tobi PASS: 0 min 25.1 sec omap5-uevm PASS: 1 min 7.5 sec omap4-panda-es PASS: 1 min 9.1 sec legacy,3730storm PASS: 0 min 23.6 sec legacy,3530overo PASS: 0 min 21.0 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 47.1 sec sun7i-a20-cubieboard2 PASS: 0 min 14.3 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.8 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.8 sec sun4i-a10-cubieboard PASS: 0 min 12.5 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.8 sec mvebu_v7_defconfig ------------------ armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 20.3 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.0 sec multi_v7_defconfig ------------------ qcom-apq8074-dragonboard PASS: 0 min 58.8 sec ste-snowball FAIL: 0 min 30.5 sec tegra30-beaver PASS: 0 min 19.5 sec am335x-boneblack PASS: 0 min 23.7 sec omap3-beagle-xm PASS: 0 min 47.2 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.2 sec omap4-panda PASS: 1 min 2.8 sec armada-xp-openblocks-ax3-4 PASS: 0 min 25.4 sec sun4i-a10-cubieboard PASS: 0 min 18.6 sec bcm28155-ap PASS: 1 min 9.4 sec omap3-overo-tobi PASS: 0 min 21.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.8 sec am335x-bone PASS: 0 min 26.4 sec omap3-overo-storm-tobi PASS: 0 min 24.2 sec omap5-uevm PASS: 1 min 49.8 sec imx6q-wandboard PASS: 0 min 17.1 sec omap4-panda-es PASS: 0 min 52.6 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 34.0 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.0 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.9 sec Console logs for failures ========================= multi_v7_defconfig ------------------ ste-snowball: FAIL: last 80 lines of boot log: ---------------------------------------------- Command(snowball console)> hardreset (user:khilman) Reboot snowball Reboot: snowball ; ip9258 2 2 : ('off', 6, 'on') , sleep 6, MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ U8500 $ version U8500 $ versionsetenv ethaddr 6e:e6:84:36:8e:9e U-Boot 2009.11 (sept. 19 2011 - 17:03:11) U8500 $ setenv ethaddr 6e:e6:84:36:8e:9esetenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 Can't overwrite "ethaddr" U8500 $ setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' U8500 $ setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none'if test -n ${initenv}; then run initenv; fi U8500 $ if test -n ${initenv}; then run initenv; fiif test -n ${preboot}; then run preboot; fi U8500 $ if test -n ${preboot}; then run preboot; fisetenv autoload no; setenv autoboot no U8500 $ setenv autoload no; setenv autoboot nodhcp U8500 $ dhcp smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e BOOTP broadcast 1 DHCP client bound to address 192.168.1.159 U8500 $ setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 U8500 $ if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi U8500 $tftp 0x00800000 192.168.1.2:tmp/snowball-Yd5_8M/tmpJ0yLBw-uImage tftp 0x00800000 192.168.1.2:tmp/snowball-Yd5_8M/tmpJ0yLBw-uImage smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e Using smc911x-0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.159 Filename 'tmp/snowball-Yd5_8M/tmpJ0yLBw-uImage'. Load address: 0x800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ##################################################### done Bytes transferred = 4590129 (460a31 hex) U8500 $ printenv bootargs printenv bootargs bootargs=console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 ip=192.168.1.159:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none U8500 $ bootm 0x00800000 bootm 0x00800000 ## Booting kernel from Legacy Image at 00800000 ... Image Name: Linux Image Type: ARM Linux Kernel Image (uncompressed) Data Size: 4590065 Bytes = 4.4 MB Load Address: 00008000 Entry Point: 00008000 Loading Kernel Image ... OK OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 30.50 seconds. # PYBOOT: Result: FAIL

11 years, 2 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel