On Fri, May 22, 2026 at 07:53:43AM +0200, Alexander A. Klimov wrote:
kstrtoint() returns "0 on success, -ERANGE on overflow and -EINVAL on parsing error". In contrast, manager_sysfs_remove_store() and manager_sysfs_dump_store() checked for 1 which always failed the operation. I fixed this.
Fixes: f9a21a3f4919 ("staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion.") Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de
v2: style (X,!X instead of X!=0,X==0)
drivers/staging/greybus/audio_manager_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c index fcd518f9540c..581791d566e3 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -44,7 +44,7 @@ static ssize_t manager_sysfs_remove_store(struct kobject *kobj, int num = kstrtoint(buf, 10, &id);
- if (num != 1)
- if (num) return -EINVAL;
Really num is the wrong name. It should be ret. Also the declaration should be at the start of the function... :/
regards, dan carpenter