greybus-dev

greybus-dev@lists.linaro.org

755 discussions

[PATCH] staging: greybus: remove completed GPIO conversion task from TODO

by Archit Anant

The task to convert the Greybus subsystem to the GPIO descriptor interface has been completed. A grep of the directory confirms that no consumer drivers include <linux/gpio.h> or use the legacy integer based GPIO API (gpio_request, gpio_set_value, etc). Remove the stale entry from the TODO file. Signed-off-by: Archit Anant <architanant5(a)gmail.com> --- drivers/staging/greybus/TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO index 6461e0132fe3..43fb6dc3dff0 100644 --- a/drivers/staging/greybus/TODO +++ b/drivers/staging/greybus/TODO @@ -1,5 +1,2 @@ -* Convert all uses of the old GPIO API from <linux/gpio.h> to the - GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO - lines from device tree or ACPI. * Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity, ::enable and ::disable. -- 2.39.5

2 months, 1 week

[PATCH] staging: greybus: audio: Limit scope of jack-related variables

by Lee Yongjun

Move jack-related variable declarations inside the CONFIG_SND_JACK conditional block. These variables are only used when CONFIG_SND_JACK is enabled, so limiting their scope improves code clarity and avoids unused variable warnings when the option is disabled. No functional changes intended. Signed-off-by: Lee Yongjun <jun85566(a)gmail.com> --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 444c53b4e08d..f752d5fbd685 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -935,8 +935,6 @@ static void gbaudio_codec_cleanup(struct gbaudio_module_info *module) void gbaudio_unregister_module(struct gbaudio_module_info *module) { struct snd_soc_component *comp = gbcodec->component; - struct gbaudio_jack *jack, *n; - int mask; dev_dbg(comp->dev, "Unregister %s module\n", module->name); @@ -948,6 +946,8 @@ void gbaudio_unregister_module(struct gbaudio_module_info *module) mutex_unlock(&gbcodec->lock); #ifdef CONFIG_SND_JACK + struct gbaudio_jack *jack, *n; + int mask; /* free jack devices for this module jack_list */ list_for_each_entry_safe(jack, n, &module->jack_list, list) { if (jack == &module->headset) -- 2.34.1

2 months, 1 week

[PATCH 0/1] staging: greybus: fw-core: use %pe for error printing

by Archit Anant

This patch modernizes error printing in the Greybus firmware core driver. It replaces the old 'PTR_ERR' + '%ld' pattern with the newer '%pe' format specifier, which prints error names instead of numbers, making it easy for debuging. Archit Anant (1): staging: greybus: fw-core: use %pe for error printing drivers/staging/greybus/fw-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.39.5

2 months, 1 week

[PATCH] staging: greybus: arche: drop dangling Kconfig symbol

by Randy Dunlap

The Kconfig symbol USB_HSIC_USB3613 is not defined in the kernel source tree. Drop it since it unused. Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> --- Cc: Vaibhav Hiremath <hvaibhav.linux(a)gmail.com> Cc: Johan Hovold <johan(a)kernel.org> Cc: Alex Elder <elder(a)kernel.org> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: greybus-dev(a)lists.linaro.org Cc: linux-staging(a)lists.linux.dev drivers/staging/greybus/Kconfig | 1 - drivers/staging/greybus/arche-platform.c | 4 ---- 2 files changed, 5 deletions(-) --- linux-next-20251219.orig/drivers/staging/greybus/arche-platform.c +++ linux-next-20251219/drivers/staging/greybus/arche-platform.c @@ -23,14 +23,10 @@ #include <linux/of.h> #include "arche_platform.h" -#if IS_ENABLED(CONFIG_USB_HSIC_USB3613) -#include <linux/usb/usb3613.h> -#else static inline int usb3613_hub_mode_ctrl(bool unused) { return 0; } -#endif #define WD_COLDBOOT_PULSE_WIDTH_MS 30 --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig +++ linux-next-20251219/drivers/staging/greybus/Kconfig @@ -206,7 +206,6 @@ endif # GREYBUS_BRIDGED_PHY config GREYBUS_ARCHE tristate "Greybus Arche Platform driver" - depends on USB_HSIC_USB3613 || COMPILE_TEST help Select this option if you have an Arche device.

2 months, 2 weeks

[PATCH v2] greybus: Use bus methods for .probe() and .remove()

by Uwe Kleine-König

These are nearly identical to the respective driver callbacks. The only difference is that .remove() returns void instead of int. The objective is to get rid of users of struct device_driver callbacks .probe() and .remove() to eventually remove these. Acked-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)baylibre.com> --- Changes since (implicit) v1, https://lore.kernel.org/greybus-dev/20251210175943.590059-2-u.kleine-koenig…: - keep tabs in the struct initializer - Add Ack by Johan drivers/greybus/core.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c index 313eb65cf703..45c5437c460f 100644 --- a/drivers/greybus/core.c +++ b/drivers/greybus/core.c @@ -185,13 +185,6 @@ static void greybus_shutdown(struct device *dev) } } -const struct bus_type greybus_bus_type = { - .name = "greybus", - .match = greybus_match_device, - .uevent = greybus_uevent, - .shutdown = greybus_shutdown, -}; - static int greybus_probe(struct device *dev) { struct greybus_driver *driver = to_greybus_driver(dev->driver); @@ -252,7 +245,7 @@ static int greybus_probe(struct device *dev) return 0; } -static int greybus_remove(struct device *dev) +static void greybus_remove(struct device *dev) { struct greybus_driver *driver = to_greybus_driver(dev->driver); struct gb_bundle *bundle = to_gb_bundle(dev); @@ -291,10 +284,17 @@ static int greybus_remove(struct device *dev) pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); pm_runtime_put_noidle(dev); - - return 0; } +const struct bus_type greybus_bus_type = { + .name = "greybus", + .match = greybus_match_device, + .uevent = greybus_uevent, + .probe = greybus_probe, + .remove = greybus_remove, + .shutdown = greybus_shutdown, +}; + int greybus_register_driver(struct greybus_driver *driver, struct module *owner, const char *mod_name) { @@ -305,8 +305,6 @@ int greybus_register_driver(struct greybus_driver *driver, struct module *owner, driver->driver.bus = &greybus_bus_type; driver->driver.name = driver->name; - driver->driver.probe = greybus_probe; - driver->driver.remove = greybus_remove; driver->driver.owner = owner; driver->driver.mod_name = mod_name; base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 -- 2.47.3

2 months, 2 weeks

[PATCH] staging: greybus: add WQ_PERCPU to alloc_workqueue users

by marco.crivellari＠suse.com

The content of this message was lost. It was probably cross-posted to multiple lists and previously handled on another list.

2 months, 2 weeks

[PATCH] greybus: Use bus methods for .probe() and .remove()

by Uwe Kleine-König

These are nearly identical to the respective driver callbacks. The only difference is that .remove() returns void instead of int. The objective is to get rid of users of struct device_driver callbacks .probe() and .remove() to eventually remove these. Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)baylibre.com> --- drivers/greybus/core.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c index 313eb65cf703..927a69feb3fc 100644 --- a/drivers/greybus/core.c +++ b/drivers/greybus/core.c @@ -185,13 +185,6 @@ static void greybus_shutdown(struct device *dev) } } -const struct bus_type greybus_bus_type = { - .name = "greybus", - .match = greybus_match_device, - .uevent = greybus_uevent, - .shutdown = greybus_shutdown, -}; - static int greybus_probe(struct device *dev) { struct greybus_driver *driver = to_greybus_driver(dev->driver); @@ -252,7 +245,7 @@ static int greybus_probe(struct device *dev) return 0; } -static int greybus_remove(struct device *dev) +static void greybus_remove(struct device *dev) { struct greybus_driver *driver = to_greybus_driver(dev->driver); struct gb_bundle *bundle = to_gb_bundle(dev); @@ -291,10 +284,17 @@ static int greybus_remove(struct device *dev) pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); pm_runtime_put_noidle(dev); - - return 0; } +const struct bus_type greybus_bus_type = { + .name = "greybus", + .match = greybus_match_device, + .uevent = greybus_uevent, + .probe = greybus_probe, + .remove = greybus_remove, + .shutdown = greybus_shutdown, +}; + int greybus_register_driver(struct greybus_driver *driver, struct module *owner, const char *mod_name) { @@ -305,8 +305,6 @@ int greybus_register_driver(struct greybus_driver *driver, struct module *owner, driver->driver.bus = &greybus_bus_type; driver->driver.name = driver->name; - driver->driver.probe = greybus_probe; - driver->driver.remove = greybus_remove; driver->driver.owner = owner; driver->driver.mod_name = mod_name; base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449 -- 2.47.3

2 months, 2 weeks

[PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users

by Marco Crivellari

This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari(a)suse.com> Reviewed-by: Johan Hovold <johan(a)kernel.org> --- Changes in v2: - updated commit log removing two paragraph not strictly related to the work. - subject changed removing "drivers/" before the actual prefix. --- drivers/greybus/operation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c index 54ccc434a1f7..7e12ffb2dd60 100644 --- a/drivers/greybus/operation.c +++ b/drivers/greybus/operation.c @@ -1238,7 +1238,7 @@ int __init gb_operation_init(void) goto err_destroy_message_cache; gb_operation_completion_wq = alloc_workqueue("greybus_completion", - 0, 0); + WQ_PERCPU, 0); if (!gb_operation_completion_wq) goto err_destroy_operation_cache; -- 2.51.1

2 months, 2 weeks

[PATCH v4] staging: greybus: lights: avoid NULL deref

by Chaitanya Mishra

gb_lights_light_config() stores channel_count before allocating the channels array. If kcalloc() fails, gb_lights_release() iterates the non-zero count and dereferences light->channels, which is NULL. Allocate channels first and only then publish channels_count so the cleanup path can't walk a NULL pointer. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Link: https://lore.kernel.org/all/20260108103700.15384-1-chaitanyamishra.ai@gmail… Reviewed-by: Rui Miguel Silva <rui.silva(a)linaro.org> Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai(a)gmail.com> --- Changes in v4: - Add Link to v1 and carry Reviewed-by. - Tested: make defconfig, make modules_prepare, make M=drivers/staging/greybus/ modules (AWS EC2 eu-central-2, Amazon Linux 2023 x86_64). Changes in v3: - Add version changelog below the --- line (no code changes). drivers/staging/greybus/light.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index e509fdc715db..38c233a706c4 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1008,14 +1008,18 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) if (!strlen(conf.name)) return -EINVAL; - light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); if (!light->name) return -ENOMEM; - light->channels = kcalloc(light->channels_count, + light->channels = kcalloc(conf.channel_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) return -ENOMEM; + /* + * Publish channels_count only after channels allocation so cleanup + * doesn't walk a NULL channels pointer on allocation failure. + */ + light->channels_count = conf.channel_count; /* First we collect all the configurations for all channels */ for (i = 0; i < light->channels_count; i++) { -- 2.50.1 (Apple Git-155)

2 months, 3 weeks

[PATCH] staging: greybus: lights: avoid NULL deref

by Chaitanya Mishra

gb_lights_light_config() stores channel_count before allocating the channels array. If kcalloc() fails, gb_lights_release() iterates the non-zero count and dereferences light->channels, which is NULL. Allocate channels first and only then publish channels_count so the cleanup path can't walk a NULL pointer. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai(a)gmail.com> --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index e509fdc715db..4c9ad9ea8827 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1008,14 +1008,14 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) if (!strlen(conf.name)) return -EINVAL; - light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); if (!light->name) return -ENOMEM; - light->channels = kcalloc(light->channels_count, + light->channels = kcalloc(conf.channel_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) return -ENOMEM; + light->channels_count = conf.channel_count; /* First we collect all the configurations for all channels */ for (i = 0; i < light->channels_count; i++) { -- 2.50.1 (Apple Git-155)

2 months, 3 weeks

← Newer
1
...
6
7
8
9
10
11
12
...
76
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev