greybus-dev

greybus-dev@lists.linaro.org

8 participants
695 discussions

[PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c

by Rachit Dhar

Added comment to mutex declarations, to resolve checkpatch.pl checks. Signed-off-by: Rachit Dhar <rchtdhr(a)gmail.com> --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index e509fdc715db..1f2faa6d545d 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -37,7 +37,7 @@ struct gb_channel { bool releasing; bool strobe_state; bool active; - struct mutex lock; + struct mutex lock; /* protects gb_channel->active */ }; struct gb_light { @@ -59,7 +59,7 @@ struct gb_lights { struct gb_connection *connection; u8 lights_count; struct gb_light *lights; - struct mutex lights_lock; + struct mutex lights_lock; /* protects gb_lights->lights */ }; static void gb_lights_channel_free(struct gb_channel *channel); -- 2.43.0

1 day, 23 hours

[PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs_emit()

by Neel Bullywon

Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs attribute function. This code is safe as-is, but replace sprintf() with sysfs_emit() because we are trying to get rid of calls to sprintf() as part of kernel hardening; sysfs_emit() is more appropriate in this context. Signed-off-by: Neel Bullywon <neelb2403(a)gmail.com> --- This was compile-tested only (no VM/hardware used) Changes in v2: - Subject: change to imperative "Replace" (was "Replaced"). - Wording and line breaks adjusted in the commit body for clarity. Changes in v3: - Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's suggestion. - Reflow lines to avoid awkward breaks. --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 60cf09a302a7..55f132b09cee 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); base-commit: de0674d9bc69699c497477d45172493393ae9007 -- 2.44.0

2 days, 5 hours

[PATCH v3 3/4] staging: greybus: resolved checkpatch checks for raw.c

by Rachit Dhar

Added comment to mutex declaration, to resolve checkpatch.pl check. Signed-off-by: Rachit Dhar <rchtdhr(a)gmail.com> --- drivers/staging/greybus/raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c index 71de6776739c..4f217f20f1c0 100644 --- a/drivers/staging/greybus/raw.c +++ b/drivers/staging/greybus/raw.c @@ -20,7 +20,7 @@ struct gb_raw { struct list_head list; int list_data; - struct mutex list_lock; + struct mutex list_lock; /* protects gb_raw->list and gb_raw->list_data */ dev_t dev; struct cdev cdev; struct device *device; -- 2.43.0

2 days, 14 hours

[PATCH v3 2/4] staging: greybus: fixed styling issue in fw-management.c

by Rachit Dhar

Fixed a styling issue highlighted by checkpatch.pl. Signed-off-by: Rachit Dhar <rchtdhr(a)gmail.com> --- drivers/staging/greybus/fw-management.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index 07a0e6b63cf3..cf917ddb79c4 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd, return -EFAULT; ret = fw_mgmt_load_and_validate_operation(fw_mgmt, - intf_load.load_method, intf_load.firmware_tag); + intf_load.load_method, + intf_load.firmware_tag); if (ret) return ret; -- 2.43.0

2 days, 14 hours

[PATCH v3 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

by Rachit Dhar

Added comment to mutex declaration, to resolve a checkpatch.pl check. Signed-off-by: Rachit Dhar <rchtdhr(a)gmail.com> --- drivers/staging/greybus/fw-management.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index 152949c23d65..07a0e6b63cf3 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -28,7 +28,7 @@ struct fw_mgmt { /* Common id-map for interface and backend firmware requests */ struct ida id_map; - struct mutex mutex; + struct mutex mutex; /* protects fw_mgmt->disabled, and serializes ioctl */ struct completion completion; struct cdev cdev; struct device *class_device; -- 2.43.0

2 days, 14 hours

[PATCH v3 0/4] staging: greybus: fixing checkpatch issues

by Rachit Dhar

This series fixes checkpatch.pl checks highlighted for files in greybus, for mutex declaration comments, and styling issues. Changes in v3: - Added cover letter detailing changes made in subsequent versions of patch-sets. - v2 patch-set was only emailed to maintainers. The email was forwarded to the lists, but this rendered the patch-set corrupted. v3 hopes to correct this. Changes in v2: - Split patch 1 into two individual patches 1/4 and 2/4 to keep logical changes separate. Rachit Dhar (4): staging: greybus: added comment to mutex declaration in fw-management.c staging: greybus: fixed styling issue in fw-management.c staging: greybus: resolved checkpatch checks for raw.c staging: greybus: resolved checkpatch checks for light.c drivers/staging/greybus/fw-management.c | 5 +++-- drivers/staging/greybus/light.c | 4 ++-- drivers/staging/greybus/raw.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) -- 2.43.0

2 days, 14 hours

[PATCH v2] staging: greybus: gbphy: replace sprintf() with sysfs_emit()

by Neel Bullywon

Replaced sprintf() with sysfs_emit() in the protocol_id_show() sysfs attribute function. This code is safe, as replacing sprintf() with sysfs_emit() gets rid of calls to sprintf() as part of kernel hardening and sysfs_emit() is more appropriate in this context. Signed-off-by: Neel Bullywon <neelb2403(a)gmail.com> --- This was compile-tested only (no VM/hardware used) --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 60cf09a302a7..55f132b09cee 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); -- 2.44.0

2 days, 20 hours

[PATCH] staging: greybus: gbphy: replaced sprintf() with sysfs_emit()

by Neel Bullywon

Replaced sprintf() with sysfs_emit in the protocol_id_show() sysfs attribute func to prevent any potential buffer overflows This is to ensure a kernel-wide migration to safer string formatting functions for sysfs handlers This was compile-tested only (no VM/hardware used) Signed-off-by: Neel Bullywon <neelb2403(a)gmail.com> --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 60cf09a302a7..55f132b09cee 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); -- 2.44.0

2 days, 23 hours

[PATCH] staging: greybus: audio_codec.c: Remove unnecessary parentheses in if statement

by Eitan Collett

Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_in' CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_out' Signed-off-by: Eitan Collett <eitan.collett(a)gmail.com> --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 444c53b4e08d..44aee8268d14 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -305,7 +305,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, dev_dbg(module->dev, "%s:Module update %s sequence\n", w->name, enable ? "Enable" : "Disable"); - if ((w->id != snd_soc_dapm_aif_in) && (w->id != snd_soc_dapm_aif_out)) { + if (w->id != snd_soc_dapm_aif_in && w->id != snd_soc_dapm_aif_out) { dev_dbg(codec->dev, "No action required for %s\n", w->name); return 0; } -- 2.52.0

2 days, 23 hours

Fwd: [PATCH v2 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

by Rachit Dhar

---------- Forwarded message --------- From: Rachit Dhar <rchtdhr(a)gmail.com> Date: Tue, Feb 3, 2026 at 6:02 PM Subject: [PATCH v2 1/4] staging: greybus: added comment to mutex declaration in fw-management.c To: Cc: Rachit Dhar <rchtdhr(a)gmail.com>, Viresh Kumar <vireshk(a)kernel.org>, Johan Hovold <johan(a)kernel.org>, Alex Elder <elder(a)kernel.org>, Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Added comment to mutex declaration, to resolve a checkpatch.pl check. Signed-off-by: Rachit Dhar <rchtdhr(a)gmail.com> --- drivers/staging/greybus/fw-management.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index 152949c23d65..07a0e6b63cf3 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -28,7 +28,7 @@ struct fw_mgmt { /* Common id-map for interface and backend firmware requests */ struct ida id_map; - struct mutex mutex; + struct mutex mutex; /* protects fw_mgmt->disabled, and serializes ioctl */ struct completion completion; struct cdev cdev; struct device *class_device; -- 2.43.0

2 days, 23 hours

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev