greybus-dev

greybus-dev@lists.linaro.org

9 participants
573 discussions

[PATCH] staging: greybus: add logging statement when kfifo_alloc fails

by Keyur Patel

Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel <iamkeyur96(a)gmail.com> --- drivers/staging/greybus/uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b3bffe91ae99..86a395ae177d 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -856,8 +856,10 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev, retval = kfifo_alloc(&gb_tty->write_fifo, GB_UART_WRITE_FIFO_SIZE, GFP_KERNEL); - if (retval) + if (retval) { + pr_err("kfifo_alloc failed\n"); goto exit_buf_free; + } gb_tty->credits = GB_UART_FIRMWARE_CREDITS; init_completion(&gb_tty->credits_complete); -- 2.22.0

5 years, 11 months

[PATCH] staging: greybus: Replace function gb_i2c_device_setup()

by Nishka Dasgupta

Remove function gb_i2c_device_setup as all it does is call gb_i2c_functionality_operation. Rename gb_i2c_functionality_operation to gb_i2c_device_setup to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux(a)gmail.com> --- drivers/staging/greybus/i2c.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c index 7bb85a75d3b1..b2522043a1a4 100644 --- a/drivers/staging/greybus/i2c.c +++ b/drivers/staging/greybus/i2c.c @@ -31,7 +31,14 @@ static u32 gb_i2c_functionality_map(u32 gb_i2c_functionality) return gb_i2c_functionality; /* All bits the same for now */ } -static int gb_i2c_functionality_operation(struct gb_i2c_device *gb_i2c_dev) +/* + * Do initial setup of the i2c device. This includes verifying we + * can support it (based on the protocol version it advertises). + * If that's OK, we get and cached its functionality bits. + * + * Note: gb_i2c_dev->connection is assumed to have been valid. + */ +static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev) { struct gb_i2c_functionality_response response; u32 functionality; @@ -235,19 +242,6 @@ static const struct i2c_algorithm gb_i2c_algorithm = { .functionality = gb_i2c_functionality, }; -/* - * Do initial setup of the i2c device. This includes verifying we - * can support it (based on the protocol version it advertises). - * If that's OK, we get and cached its functionality bits. - * - * Note: gb_i2c_dev->connection is assumed to have been valid. - */ -static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev) -{ - /* Assume the functionality never changes, just get it once */ - return gb_i2c_functionality_operation(gb_i2c_dev); -} - static int gb_i2c_probe(struct gbphy_device *gbphy_dev, const struct gbphy_device_id *id) { -- 2.19.1

5 years, 11 months

[PATCH] staging: greybus: remove redundant assignment to variable is_empty

by Colin King

From: Colin Ian King <colin.king(a)canonical.com> The variable is_empty is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/staging/greybus/audio_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index c2a4af4c1d06..9b19ea9d3fa1 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -86,7 +86,7 @@ EXPORT_SYMBOL_GPL(gb_audio_manager_remove); void gb_audio_manager_remove_all(void) { struct gb_audio_manager_module *module, *next; - int is_empty = 1; + int is_empty; down_write(&modules_rwsem); -- 2.20.1

5 years, 11 months

Anyone else having delays with this list?

by Mark Greer

Hi everyone. Is anyone else experiencing delays receiving email from this list? I just received a bunch today (April 30) with some emails dating back as far as Jan 15. Thanks, Mark --

5 years, 11 months

[PATCH] staging: greybus: tools: Remove function log_csv_error()

by Nishka Dasgupta

Remove unused function log_csv_error. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux(a)gmail.com> --- drivers/staging/greybus/tools/loopback_test.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 2fa88092514d..cebc1d90a180 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -414,12 +414,6 @@ static int get_results(struct loopback_test *t) return 0; } -void log_csv_error(int len, int err) -{ - fprintf(stderr, "unable to write %d bytes to csv %s\n", len, - strerror(err)); -} - int format_output(struct loopback_test *t, struct loopback_results *r, const char *dev_name, -- 2.19.1

5 years, 11 months

[PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

by Kangjie Lu

ida_simple_get could fail. The fix inserts a check for its return value. Signed-off-by: Kangjie Lu <kjlu(a)umn.edu> --- drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err; id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL); + if (id < 0) + return id; + err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) { -- 2.17.1

6 years, 1 month

Re: [greybus-dev] [PATCH] staging: greybus: use proper return type for wait_for_completion_timeout

by Dan Carpenter

On Sat, Apr 27, 2019 at 05:27:25AM +0200, Nicholas Mc Guire wrote: > wait_for_completion_timeout() returns unsigned long (0 on timeout or > remaining jiffies) not int. > Yeah, but it's fine though because 10000 / 256 fits into int without a problem. I'm not sure this sort of patch is worth it when it's just a style debate instead of a bugfix. I'm a little bit torn about this. In Smatch, I run into this issue one in a while where Smatch doesn't know if the timeout is less than int. Right now I hacked the DB to say that these functions always return < INT_MAX. Anyway, for sure the commit message should say that it's just a cleanup and not a bugfix. regards, dan carpenter

6 years, 1 month

[PATCH] staging: greybus: use help instead of ---help--- in Kconfig

by MosesChristopher

From: Moses Christopher <moseschristopherb(a)gmail.com> - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher <moseschristopherb(a)gmail.com> --- drivers/staging/greybus/Kconfig | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig index b571e4e8060b..2f5061b565a6 100644 --- a/drivers/staging/greybus/Kconfig +++ b/drivers/staging/greybus/Kconfig @@ -1,7 +1,7 @@ menuconfig GREYBUS tristate "Greybus support" depends on SYSFS - ---help--- + help This option enables the Greybus driver core. Greybus is an hardware protocol that was designed to provide Unipro with a sane application layer. It was originally designed for the @@ -19,7 +19,7 @@ if GREYBUS config GREYBUS_ES2 tristate "Greybus ES3 USB host controller" depends on USB - ---help--- + help Select this option if you have a Toshiba ES3 USB device that acts as a Greybus "host controller". This device is a bridge from a USB device to a Unipro network. @@ -30,7 +30,7 @@ config GREYBUS_ES2 config GREYBUS_AUDIO tristate "Greybus Audio Class driver" depends on SOUND - ---help--- + help Select this option if you have a device that follows the Greybus Audio Class specification. @@ -39,7 +39,7 @@ config GREYBUS_AUDIO config GREYBUS_BOOTROM tristate "Greybus Bootrom Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Bootrom Class specification. @@ -49,7 +49,7 @@ config GREYBUS_BOOTROM config GREYBUS_CAMERA tristate "Greybus Camera Class driver" depends on MEDIA_SUPPORT && LEDS_CLASS_FLASH && BROKEN - ---help--- + help Select this option if you have a device that follows the Greybus Camera Class specification. @@ -59,7 +59,7 @@ config GREYBUS_CAMERA config GREYBUS_FIRMWARE tristate "Greybus Firmware Download Class driver" depends on SPI - ---help--- + help Select this option if you have a device that follows the Greybus Firmware Download Class specification. @@ -69,7 +69,7 @@ config GREYBUS_FIRMWARE config GREYBUS_HID tristate "Greybus HID Class driver" depends on HID && INPUT - ---help--- + help Select this option if you have a device that follows the Greybus HID Class specification. @@ -79,7 +79,7 @@ config GREYBUS_HID config GREYBUS_LIGHT tristate "Greybus LED Class driver" depends on LEDS_CLASS - ---help--- + help Select this option if you have a device that follows the Greybus LED Class specification. @@ -88,7 +88,7 @@ config GREYBUS_LIGHT config GREYBUS_LOG tristate "Greybus Debug Log Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -97,7 +97,7 @@ config GREYBUS_LOG config GREYBUS_LOOPBACK tristate "Greybus Loopback Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -107,7 +107,7 @@ config GREYBUS_LOOPBACK config GREYBUS_POWER tristate "Greybus Powersupply Class driver" depends on POWER_SUPPLY - ---help--- + help Select this option if you have a device that follows the Greybus Powersupply Class specification. @@ -116,7 +116,7 @@ config GREYBUS_POWER config GREYBUS_RAW tristate "Greybus Raw Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Raw Class specification. @@ -125,7 +125,7 @@ config GREYBUS_RAW config GREYBUS_VIBRATOR tristate "Greybus Vibrator Motor Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Vibrator Motor Class specification. @@ -134,7 +134,7 @@ config GREYBUS_VIBRATOR menuconfig GREYBUS_BRIDGED_PHY tristate "Greybus Bridged PHY Class drivers" - ---help--- + help Select this option to pick from a variety of Greybus Bridged PHY class drivers. These drivers emulate a number of different "traditional" busses by tunneling them over Greybus. @@ -149,7 +149,7 @@ config GREYBUS_GPIO tristate "Greybus GPIO Bridged PHY driver" depends on GPIOLIB select GPIOLIB_IRQCHIP - ---help--- + help Select this option if you have a device that follows the Greybus GPIO Bridged PHY Class specification. @@ -159,7 +159,7 @@ config GREYBUS_GPIO config GREYBUS_I2C tristate "Greybus I2C Bridged PHY driver" depends on I2C - ---help--- + help Select this option if you have a device that follows the Greybus I2C Bridged PHY Class specification. @@ -169,7 +169,7 @@ config GREYBUS_I2C config GREYBUS_PWM tristate "Greybus PWM Bridged PHY driver" depends on PWM - ---help--- + help Select this option if you have a device that follows the Greybus PWM Bridged PHY Class specification. @@ -179,7 +179,7 @@ config GREYBUS_PWM config GREYBUS_SDIO tristate "Greybus SDIO Bridged PHY driver" depends on MMC - ---help--- + help Select this option if you have a device that follows the Greybus SDIO Bridged PHY Class specification. @@ -189,7 +189,7 @@ config GREYBUS_SDIO config GREYBUS_SPI tristate "Greybus SPI Bridged PHY driver" depends on SPI - ---help--- + help Select this option if you have a device that follows the Greybus SPI Bridged PHY Class specification. @@ -199,7 +199,7 @@ config GREYBUS_SPI config GREYBUS_UART tristate "Greybus UART Bridged PHY driver" depends on TTY - ---help--- + help Select this option if you have a device that follows the Greybus UART Bridged PHY Class specification. @@ -209,7 +209,7 @@ config GREYBUS_UART config GREYBUS_USB tristate "Greybus USB Host Bridged PHY driver" depends on USB - ---help--- + help Select this option if you have a device that follows the Greybus USB Host Bridged PHY Class specification. @@ -221,7 +221,7 @@ endif # GREYBUS_BRIDGED_PHY config GREYBUS_ARCHE tristate "Greybus Arche Platform driver" depends on USB_HSIC_USB3613 || COMPILE_TEST - ---help--- + help Select this option if you have an Arche device. To compile this code as a module, chose M here: the module -- 2.11.0

6 years, 1 month

[PATCH v2] staging: greybus: power_supply: use struct_size() helper

by Gustavo A. R. Silva

Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code of the following form: sizeof(*resp) + props_count * sizeof(struct gb_power_supply_props_desc) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- Changes in v2: - Rebase on top of 47830c1127ef ("staging: greybus: power_supply: fix prop-descriptor request size") drivers/staging/greybus/power_supply.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index ae5c0285a942..34b40a409ea3 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -520,8 +520,8 @@ static int gb_power_supply_prop_descriptors_get(struct gb_power_supply *gbpsy) op = gb_operation_create(connection, GB_POWER_SUPPLY_TYPE_GET_PROP_DESCRIPTORS, - sizeof(*req), sizeof(*resp) + props_count * - sizeof(struct gb_power_supply_props_desc), + sizeof(*req), + struct_size(resp, props, props_count), GFP_KERNEL); if (!op) return -ENOMEM; -- 2.21.0

6 years, 1 month

[PATCH v2] Staging: greybus: Cleanup in greybus driver

by Madhumitha Prabakaran

Fix a blank line after structure declarations. Also, convert macros into inline functions in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Blank line fixes are suggested by checkpatch.pl Signed-off-by: Madhumitha Prabakaran <madhumithabiw(a)gmail.com> Changes in v2: - To maintain consistency in driver greybus, all the instances of macro with container_of are fixed in a single patch. --- drivers/staging/greybus/bundle.h | 6 +++++- drivers/staging/greybus/control.h | 6 +++++- drivers/staging/greybus/gbphy.h | 12 ++++++++++-- drivers/staging/greybus/greybus.h | 6 +++++- drivers/staging/greybus/hd.h | 6 +++++- drivers/staging/greybus/interface.h | 6 +++++- drivers/staging/greybus/module.h | 6 +++++- drivers/staging/greybus/svc.h | 6 +++++- 8 files changed, 45 insertions(+), 9 deletions(-) diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h index 8734d2055657..84956eedb1c4 100644 --- a/drivers/staging/greybus/bundle.h +++ b/drivers/staging/greybus/bundle.h @@ -31,7 +31,11 @@ struct gb_bundle { struct list_head links; /* interface->bundles */ }; -#define to_gb_bundle(d) container_of(d, struct gb_bundle, dev) + +static inline struct gb_bundle *to_gb_bundle(struct device *d) +{ + return container_of(d, struct gb_bundle, dev); +} /* Greybus "private" definitions" */ struct gb_bundle *gb_bundle_create(struct gb_interface *intf, u8 bundle_id, diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h index 3a29ec05f631..a681ef74e7fe 100644 --- a/drivers/staging/greybus/control.h +++ b/drivers/staging/greybus/control.h @@ -24,7 +24,11 @@ struct gb_control { char *vendor_string; char *product_string; }; -#define to_gb_control(d) container_of(d, struct gb_control, dev) + +static inline struct gb_control *to_gb_control(struct device *d) +{ + return container_of(d, struct gb_control, dev); +} struct gb_control *gb_control_create(struct gb_interface *intf); int gb_control_enable(struct gb_control *control); diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h index 99463489d7d6..20307f6dfcb9 100644 --- a/drivers/staging/greybus/gbphy.h +++ b/drivers/staging/greybus/gbphy.h @@ -15,7 +15,11 @@ struct gbphy_device { struct list_head list; struct device dev; }; -#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev) + +static inline struct gbphy_device *to_gbphy_dev(struct device *d) +{ + return container_of(d, struct gbphy_device, dev); +} static inline void *gb_gbphy_get_data(struct gbphy_device *gdev) { @@ -43,7 +47,11 @@ struct gbphy_driver { struct device_driver driver; }; -#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver) + +static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d) +{ + return container_of(d, struct gbphy_driver, driver); +} int gb_gbphy_register_driver(struct gbphy_driver *driver, struct module *owner, const char *mod_name); diff --git a/drivers/staging/greybus/greybus.h b/drivers/staging/greybus/greybus.h index d03ddb7c9df0..a82d5002b4d5 100644 --- a/drivers/staging/greybus/greybus.h +++ b/drivers/staging/greybus/greybus.h @@ -64,7 +64,11 @@ struct greybus_driver { struct device_driver driver; }; -#define to_greybus_driver(d) container_of(d, struct greybus_driver, driver) + +static inline struct greybus_driver *to_greybus_driver(struct device_driver *d) +{ + return container_of(d, struct greybus_driver, driver); +} static inline void greybus_set_drvdata(struct gb_bundle *bundle, void *data) { diff --git a/drivers/staging/greybus/hd.h b/drivers/staging/greybus/hd.h index 6cf024a20a58..de7c49d05266 100644 --- a/drivers/staging/greybus/hd.h +++ b/drivers/staging/greybus/hd.h @@ -57,7 +57,11 @@ struct gb_host_device { /* Private data for the host driver */ unsigned long hd_priv[0] __aligned(sizeof(s64)); }; -#define to_gb_host_device(d) container_of(d, struct gb_host_device, dev) + +static inline struct gb_host_device *to_gb_host_device(struct device *d) +{ + return container_of(d, struct gb_host_device, dev); +} int gb_hd_cport_reserve(struct gb_host_device *hd, u16 cport_id); void gb_hd_cport_release_reserved(struct gb_host_device *hd, u16 cport_id); diff --git a/drivers/staging/greybus/interface.h b/drivers/staging/greybus/interface.h index 1c00c5bb3ec9..f86c0d596dbe 100644 --- a/drivers/staging/greybus/interface.h +++ b/drivers/staging/greybus/interface.h @@ -63,7 +63,11 @@ struct gb_interface { struct work_struct mode_switch_work; struct completion mode_switch_completion; }; -#define to_gb_interface(d) container_of(d, struct gb_interface, dev) + +static inline struct gb_interface *to_gb_interface(struct device *d) +{ + return container_of(d, struct gb_interface, dev); +} struct gb_interface *gb_interface_create(struct gb_module *module, u8 interface_id); diff --git a/drivers/staging/greybus/module.h b/drivers/staging/greybus/module.h index b1ebcc6636db..c427b788b677 100644 --- a/drivers/staging/greybus/module.h +++ b/drivers/staging/greybus/module.h @@ -22,7 +22,11 @@ struct gb_module { struct gb_interface *interfaces[0]; }; -#define to_gb_module(d) container_of(d, struct gb_module, dev) + +static inline struct gb_module *to_gb_module(struct device *d) +{ + return container_of(d, struct gb_module, dev); +} struct gb_module *gb_module_create(struct gb_host_device *hd, u8 module_id, size_t num_interfaces); diff --git a/drivers/staging/greybus/svc.h b/drivers/staging/greybus/svc.h index ad01783bac9c..4e35ac9ed0ff 100644 --- a/drivers/staging/greybus/svc.h +++ b/drivers/staging/greybus/svc.h @@ -52,7 +52,11 @@ struct gb_svc { struct dentry *debugfs_dentry; struct svc_debugfs_pwrmon_rail *pwrmon_rails; }; -#define to_gb_svc(d) container_of(d, struct gb_svc, dev) + +static inline struct gb_svc *to_gb_svc(struct device *d) +{ + return container_of(d, struct gb_svc, dev); +} struct gb_svc *gb_svc_create(struct gb_host_device *hd); int gb_svc_add(struct gb_svc *svc); -- 2.17.1

6 years, 1 month

← Newer
1
...
39
40
41
42
43
44
45
...
58
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev