greybus-dev

greybus-dev@lists.linaro.org

3 participants
787 discussions

[PATCH] greybus: Remove gb_control_get_manifest_response struct

by clingfei

The gb_control_get_manifest_response struct is not used. So we delete it in this commit. Signed-off-by: clingfei <clf700383(a)gmail.com> --- include/linux/greybus/greybus_protocols.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h index 820134b0105c..dd09dc691dda 100644 --- a/include/linux/greybus/greybus_protocols.h +++ b/include/linux/greybus/greybus_protocols.h @@ -110,11 +110,6 @@ struct gb_control_get_manifest_size_response { __le16 size; } __packed; -/* Control protocol manifest get request has no payload */ -struct gb_control_get_manifest_response { - __u8 data[0]; -} __packed; - /* Control protocol [dis]connected request */ struct gb_control_connected_request { __le16 cport_id; -- 2.34.1

1 year

Re: [RFC net-next 00/15] Add support for Silicon Labs CPC

by Andrew Lunn

On Sun, May 11, 2025 at 09:27:33PM -0400, Damien Riégel wrote: > Hi, > > > This patchset brings initial support for Silicon Labs CPC protocol, > standing for Co-Processor Communication. This protocol is used by the > EFR32 Series [1]. These devices offer a variety for radio protocols, > such as Bluetooth, Z-Wave, Zigbee [2]. Before we get too deep into the details of the patches, please could you do a compare/contrast to Greybus. The core of Greybus is already in the kernel, with some more bits being in staging. I don't know it too well, but at first glance it looks very similar. We should not duplicate that. Also, this patch adds Bluetooth, you talk about Z-Wave and Zigbee. But the EFR32 is a general purpose SoC, with I2C, SPI, PWM, UART. Greybus has support for these, although the code is current in staging. But for staging code, it is actually pretty good. Why should we add a vendor implementation when we already appear to have something which does most of what is needed? Andrew

1 year

[PATCH V1] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by Rujra Bhatt

---------------------------------------------------------- This is the new Patch for the earlier Patch hence made V1. [Note: there will be no significant changes.] ---------------------------------------------------------- Changes: To ensuring that the firmware tag is properly null-terminated. When copying firmware tag strings to prevent buffer overflows and ensure data integrity. Changes has been made in 3 positions: 1: update firmware tag 2: backend update firmware tag 3: backend update firmware tag with unipro Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> --- drivers/staging/greybus/Documentation/firmware/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 765d69faa..f37904b91 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,7 +63,7 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strscpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); @@ -101,7 +101,7 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strscpy((char *)&backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -129,7 +129,7 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, + strscpy((char *)&backend_update.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: -- 2.43.0

1 year

Re: [PATCH RESEND] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by Rujra Bhatt

On Wed, May 21, 2025 at 09:06:00AM +0200, Greg KH wrote: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Wed, May 21, 2025 at 11:11:26AM +0530, rujra wrote: > > Hi greg, > > > > why is this a RESEND ?: > > > > >> I had sent the same patch 4 days ago and didn't get any reply , hence tried to resend the same patch for the same, > > here is earlier mail : > > https://mail.google.com/mail/u/1/?ik=f63b03515e&view=om&permmsgid=msg-a:s:1… > > That is a link to _your_ account, not a public record of your email :( > > > , > > > > line does not match this: > > >> sorry , i could not get it what it is exactly ?, if possible can you share some insights or example so that from in future i would get it right. > > Your "From:" line in your email does not match with the signed-off-by > line. This has been addressed successfully, Kindly preview it. is this the way correct about the reply email ? , kindly let me know as I have tried to get more and more answers and solved issues, and thank you so much for your guidance and will be keep in mind about the process and will not fail next time onwards. thank you, regards, Rujra Bhatt On Wed, May 21, 2025 at 2:02 PM Greg KH <gregkh(a)linuxfoundation.org> wrote: > > On Wed, May 21, 2025 at 01:30:44PM +0530, Rujra Bhatt wrote: > > <snip> > > For some reason you sent this only to me, which is a bit rude to > everyone else on the mailing list. I'll be glad to respond if you > resend it to everyone. > > thanks, > > greg k-h

1 year

[PATCH RESEND] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by rujra

To ensure that the firmware tag is properly null-terminated. When copying firmware tag strings to prevent buffer overflows and ensure data integrity. changes has been made in 3 positions: 1: update firmware tag 2: backend update firmware tag 3: backend update firmware tag with unipro Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> --- drivers/staging/greybus/Documentation/firmware/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 765d69faa..f37904b91 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,7 +63,7 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strscpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); @@ -101,7 +101,7 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strscpy((char *)&backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -129,7 +129,7 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, + strscpy((char *)&backend_update.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: -- 2.43.0

1 year

[PATCH v2 1/2] [PATCH v2 1/2] staging: greybus: fw-management: Add detailed mutex comment

by Sridhar Arra

Added a detailed comment explaining the role of the mutex in serializing firmware management ioctl() operations. The mutex prevents concurrent access to firmware operations and protects the 'disabled' state flag during disconnection. Signed-off-by: Sridhar Arra <sridhar.arra(a)yahoo.com> --- drivers/staging/greybus/fw-management.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index a47385175582..56725b711a17 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -28,6 +28,19 @@ struct fw_mgmt { /* Common id-map for interface and backend firmware requests */ struct ida id_map; + /* + * Mutex to serialize firmware management ioctl() operations and + * protect against concurrent access. + * + * Ensures that user-space cannot perform multiple firmware + * operations in parallel (e.g., updating interface firmware) + * for the same Interface, avoiding race conditions and reducing + * code complexity. + * + * Also protects the 'disabled' state flag, preventing new + * operations from starting when the firmware management + * connection is being disconnected. + */ struct mutex mutex; struct completion completion; struct cdev cdev; -- 2.43.0

1 year, 1 month

[PATCH] [Patch]: staging: greybus: camera: fix alignment should match open parentheses

by Andreas Kleinbichler

Correct the alignment of the parameters to match the open parenthesis. Reported by checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Andreas Kleinbichler <andi.kleinbichler(a)gmail.com> --- drivers/staging/greybus/camera.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index ec9fddfc0b14..a1b76df39a8f 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, * Validate the stream configuration response verifying padding is correctly * set and the returned number of streams is supported */ -static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam, - struct gb_camera_configure_streams_response *resp, - unsigned int nstreams) +static const int gb_camera_configure_streams_validate_response + (struct gb_camera *gcam, + struct gb_camera_configure_streams_response *resp, + unsigned int nstreams) { unsigned int i; -- 2.43.0

1 year, 1 month

[PATCH v2 0/4] staging: greybus: cleanup, API migration, and refactors

by Ganesh Kumar Pittala

This patch series splits and improves the previously submitted single patch by breaking it into four independent, logical changes following kernel submission etiquette. Link: https://lore.kernel.org/r/d683962c-e8b7-4adc-9902-483976197637@riscstar.com Link: https://lore.kernel.org/r/5773d200-1d9d-4d6e-b01e-10d962ee9e8e@quicinc.com Link: https://lore.kernel.org/r/4f47df18-e98c-4f23-afde-3fa8e9fd0f86@quicinc.com Link: https://lore.kernel.org/r/202504010829.vIzweYue-lkp@intel.com Link: https://lore.kernel.org/r/202504011217.iRb2Bbls-lkp@intel.com All changes are isolated, reviewed, and tested. Patches included: 1. Replace deprecated strncpy() with strscpy() in firmware.c 2. Replace sprintf() with sysfs_emit() in sysfs show functions 3. Refactor gb_loopback_fn() into smaller helpers 4. Fulfill TODO by splitting get_topology() logic in audio_gb.c v1 feedback from maintainers highlighted the need to split changes and avoid unrelated whitespace or formatting edits. These recommendations have been carefully addressed in this version. Signed-off-by: Ganesh Kumar Pittala <ganeshkpittala(a)gmail.com> Ganesh Kumar Pittala (4): staging: greybus: replace deprecated strncpy with strscpy in firmware.c staging: greybus: replace sprintf with sysfs_emit in sysfs show functions staging: greybus: refactor gb_loopback_fn into smaller helper functions staging: greybus: split gb_audio_gb_get_topology into helper functions .../greybus/Documentation/firmware/firmware.c | 6 +- drivers/staging/greybus/arche-apb-ctrl.c | 11 +- drivers/staging/greybus/arche-platform.c | 11 +- drivers/staging/greybus/audio_gb.c | 36 +++- .../staging/greybus/audio_manager_module.c | 13 +- drivers/staging/greybus/gbphy.c | 3 +- drivers/staging/greybus/light.c | 5 +- drivers/staging/greybus/loopback.c | 167 ++++++++++-------- 8 files changed, 145 insertions(+), 107 deletions(-) -- 2.43.0

1 year, 1 month

[FIRST-PATCH] staging : greybus : gb-beagleplay.c : fixing the checks as first-patch

by rujra

added comments on spinlocks for producer-consumer model, rearranged the lines on function calls where it should not end with "(" this bracket, also removed white-spaces and aligned the arguments of function calls. Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> >8------------------------------------------------------8< drivers/greybus/gb-beagleplay.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/greybus/gb-beagleplay.c b/drivers/greybus/gb-beagleplay.c index 473ac3f2d382..fa1c3a40dd0b 100644 --- a/drivers/greybus/gb-beagleplay.c +++ b/drivers/greybus/gb-beagleplay.c @@ -73,7 +73,9 @@ struct gb_beagleplay { struct gb_host_device *gb_hd; struct work_struct tx_work; + //used to ensure that only one producer can access the shared resource at a time. spinlock_t tx_producer_lock; + //used to ensure that only one consumer can access the shared resource at a time. spinlock_t tx_consumer_lock; struct circ_buf tx_circ_buf; u16 tx_crc; @@ -642,8 +644,8 @@ static int cc1352_bootloader_wait_for_ack(struct gb_beagleplay *bg) { int ret; - ret = wait_for_completion_timeout( - &bg->fwl_ack_com, msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + ret = wait_for_completion_timeout(&bg->fwl_ack_com, + msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); if (ret < 0) return dev_err_probe(&bg->sd->dev, ret, "Failed to acquire ack semaphore"); @@ -680,9 +682,8 @@ static int cc1352_bootloader_get_status(struct gb_beagleplay *bg) if (ret < 0) return ret; - ret = wait_for_completion_timeout( - &bg->fwl_cmd_response_com, - msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + ret = wait_for_completion_timeout(&bg->fwl_cmd_response_com, + msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); if (ret < 0) return dev_err_probe(&bg->sd->dev, ret, "Failed to acquire last status semaphore"); @@ -765,9 +766,8 @@ static int cc1352_bootloader_crc32(struct gb_beagleplay *bg, u32 *crc32) if (ret < 0) return ret; - ret = wait_for_completion_timeout( - &bg->fwl_cmd_response_com, - msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + ret = wait_for_completion_timeout(&bg->fwl_cmd_response_com, + msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); if (ret < 0) return dev_err_probe(&bg->sd->dev, ret, "Failed to acquire last status semaphore"); -- 2.43.0

1 year, 1 month

[PATCH] staging: greybus: Reformat code in gb_operation_sync_timeout()

by Thorsten Blum

Remove any unnecessary curly braces and combine 'else' and 'if' to an 'else if' to improve the code's readability and reduce indentation. Signed-off-by: Thorsten Blum <thorsten.blum(a)linux.dev> --- drivers/greybus/operation.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c index 8459e9bc0749..ba26504ccac3 100644 --- a/drivers/greybus/operation.c +++ b/drivers/greybus/operation.c @@ -1157,16 +1157,12 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type, memcpy(operation->request->payload, request, request_size); ret = gb_operation_request_send_sync_timeout(operation, timeout); - if (ret) { + if (ret) dev_err(&connection->hd->dev, "%s: synchronous operation id 0x%04x of type 0x%02x failed: %d\n", connection->name, operation->id, type, ret); - } else { - if (response_size) { - memcpy(response, operation->response->payload, - response_size); - } - } + else if (response_size) + memcpy(response, operation->response->payload, response_size); gb_operation_put(operation); -- 2.49.0

1 year, 1 month

← Newer
1
...
20
21
22
23
24
25
26
...
79
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev