greybus-dev

greybus-dev@lists.linaro.org

3 participants
787 discussions

[PATCH 00/13] staging: greybus: cleanup, FIXME removals, and driver correctness fixes

by Ayaan Mirza Baig

Hi Greg and all, This series performs a set of cleanups, correctness fixes, and remaining TODO removals across the Greybus drivers in drivers/staging/greybus. Greybus has existed in staging for a long time, and many FIXMEs, outdated comments, and partial implementations had accumulated over the years. While reviewing and compile-testing the drivers I found a number of places where the comments were obsolete, logic was incomplete, or newer subsystem APIs had evolved. This series addresses those issues without changing any fundamental design or architecture. All changes are self-contained, straightforward, and focues on improving correctness and maintainability. The patches include: * Removal of obsolete FIXMEs that no longer reflect the current code or hardware behavior. * Correctness fixes in several protocol drivers (UART, RAW, USB, Loopback, Firmware core, Audio). * Small improvements to error handling and shutdown paths. * Cleanup of commented-out or dead code. * Removal of the now-completed GPIO and PWM TODO items. * Removal of the empty Greybus TODO file. All patches were compile-tested with COMPILE_TEST=y and all Greybus options enabled. Runtime smoke testing was performed where possible. This series does not attempt to graduate Greybus out of staging; these changes are preparatory cleanups only. Thanks for your time and review. Ayaan Mirza Baig (13): staging: greybus: Remove completed GPIO conversion TODO item staging: greybus: pwm: move activation into pwm apply and remove request() staging: greybus: remove empty TODO file staging: greybus: audio: remove obsolete INPUT_PROP_NO_DUMMY_RELEASE FIXME staging: greybus: audio: remove obsolete FIXME and document topology ownership staging: greybus: bootrom: remove obsolete FIXME about SVC parallel event handling staging: greybus: bootrom: remove obsolete FIXME around firmware filename logging staging: greybus: fw-core: remove obsolete S2 Loader runtime PM FIXME staging: greybus: loopback: remove incorrect FIXME about async wait staging: greybus: raw: handle disconnect while chardev is open staging: greybus: uart: clear unsupported termios bits staging: greybus: usb: validate hub control response length staging: greybus: usb: remove obsolete FIXME about bridged-PHY support drivers/staging/greybus/TODO | 5 ----- drivers/staging/greybus/audio_codec.c | 7 +------ drivers/staging/greybus/audio_module.c | 6 ++++-- drivers/staging/greybus/bootrom.c | 10 ++-------- drivers/staging/greybus/fw-core.c | 4 ++-- drivers/staging/greybus/loopback.c | 6 +----- drivers/staging/greybus/pwm.c | 19 +++++++++++-------- drivers/staging/greybus/raw.c | 18 ++++++++++++++++-- drivers/staging/greybus/uart.c | 10 ++++++++-- drivers/staging/greybus/usb.c | 23 ++++++++--------------- 10 files changed, 53 insertions(+), 55 deletions(-) delete mode 100644 drivers/staging/greybus/TODO -- 2.51.0

6 months, 1 week

[PATCH] staging: greybus: audio_manager: make envp[] static const

by Sameeksha Sankpal

The envp[] array contains string literals and is never modified. Declare it as 'static const char * const' to place it in read-only memory and avoid unnecessary stack usage. This fixes a checkpatch warning: "char * array declaration might be better as static const" Signed-off-by: Sameeksha Sankpal <sameekshasankpal(a)gmail.com> --- drivers/staging/greybus/audio_manager_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 4a4dfb42f50f..1b83c05f2434 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -159,7 +159,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module) char ip_devices_string[64]; char op_devices_string[64]; - char *envp[] = { + static const char * const envp[] = { name_string, vid_string, pid_string, -- 2.43.0

6 months, 1 week

[PATCH v4] Replace all strncpy() calls with strscpy() and fix indentation issues.

by Dharanitharan R

The firmware_tag string comes from userspace and may not be NUL terminated. strlcpy() performs strlen() on the source buffer, which can read past the end and potentially cause an Oops. strscpy() avoids this and guarantees NUL termination without overflowing the destination. Signed-off-by: Dharanitharan R <dharanitharan725(a)gmail.com> --- Changes in v4: - Replace strlcpy() with strscpy() based on maintainer feedback - Added explanation about user-controlled buffers Changes in v3: - Fix Signed-off-by spacing - Move changelog below '---' Changes in v2: - Fixed indentation issues reported by Greg KH --- .../greybus/Documentation/firmware/firmware.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 6f6410878ee6..84b9cf45fc8e 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,10 +63,11 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strlcpy(intf_load.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + /* firmware_tag comes from userspace and may not be NUL terminated. + * strscpy() avoids strlen() on src and guarantees NUL termination. + */ + strscpy(intf_load.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { @@ -103,8 +104,8 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strlcpy(backend_fw_info.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strscpy(backend_fw_info.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -132,8 +133,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strlcpy(backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strscpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

6 months, 1 week

Complete With Docusign: Po 3525 (Confidential)

by Docusign

6 months, 1 week

[PATCH] greybus: gb-beagleplay: Fix timeout handling in bootloader functions

by Haotian Zhang

wait_for_completion_timeout() returns the remaining jiffies (at least 1) on success or 0 on timeout, but never negative error codes. The current code incorrectly checks for negative values, causing timeouts to be ignored and treated as success. Check for a zero return value to correctly identify and handle timeout events. Fixes: 0cf7befa3ea2 ("greybus: gb-beagleplay: Add firmware upload API") Signed-off-by: Haotian Zhang <vulab(a)iscas.ac.cn> --- drivers/greybus/gb-beagleplay.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/greybus/gb-beagleplay.c b/drivers/greybus/gb-beagleplay.c index 9610f878da1b..87186f891a6a 100644 --- a/drivers/greybus/gb-beagleplay.c +++ b/drivers/greybus/gb-beagleplay.c @@ -644,8 +644,8 @@ static int cc1352_bootloader_wait_for_ack(struct gb_beagleplay *bg) ret = wait_for_completion_timeout( &bg->fwl_ack_com, msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); - if (ret < 0) - return dev_err_probe(&bg->sd->dev, ret, + if (!ret) + return dev_err_probe(&bg->sd->dev, -ETIMEDOUT, "Failed to acquire ack semaphore"); switch (READ_ONCE(bg->fwl_ack)) { @@ -683,8 +683,8 @@ static int cc1352_bootloader_get_status(struct gb_beagleplay *bg) ret = wait_for_completion_timeout( &bg->fwl_cmd_response_com, msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); - if (ret < 0) - return dev_err_probe(&bg->sd->dev, ret, + if (!ret) + return dev_err_probe(&bg->sd->dev, -ETIMEDOUT, "Failed to acquire last status semaphore"); switch (READ_ONCE(bg->fwl_cmd_response)) { @@ -768,8 +768,8 @@ static int cc1352_bootloader_crc32(struct gb_beagleplay *bg, u32 *crc32) ret = wait_for_completion_timeout( &bg->fwl_cmd_response_com, msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); - if (ret < 0) - return dev_err_probe(&bg->sd->dev, ret, + if (!ret) + return dev_err_probe(&bg->sd->dev, -ETIMEDOUT, "Failed to acquire last status semaphore"); *crc32 = READ_ONCE(bg->fwl_cmd_response); -- 2.50.1.windows.1

6 months, 2 weeks

[PATCH v3] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

Replace all strncpy() calls with strlcpy() and fix indentation issues. Signed-off-by: Dharanitharan R <dharanitharan725(a)gmail.com> --- Changes in v3: - Fix Signed-off-by spacing - Move changelog below '---' Changes in v2: - Fixed indentation issues reported by Greg KH --- .../staging/greybus/Documentation/firmware/firmware.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 3b35ef6d4adb..6f6410878ee6 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,9 +63,11 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strlcpy(intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { printf("Failed to load interface firmware: %s (%d)\n", fwdev, @@ -101,9 +103,10 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strlcpy(backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info); if (ret < 0) { @@ -129,8 +132,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

6 months, 2 weeks

[PATCH v3] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

6 months, 2 weeks

Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

by kernel test robot

Hi Chang, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Chang-Junzheng/staging-greyb… base: staging/staging-testing patch link: https://lore.kernel.org/r/tencent_A64EA96730156BC5D2E33B86752776DB9D07%40qq… patch subject: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20251119/202511191127.cg63hCHn-lkp@…) compiler: or1k-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191127.cg63hCHn-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202511191127.cg63hCHn-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/staging/greybus/audio_manager_module.c: In function 'send_add_uevent': >> drivers/staging/greybus/audio_manager_module.c:163:9: error: initializer element is not constant 163 | name_string, | ^~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:163:9: note: (near initialization for 'envp[0]') drivers/staging/greybus/audio_manager_module.c:164:9: error: initializer element is not constant 164 | vid_string, | ^~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:164:9: note: (near initialization for 'envp[1]') drivers/staging/greybus/audio_manager_module.c:165:9: error: initializer element is not constant 165 | pid_string, | ^~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:165:9: note: (near initialization for 'envp[2]') drivers/staging/greybus/audio_manager_module.c:166:9: error: initializer element is not constant 166 | intf_id_string, | ^~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:166:9: note: (near initialization for 'envp[3]') drivers/staging/greybus/audio_manager_module.c:167:9: error: initializer element is not constant 167 | ip_devices_string, | ^~~~~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:167:9: note: (near initialization for 'envp[4]') drivers/staging/greybus/audio_manager_module.c:168:9: error: initializer element is not constant 168 | op_devices_string, | ^~~~~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:168:9: note: (near initialization for 'envp[5]') >> drivers/staging/greybus/audio_manager_module.c:181:53: error: passing argument 3 of 'kobject_uevent_env' from incompatible pointer type [-Wincompatible-pointer-types] 181 | kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); | ^~~~ | | | const char * const* In file included from drivers/staging/greybus/audio_manager.h:11, from drivers/staging/greybus/audio_manager_module.c:10: include/linux/kobject.h:216:31: note: expected 'char **' but argument is of type 'const char * const*' 216 | char *envp[]); | ~~~~~~^~~~~~ vim +163 drivers/staging/greybus/audio_manager_module.c 8db00736d365b7 Svetlin Ankov 2016-01-13 152 8db00736d365b7 Svetlin Ankov 2016-01-13 153 static void send_add_uevent(struct gb_audio_manager_module *module) 8db00736d365b7 Svetlin Ankov 2016-01-13 154 { 8db00736d365b7 Svetlin Ankov 2016-01-13 155 char name_string[128]; 8db00736d365b7 Svetlin Ankov 2016-01-13 156 char vid_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 157 char pid_string[64]; d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 158 char intf_id_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 159 char ip_devices_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 160 char op_devices_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 161 0e0a4291b18003 Chang Junzheng 2025-11-14 162 static const char * const envp[] = { 8db00736d365b7 Svetlin Ankov 2016-01-13 @163 name_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 164 vid_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 165 pid_string, d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 @166 intf_id_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 167 ip_devices_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 168 op_devices_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 169 NULL 8db00736d365b7 Svetlin Ankov 2016-01-13 170 }; 8db00736d365b7 Svetlin Ankov 2016-01-13 171 8db00736d365b7 Svetlin Ankov 2016-01-13 172 snprintf(name_string, 128, "NAME=%s", module->desc.name); 8db00736d365b7 Svetlin Ankov 2016-01-13 173 snprintf(vid_string, 64, "VID=%d", module->desc.vid); 8db00736d365b7 Svetlin Ankov 2016-01-13 174 snprintf(pid_string, 64, "PID=%d", module->desc.pid); d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 175 snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 176 snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 177 module->desc.ip_devices); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 178 snprintf(op_devices_string, 64, "O/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 179 module->desc.op_devices); 8db00736d365b7 Svetlin Ankov 2016-01-13 180 8db00736d365b7 Svetlin Ankov 2016-01-13 @181 kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); 8db00736d365b7 Svetlin Ankov 2016-01-13 182 } 8db00736d365b7 Svetlin Ankov 2016-01-13 183 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

6 months, 2 weeks

[PATCH] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

The sample userspace firmware-management tool uses strncpy() to copy firmware tags. strncpy() does not guarantee null-termination and can leave buffers unterminated. For userspace code, strlcpy() is the recommended safe alternative. Replace all strncpy() calls with strlcpy(). Signed-off-by: Dharanitharan <dharanitharan725(a)gmail.com> --- .../greybus/Documentation/firmware/firmware.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 3b35ef6d4adb..224eb8f4e39c 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,8 +63,9 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(intf_load.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); + ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { @@ -101,8 +102,9 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_fw_info.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); + retry_fw_version: ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info); @@ -129,8 +131,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

6 months, 2 weeks

[PATCH v2] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

v2: Fix indentation issues pointed out by Greg KH. Signed-off-by:Dharanitharan R <dharanitharan725(a)gmail.com> --- .../staging/greybus/Documentation/firmware/firmware.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 3b35ef6d4adb..6f6410878ee6 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,9 +63,11 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strlcpy(intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { printf("Failed to load interface firmware: %s (%d)\n", fwdev, @@ -101,9 +103,10 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strlcpy(backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info); if (ret < 0) { @@ -129,8 +132,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

6 months, 2 weeks

← Newer
1
...
12
13
14
15
16
17
18
...
79
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev