Re: [PATCH] coresight: replicator: Fix panic for clearing claim tag

6 May 2025


      On Tue, May 06, 2025 at 10:27:37AM +0100, James Clark wrote:
[...]
...
...
@@ -262,6 +262,7 @@ static int replicator_probe(struct device *dev, struct resource *res)
   	drvdata->base = base;
   	desc.groups = replicator_groups;
   	desc.access = CSDEV_ACCESS_IOMEM(base);

coresight_clear_self_claim_tag(&desc.access);

}
if (fwnode_property_present(dev_fwnode(dev),

@@ -284,7 +285,6 @@ static int replicator_probe(struct device *dev, struct resource *res)
   desc.pdata = dev->platform_data;
   desc.dev = dev;

coresight_clear_self_claim_tag(&desc.access);
drvdata->csdev = coresight_register(&desc);
if (IS_ERR(drvdata->csdev)) {
ret = PTR_ERR(drvdata->csdev);

Oops. The other occurrence of this is the funnel, but I got that one right.
Reviewed-by: James Clark james.clark@linaro.org
Thanks for review.  Yes, the funnel driver is fine as it accesses claim
tag for only MMIO mode.
Leo

    