Re: [PATCH v3 05/10] coresight-tpdm: Add DSB dataset support

Hi

This patch does not apply cleanly:-

======================================= git apply -v ../patch.in/qcom/qcom-05.patch Checking patch drivers/hwtracing/coresight/coresight-tpdm.c... error: while searching for:

DEFINE_CORESIGHT_DEVLIST(tpdm_devs, "tpdm");

/** TPDM enable operations **/ static int tpdm_enable(struct coresight_device *csdev, struct perf_event *event, u32 mode) {

error: patch failed: drivers/hwtracing/coresight/coresight-tpdm.c:20 error: drivers/hwtracing/coresight/coresight-tpdm.c: patch does not apply Checking patch drivers/hwtracing/coresight/coresight-tpdm.h...

=======================================

In patch 3 - the first time coresight-tpdm.c. is added the comment line is

/* TPDM enable operations */

Note the single * in the comment.

This would seem to indicate missing intermediate patches, or patches from different trees / times.

A coherent patch set is needed for review

Regards

Mike

On Wed, 9 Feb 2022 at 10:57, Mao Jinlong quic_jinlmao@quicinc.com wrote:

TPDM serves as data collection component for various dataset types. DSB(Discrete Single Bit) is one of the dataset types. DSB subunit can be enabled for data collection by writing 1 to the first bit of DSB_CR register. This change is to add enable/disable function for DSB dataset by writing DSB_CR register.

Signed-off-by: Tao Zhang quic_taozha@quicinc.com Signed-off-by: Mao Jinlong quic_jinlmao@quicinc.com

---

drivers/hwtracing/coresight/coresight-tpdm.c | 57 ++++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpdm.h | 21 ++++++++ 2 files changed, 78 insertions(+)

diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c index 51b8b17e6a80..c6480b7389b0 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -20,7 +20,28 @@

DEFINE_CORESIGHT_DEVLIST(tpdm_devs, "tpdm");

+static void tpdm_enable_dsb(struct tpdm_drvdata *drvdata) +{

•   u32 val;
  

•   /* Set the enable bit of DSB control register to 1 */
  

•   val = readl_relaxed(drvdata->base + TPDM_DSB_CR);
  

•   val = val | BIT(0);
  

•   writel_relaxed(val, drvdata->base + TPDM_DSB_CR);
  

+}

/** TPDM enable operations **/ +static void _tpdm_enable(struct tpdm_drvdata *drvdata) +{

•   CS_UNLOCK(drvdata->base);
  

•   /* Check if DSB datasets is present for TPDM. */
  

•   if (test_bit(TPDM_DS_DSB, drvdata->datasets))
  

•           tpdm_enable_dsb(drvdata);
  

•   CS_LOCK(drvdata->base);
  

+}

static int tpdm_enable(struct coresight_device *csdev, struct perf_event *event, u32 mode) { @@ -32,6 +53,7 @@ static int tpdm_enable(struct coresight_device *csdev, return -EBUSY; }

•   _tpdm_enable(drvdata);
    drvdata->enable = true;
    mutex_unlock(&drvdata->lock);
  
  

@@ -39,7 +61,29 @@ static int tpdm_enable(struct coresight_device *csdev, return 0; }

+static void tpdm_disable_dsb(struct tpdm_drvdata *drvdata) +{

•   u32 val;
  

•   /* Set the enable bit of DSB control register to 0 */
  

•   val = readl_relaxed(drvdata->base + TPDM_DSB_CR);
  

•   val = val & ~BIT(0);
  

•   writel_relaxed(val, drvdata->base + TPDM_DSB_CR);
  

+}

/** TPDM disable operations **/ +static void _tpdm_disable(struct tpdm_drvdata *drvdata) +{

•   CS_UNLOCK(drvdata->base);
  

•   /* Check if DSB datasets is present for TPDM. */
  

•   if (test_bit(TPDM_DS_DSB, drvdata->datasets))
  

•           tpdm_disable_dsb(drvdata);
  

•   CS_LOCK(drvdata->base);
  

+}

static void tpdm_disable(struct coresight_device *csdev, struct perf_event *event) { @@ -51,6 +95,7 @@ static void tpdm_disable(struct coresight_device *csdev, return; }

•   _tpdm_disable(drvdata);
    drvdata->enable = false;
    mutex_unlock(&drvdata->lock);
  
  

@@ -76,7 +121,19 @@ static const struct coresight_ops tpdm_cs_ops = {

static void tpdm_init_default_data(struct tpdm_drvdata *drvdata) {

•   int i;
  

•   u32 pidr;
  

•   drvdata->traceid = coresight_get_system_trace_id();
  

•   CS_UNLOCK(drvdata->base);
  

•   /*  Get the datasets present on the TPDM. */
  

•   pidr = readl_relaxed(drvdata->base + CORESIGHT_PERIPHIDR0);
  

•   for (i = 0; i < TPDM_DATASETS; i++) {
  

•           if (pidr & BIT(i))
  

•                   __set_bit(i, drvdata->datasets);
  

•   }
  

•   CS_LOCK(drvdata->base);
  

}

static int tpdm_probe(struct amba_device *adev, const struct amba_id *id) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.h b/drivers/hwtracing/coresight/coresight-tpdm.h index 2effbabf349b..cb3ddc6c89ae 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.h +++ b/drivers/hwtracing/coresight/coresight-tpdm.h @@ -6,6 +6,25 @@ #ifndef _CORESIGHT_CORESIGHT_TPDM_H #define _CORESIGHT_CORESIGHT_TPDM_H

+/* The max number of the datasets that TPDM supports */ +#define TPDM_DATASETS 7

+/* DSB Subunit Registers */ +#define TPDM_DSB_CR (0x780)

+/**

• • This enum is for PERIPHIDR0 register of TPDM.
• • The fields [6:0] of PERIPHIDR0 are used to determine what
• • interfaces and subunits are present on a given TPDM.
• • PERIPHIDR0[0] : Fix to 1 if ImplDef subunit present, else 0
• • PERIPHIDR0[1] : Fix to 1 if DSB subunit present, else 0
• */

+enum tpdm_dataset {

•   TPDM_DS_IMPLDEF,
  

•   TPDM_DS_DSB,
  

+};

/**

• struct tpdm_drvdata - specifics associated to an TPDM component
• @base: memory mapped base address for this component.

@@ -13,6 +32,7 @@

• @csdev: component vitals needed by the framework.
• @lock: lock for the enable value.
• @enable: enable status of the component.

• • @datasets: The datasets types present of the TPDM.
  • @traceid: value of the current ID for this component.
  */

@@ -22,6 +42,7 @@ struct tpdm_drvdata { struct coresight_device *csdev; struct mutex lock; bool enable;

•   DECLARE_BITMAP(datasets, TPDM_DATASETS);
    int                     traceid;
  

};

-- 2.17.1

-- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK