On Tue, 18 Nov 2025 at 16:28, James Clark james.clark@linaro.org wrote:
config isn't the only field, there are also config1, config2, etc. Rejecting unrecognized attributes is therefore inconsistent as it wasn't done for all fields. It was only necessary when we were directly programming attr->config into ETMCR and didn't hide the unsupported fields, but now it's not needed so remove it.
Reviewed-by: Leo Yan leo.yan@arm.com Signed-off-by: James Clark james.clark@linaro.org
drivers/hwtracing/coresight/coresight-etm3x-core.c | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index 4511fc2f8d72..584d653eda81 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -333,13 +333,6 @@ static int etm_parse_event_config(struct etm_drvdata *drvdata, if (config->mode) etm_config_trace_mode(config);
/** At this time only cycle accurate, return stack and timestamp* options are available.*/if (attr->config & ~ETM3X_SUPPORTED_OPTIONS)return -EINVAL;config->ctrl = 0; if (ATTR_CFG_GET_FLD(attr, cycacc))-- 2.34.1
Reviewed-by: Mike Leach mike.leach@linaro.org