Changes the defintion of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.
Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Aya Mahfouz mahfouz.saif.elyazal@gmail.com --- Changelog: v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me to two independent patches.
include/linux/dns_resolver.h | 2 +- net/dns_resolver/dns_query.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/dns_resolver.h b/include/linux/dns_resolver.h index cc92268..6ac3cad 100644 --- a/include/linux/dns_resolver.h +++ b/include/linux/dns_resolver.h @@ -27,7 +27,7 @@ #ifdef __KERNEL__
extern int dns_query(const char *type, const char *name, size_t namelen, - const char *options, char **_result, time_t *_expiry); + const char *options, char **_result, time64_t *_expiry);
#endif /* KERNEL */
diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c index 4677b6f..ecc28cf 100644 --- a/net/dns_resolver/dns_query.c +++ b/net/dns_resolver/dns_query.c @@ -67,7 +67,7 @@ * Returns the size of the result on success, -ve error code otherwise. */ int dns_query(const char *type, const char *name, size_t namelen, - const char *options, char **_result, time_t *_expiry) + const char *options, char **_result, time64_t *_expiry) { struct key *rkey; const struct user_key_payload *upayload;
On Tuesday 17 November 2015 22:56:48 Aya Mahfouz wrote:
Changes the defintion of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.
Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Aya Mahfouz mahfouz.saif.elyazal@gmail.com
Looks good.
Arnd
On Tue, Nov 17, 2015 at 11:18:36PM +0100, Arnd Bergmann wrote:
On Tuesday 17 November 2015 22:56:48 Aya Mahfouz wrote:
Changes the defintion of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.
Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Aya Mahfouz mahfouz.saif.elyazal@gmail.com
Looks good.
Arnd
ok. I will send it. Let me know your concerns for the other patch too.
Thank you,