On Saturday 07 November 2015 00:36:26 Amitoj Kaur Chawla wrote:
On Fri, Nov 6, 2015 at 8:53 PM, Arnd Bergmann arnd@arndb.de wrote:
This version is better, but I think you missed the used of the variable:
#define bfa_io_profile_start_time(_bfa) \ ((_bfa)->modules.fcp_mod.fcpim.io_profile_start_time)
bfa_itnim_get_ioprofile(struct bfa_itnim_s *itnim, struct bfa_itnim_ioprofile_s *ioprofile) { ... itnim->ioprofile.io_profile_start_time = bfa_io_profile_start_time(itnim->bfa); ... }
so here it is assigned to another u32. Please try to find out if the ioprofile structure can be changed as well, and then either change it as well, or make document the place where the upper bits are lost, whichever is correct.
ArndJust to clarify since I'm a little confused here, io_profile_start_time is the u32 you are mentioning?
Because I made the change for that from u32 to u64 in this patch. And I changed the argument for bfa_io_profile_start_time from u32 to u64 as well.
So which u32 needs to be changed?
There are two structure members named "io_profile_start_time", one in bfa_itnim_s and one in bfa_itnim_ioprofile_s. You changed the former, but the code above assigned from that to the latter.
Arnd