Re: [Y2038] [PATCH 6/6] vfs: change inode times to use struct timespec64

On Fri, May 11, 2018 at 9:59 PM, Deepa Dinamani deepa.kernel@gmail.com wrote:

diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 5fcb845b9fec..fb681d302bb3 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -392,7 +392,7 @@ int pstore_mkfile(struct dentry *root, struct pstore_record *record) inode->i_private = private;

    if (record->time.tv_sec)

•           inode->i_mtime = inode->i_ctime = record->time;
  

•           inode->i_mtime = inode->i_ctime = timespec_to_timespec64(record->time);
  
    d_add(dentry, inode);
  

I'm fine to just convert pstore internally to timespec64 right now. Is it correct to say that I should use timespec64_to_timespec() here until this flag day patch? And I'd need to do this as well, yes?

fs/pstore/platform.c: record->time = ns_to_timespec64(ktime_get_real_fast_ns());

Thanks!

-Kees