Re: [Y2038] [PATCH v4 07/12] char/mmtimer:Convert to the 64bit methods for k_clock callback function

On Wednesday 15 April 2015 19:56:44 Baolin Wang wrote:

if (flags & TIMER_ABSTIME) {

• struct timespec n;
  

• struct timespec64 n;
  

  unsigned long now;

• getnstimeofday(&n);
  

• now = timespec_to_ns(&n);
  

• getnstimeofdayi64(&n);
  

• now = timespec64_to_ns(&n);
  

  if (when > now) when -= now; else

You have a small typo here: getnstimeofday64() instead of getnstimeofdayi64().

Actually, this code could be simplified by using ktime_get_real_ns(), and at the time void the use of the temporary timespec64 value.

Arnd