12 Dec
2019
12 Dec
'19
10:27 a.m.
On Thu, Dec 12, 2019 at 01:28:08AM +0100, Paolo Bonzini wrote:
On 12/12/19 00:05, Michael S. Tsirkin wrote:
@@ -405,6 +405,9 @@ static int virtblk_getgeo(struct block_device *bd, struct hd_geometry *geo) static const struct block_device_operations virtblk_fops = { .ioctl = virtblk_ioctl, +#ifdef CONFIG_COMPAT
- .compat_ioctl = blkdev_compat_ptr_ioctl,
+#endif .owner = THIS_MODULE, .getgeo = virtblk_getgeo, };
Hmm - is virtio blk lumped in with scsi things intentionally?
I think it's because the only ioctl for virtio-blk is SG_IO.
Oh right, I forgot about that one ...
It makes sense to lump it in with scsi, but I wouldn't mind getting rid of CONFIG_VIRTIO_BLK_SCSI altogether.
Paolo