On Fri, Oct 25, 2019 at 9:28 PM Russell King - ARM Linux admin linux@armlinux.org.uk wrote:
On Fri, Oct 25, 2019 at 08:17:36PM +0100, Russell King - ARM Linux admin wrote:
On Thu, Oct 24, 2019 at 01:47:24PM +0100, Vincenzo Frascino wrote:
Okay, having discussed with Arnd what the current situation is, he points out that he needs an additional patch to solve some further build issues with the generic VDSO patches - caused by the Kconfig changes in your first patch.
I'd rather that gets fixed up before I apply the patches, rather than applying a set of patches and a fix on top.
Please re-spin with Arnd's Kconfig changes included.
For reference, this is the change I needed to get randconfig builds working in configurations that did not enable CONFIG_VDSO:
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 32184065ceda..776ac0f4ef0e 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -60,8 +60,6 @@ config ARM select GENERIC_SMP_IDLE_THREAD select GENERIC_STRNCPY_FROM_USER select GENERIC_STRNLEN_USER - select GENERIC_GETTIMEOFDAY - select GENERIC_VDSO_32 select HANDLE_DOMAIN_IRQ select HARDIRQS_SW_RESEND select HAVE_ARCH_AUDITSYSCALL if AEABI && !OABI_COMPAT @@ -112,7 +110,6 @@ config ARM select HAVE_SYSCALL_TRACEPOINTS select HAVE_UID16 select HAVE_VIRT_CPU_ACCOUNTING_GEN - select HAVE_GENERIC_VDSO if AEABI select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NEED_DMA_MAP_STATE diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 608a1f6414c2..dce67c6834a8 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -896,7 +896,10 @@ config VDSO bool "Enable VDSO for acceleration of some system calls" depends on AEABI && MMU && CPU_V7 default y if ARM_ARCH_TIMER + select HAVE_GENERIC_VDSO select GENERIC_TIME_VSYSCALL + select GENERIC_VDSO_32 + select GENERIC_GETTIMEOFDAY help Place in the process address space an ELF shared object providing fast implementations of gettimeofday and