Re: [Y2038] [PATCH v2] trace: Make trace_hwlat timestamp y2038 safe

On Tue, 28 Mar 2017 07:50:17 -0700 Deepa Dinamani deepa.kernel@gmail.com wrote:

diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index 21ea6ae..2257ff1 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -83,7 +83,7 @@ struct hwlat_sample { u64 duration; /* delta */ u64 outer_duration; /* delta (outer loop) */ u64 nmi_total_ts; /* Total time spent in NMIs */

• struct timespec timestamp; /* wall time */

• struct timespec64 timestamp; /* wall time */ int nmi_count; /* # NMIs during this sample */

};

This is a nit, but please make all the fields line up nicely again. That is, add a tab to each line.

Thanks,

-- Steve