On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote:
On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote:
The patch was build-tested / debugged by removing the "if VERBOSE > SHOW_ERROR_MESSAGES" guards.
Stands to reason that we should just remove the (more or less) dead code, since I don't think anyone really ever touches this driver any more or will ever again ...
Do you mean removing all DEBUG() statements from the driver, or removing the entire driver?
We tried removing the driver once, since p54 supposedly drives the same hardware, but some people had certain use cases that didn't work there, apparently.
I was thinking more restrictively of just the stuff that can't even be built without modifying the sources - like the "#if VERBOSE" thing.
johannes