On Thu, Jan 3, 2019 at 9:17 PM Firoz Khan firoz.khan@linaro.org wrote:
On Fri, 4 Jan 2019 at 08:28, Max Filippov jcmvbkbc@gmail.com wrote:
On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan firoz.khan@linaro.org wrote:
while [ $t_nxt -lt $t_nr ]; do
printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}"
printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}"Please add space after the comma.
This was intentional as I was trying compile other one architecture with the previous implementation, it was giving the error. So I modified without space after comma.
I have tested that presence or absence of space does not affect the build for xtensa, and normally we put space after a comma, so I've mentioned that.
Since this script is anyway removed in the next patch of the series it doesn't really matter whether the spaces are present or not.
So, with or without this change: Acked-by: Max Filippov jcmvbkbc@gmail.com