On Thu, Nov 12, 2015 at 6:37 PM, Arnd Bergmann arnd@arndb.de wrote:
On Thursday 12 November 2015 17:52:51 Amitoj Kaur Chawla wrote:
On Thu, Nov 12, 2015 at 2:55 PM, Arnd Bergmann arnd@arndb.de wrote:
On Thursday 12 November 2015 14:12:52 Amitoj Kaur Chawla wrote:
I don't get a build error when I remove the time_t cast. Where am I going wrong?
I meant the reverse: if we remove the definition of time_t, we get a build error unless we also remove that cast.
At the moment, removing the time_t definition will break countless other things in the kernel, so that's hard to try out, but you can imagine what error you would get.
Oh okay. I got it now. Thank you. So keeping in mind that we are eventually removing the time_t definition from the kernel since that is our goal I should send a patch on top.
Ok. Just be aware that this one-line patch is the hardest part here, because the patch description needs to give the reviewers all the information to decide whether to take it as-is and live with the overflow in the future, or redesign their ioctl interface and change their user-space side instead.
Arnd
Oh okay. I'll do my best at describe everything in the changelog.