Re: [Y2038] [PATCH 1/2] m68k: remove nargs from __SYSCALL

Hi Firoz,

Thanks for your patch!

On Wed, Jan 2, 2019 at 4:19 PM Firoz Khan firoz.khan@linaro.org wrote:

The __SYSCALL macro's arguments are system call number, system call entry name and number of arguments for the

name,

system call.

Argument- nargs in __SYSCALL(nr, entry, nargs) is neither

Argument nargs

calculated nor used anywhere. So it would be better to keep the implementaion as __SYSCALL(nr, entry). This will

implementation

unifies the implementation with some other architetures

unify architectures

too.

Signed-off-by: Firoz Khan firoz.khan@linaro.org

arch/m68k/kernel/syscalls/syscalltbl.sh | 4 ++-- arch/m68k/kernel/syscalltable.S | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/kernel/syscalls/syscalltbl.sh b/arch/m68k/kernel/syscalls/syscalltbl.sh index 85d78d9..904b8e6 100644 --- a/arch/m68k/kernel/syscalls/syscalltbl.sh +++ b/arch/m68k/kernel/syscalls/syscalltbl.sh @@ -13,10 +13,10 @@ emit() { t_entry="$3"

    while [ $t_nxt -lt $t_nr ]; do

•           printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}"
  

•           printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}"
  

Please keep the space after the comma.

            t_nxt=$((t_nxt+1))
    done

•   printf "__SYSCALL(%s, %s, )\n" "${t_nxt}" "${t_entry}"
  

•   printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}"
  

Idem ditto.

Gr{oetje,eeting}s,

Geert