Re: [Y2038] [PATCH] drm/exynos/ipp: Replace struct timeval usage

On Monday 01 June 2015 09:09:00 Tina Ruchandani wrote:

@@ -1518,10 +1519,11 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv, e = list_first_entry(&c_node->event_list, struct drm_exynos_ipp_send_event, base.link);

•   do_gettimeofday(&now);
  

•   DRM_DEBUG_KMS("tv_sec[%ld]tv_usec[%ld]\n", now.tv_sec, now.tv_usec);
  

•   getnstimeofday64(&now);
  

•   DRM_DEBUG_KMS("tv_sec[%lld]tv_usec[%lld]\n", now.tv_sec, (now.tv_nsec /
  

•                                                           NSEC_PER_SEC));
    e->event.tv_sec = now.tv_sec;
  

•   e->event.tv_usec = now.tv_usec;
  

•   e->event.tv_usec = now.tv_nsec / NSEC_PER_SEC;
    e->event.prop_id = property->prop_id;
  

Unfortunately, this has two important bugs:

* e->event.tv_sec is defined as a '__u32' variable and is used in a public user space API, so the code is just as broken afterwards as it was before. Fixing this will require adding new ioctl commands.

* You have a typo above: I assume you mean NSEC_PER_USEC instead of NSEC_PER_SEC, the current code will always assign tv_usec to zero, because now.tv_nsec is by definition smaller than NSEC_PER_SEC.

Arnd