29 Sep
2015
29 Sep
'15
3:54 p.m.
On Tuesday 29 September 2015 17:19:14 Ksenija Stanojevic wrote:
Struct timespec will overflow in year 2038, therefore relace it with struct timespec64. Also replace functions getnstimeofday and timespec_sub, which uses struct timespec, with getnstimeofday64 and timespec64_sub.
Signed-off-by: Ksenija Stanojevic ksenija.stanojevic@gmail.com
Same comments as for the fbtbt patch: I'd prefer the use of ktime_get() with ktime_t and monotonic time, over using getnstimeofday64, but the patch looks absolutely correct otherwise.
In the changelog, you could mention that this driver does not actually have an overflow problem, because it only looks at the result of timespec_sub() and that works find across the overflow.
Arnd