On Thu, Dec 14, 2017 at 3:27 PM, Ben Hutchings ben.hutchings@codethink.co.uk wrote:
On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote:
These functions are used in the repurposed compat syscalls to provide backward compatibility for using 32 bit time_t on 32 bit systems.
Signed-off-by: Deepa Dinamani deepa.kernel@gmail.com
[...]
If I'm not mistaken, these functions will be needed only if CONFIG_COMPAT_32BIT_TIME is enabled. Should this be combined with patch #5?
This was purposely decided to be included unconditionally as the only argument against making them conditional is code size. But, these being very small functions it shouldn't matter all that much. I had left this open for discussion. Since I did not hear any preferences, I will make these conditional as Arnd and I discussed.
No, this should not be combined with patch 5. The purpose of that patch is not to include all the code that is conditional upon that config.
-Deepa