Re: [Y2038] [Outreachy kernel] [PATCH v3] Staging: olpc_dcon: Replace timespec with ktime_t

On Thu, Oct 01, 2015 at 05:29:00PM +0200, Ksenija Stanojevic wrote:

Struct timespec will overflow in year 2038, here it will not cause an overflow because it is used with timespec_sub, but still has to be removed as part of y2038 changes. Replace it with ktime_t. Also use monotonic instead of real-time by replacing functions getnstimeofday with ktime_get.

Signed-off-by: Ksenija Stanojevic ksenija.stanojevic@gmail.com

Please always test your patch with checkpatch before sending. It has trailing whitespace.

<snip>

@@ -355,14 +354,14 @@ static void dcon_source_switch(struct work_struct *work) * deassert and reassert, and hope for the best. * see http://dev.laptop.org/ticket/9664 */

• 	delta_t = timespec_sub(dcon->irq_time, dcon->load_time);
  

• 	if (dcon->switched && delta_t.tv_sec == 0 &&
  

• 			delta_t.tv_nsec < NSEC_PER_MSEC * 20) {
  

• 	delta_t = ktime_sub(dcon->irq_time, dcon->load_time);
  

• 	if (dcon->switched && 
  

whitespace error here.

regards sudip