Re: [Y2038] [PATCH v6 16/43] compat_ioctl: move isdn/capi ioctl translation into driver

On Thu, Oct 17, 2019 at 8:25 PM Ben Hutchings ben.hutchings@codethink.co.uk wrote:

On Wed, 2019-10-09 at 21:10 +0200, Arnd Bergmann wrote: [...]

...

--- a/drivers/isdn/capi/capi.c +++ b/drivers/isdn/capi/capi.c @@ -950,6 +950,34 @@ capi_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return ret; }

+#ifdef CONFIG_COMPAT +static long +capi_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{

• int ret;
  

• if (cmd == CAPI_MANUFACTURER_CMD) {
  

•         struct {
  

•                 unsigned long cmd;
  

Should be u32?

Good catch, changed to compat_ulong_t now.

Thanks,

Arnd