On Tuesday 28 April 2015 19:22:10 Baolin Wang wrote:
On 28 April 2015 at 18:31, Arnd Bergmann arnd@linaro.org wrote:
On Tuesday 28 April 2015 16:05:54 Baolin Wang wrote:
arch/powerpc/include/asm/cputime.h | 6 +++--- arch/s390/include/asm/cputime.h | 8 ++++---- include/asm-generic/cputime_jiffies.h | 10 +++++----- include/linux/cputime.h | 15 +++++++++++++++ 4 files changed, 27 insertions(+), 12 deletions(-)
These changes all look ok, but I just noticed that you forgot the fourth implementation in include/asm-generic/cputime_jiffies.h that needs to be adapted as well.
Arnd
Sorry, i have a confusion about that, could you explain what to be adapted in detail? Thanks a lot!
include/asm-generic/cputime.h is based on either cputime_jiffies.h or cputime_nsecs.h, depending on some configuration options.
You have added cputime_to_timespec64/timespec64_to_cputime in one of these two now, but not the other, so any configuration that uses cputime_nsecs.h is now broken.
Arnd