On Mon, 20 Apr 2015, Thomas Gleixner wrote:
On Mon, 20 Apr 2015, Baolin Wang wrote:
This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, and also introduces the conversion methods: itimerspec64_to_itimerspec() and itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year.
Signed-off-by: Baolin Wang baolin.wang@linaro.org
include/linux/time64.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/include/linux/time64.h b/include/linux/time64.h index a383147..3647bdd 100644 --- a/include/linux/time64.h +++ b/include/linux/time64.h @@ -18,6 +18,11 @@ struct timespec64 { }; #endif +struct itimerspec64 {
- struct timespec64 it_interval; /* timer period */
- struct timespec64 it_value; /* timer expiration */
+};
Aside of the macro mess. This really wants to be conditional on 64/32 but in the same way as we have the different implementations for timespec64.
Your patch enforces a useless conversion from and to itimerspec64 even on 64 bit because the compiler cannot map the types.
Sigh. timespec64 is a proper guidance here.
Thanks,
tglx