Hi Arnd,
On Tue, 6 Nov 2018 at 19:04, Arnd Bergmann arnd@arndb.de wrote:
On Mon, Nov 5, 2018 at 10:44 PM Max Filippov jcmvbkbc@gmail.com wrote:
On Thu, Nov 1, 2018 at 6:57 AM Firoz Khan firoz.khan@linaro.org wrote:
index 82c75643..b35d2e6 100644 --- a/arch/xtensa/include/asm/Kbuild +++ b/arch/xtensa/include/asm/Kbuild @@ -28,3 +28,4 @@ generic-y += topology.h generic-y += trace_clock.h generic-y += word-at-a-time.h generic-y += xor.h +generic-y += syscall_table.h
This doesn't look right: syscall_table.h is not asm-generic header.
diff --git a/arch/xtensa/include/uapi/asm/Kbuild b/arch/xtensa/include/uapi/asm/Kbuild index 837d4dd..f826d52 100644 --- a/arch/xtensa/include/uapi/asm/Kbuild +++ b/arch/xtensa/include/uapi/asm/Kbuild @@ -11,3 +11,4 @@ generic-y += resource.h generic-y += siginfo.h generic-y += statfs.h generic-y += termios.h +generic-y += unistd_32.h
Ditto: unistd32_.h is not asm-generic header.
I think the correct syntax here would be
generated-y += unistd_32.h
Firoz, if I remember correctly, this came up before, maybe you just did not update all architectures together?
My initial patches does have generated-y += unistd_32.h instead of generic-y += unistd_32.h. If I remember someone pointed out that this implementation doesn't look good. So I replaced to generic-y += unistd_32.h.
Sure, I'll change to generated-y += unistd_32.h instead of generic-y += unistd_32.h.
Max, this looks ok. right?
Thanks Firoz
Arnd