On Apr 22, 2016 8:09 PM, "Kalle Valo" kvalo@codeaurora.org wrote:
Johannes Berg johannes@sipsolutions.net writes:
On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote:
On Sunday 17 April 2016 14:42:33 Johannes Berg wrote:
I was thinking more restrictively of just the stuff that can't even be built without modifying the sources - like the "#if VERBOSE" thing.
All the DEBUG() statements are inside of this kind of check, so if we remove the #ifdefs, it would be logical to remove the rest of the debugging infrastructure (DEBUG() macros, SHOW_*, pc_debug, maybe more) as well.
Seems reasonable.
Maybe we should Cc the maintainer, but I suspect that since the driver is marked Obsolete anyway Luis won't care either :)
I'm planning to apply this patch anyway, the debugging infrastructure removal can be a followup patch. But please let me know if I should drop this instead.
I'd say let's bury the driver now. We have a process to stage large chunks of poo now through staging, let's use that to shaft prism54 there now and give it a few cycles to let people call bloody murder before finally removing. We need to do better at deleting ancient legacy shit. I'll stand behind this one. Sue me if needed.
Luis