Re: [Y2038] [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

On 06/20/2016 04:48 PM, Arnd Bergmann wrote:

On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote:

...

On 06/17/2016 05:47 PM, Arnd Bergmann wrote:

...

• jiffies_to_timespec(jiffies, &v0);
  

• jiffies_to_timespec(lport->boot_time, &v1);
  

• fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec);
  

• fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ;
  

Does this patch introduce a 64-bit division? There might still be 32-bit users of this code.

No, both lport->boot_time and jiffies are 'unsigned long'.

Ah, you're right. Hence:

Reviewed-by: Bart Van Assche bart.vanassche@sandisk.com